consumeWindowInsets extension var is on ComposeView rather than AbstractComposeView [269479941]

Fixed

Feature Request

Status Update

No update yet.

Description

di...@gmail.com

created issue #1

Feb 15, 2023 10:38PM

The `ComposeView.consumeWindowInsets: Boolean` extension var seems like it should work just as well for `AbstractComposeView`, since the implementation just checks the view tag. Changing the receiver type to `AbstractComposeView` would enable other subclasses to use this var too.

Jetpack Compose version: 1.4.0-beta01
Jetpack Compose component(s) used: Foundation

Comments

le...@google.com <le...@google.com> Feb 17, 2023 11:42AM

Reassigned to uo...@google.com.

uo...@google.com <uo...@google.com> #2May 16, 2023 06:36AM

Reassigned to mo...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

mo...@google.com <mo...@google.com> #3May 17, 2023 03:55PM

Reassigned to uo...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

uo...@google.com <uo...@google.com> #4May 17, 2023 07:12PM

Accepted by uo...@google.com.

Thanks, George. I'll get a CL out shortly.

uo...@google.com <uo...@google.com> Jul 14, 2023 02:10AM

Marked as fixed.

ap...@google.com <ap...@google.com> #5Jul 14, 2023 02:11AM

Project: platform/frameworks/support
Branch: androidx-main

commit cfdb41b43ee8566701e3f309145ad8f521080576
Author: Faithful Uchenna Okoye <uokoye@google.com>
Date: Wed Jul 12 04:24:57 2023

Make consumeWindowInsets use the superclass

Makes the consumeWindowInsets use the superclass AbstractComposeView
Bug: 269479941
Test: No tests needed
Relnote: Updates the modifier consumeWindowInsets to extend the superclass AbstractComposeView

Change-Id: Iacd74d1928c018276c3d923d55c959c644273b22

A compose/foundation/foundation-layout/api/current.ignore
M compose/foundation/foundation-layout/api/current.txt
A compose/foundation/foundation-layout/api/restricted_current.ignore
M compose/foundation/foundation-layout/api/restricted_current.txt
M compose/foundation/foundation-layout/src/androidMain/kotlin/androidx/compose/foundation/layout/WindowInsets.android.kt

https://android-review.googlesource.com/2655340

na...@google.com <na...@google.com> #6Jul 26, 2023 05:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation-layout:1.6.0-alpha02
androidx.compose.foundation:foundation-layout-android:1.6.0-alpha02

ah...@gmail.com <ah...@gmail.com> #7Nov 11, 2023 07:59PM

Hi, If I am not mistaken, I think this might be a binary incompatible change. I ran into it by updating compose material3 to the beta, which then transitively updated foundation-layout and foundation-layout-android to 1.6.0-alpha08, and caused crashes in my code that was setting consuemWindowInsets without explicitly updating foundation-layout and foundation-layout-android:

Caused by: java.lang.NoSuchMethodError: No static method setConsumeWindowInsets(Landroidx/compose/ui/platform/ComposeView;Z)V in class Landroidx/compose/foundation/layout/WindowInsets_androidKt; or its super classes (declaration of 'androidx.compose.foundation.layout.WindowInsets_androidKt' appears in /data/app/~~tQvQdAB1mEbqBijRkQ5WAA==/com.ayah.debug-hJ5WXMyk3hG_A7UjqKIhpA==/base.apk)

You can work around it by explicitly bumping foundation-layout (or a transitive dependency that causes foundation-layout to be bumped, such as the compose material3 beta) in the affected modules.