consumeWindowInsets extension var is on ComposeView rather than AbstractComposeView [269479941]

Fixed

Feature Request

Status Update

No update yet.

Description

di...@gmail.com

created issue #1

Feb 15, 2023 10:38PM

The `ComposeView.consumeWindowInsets: Boolean` extension var seems like it should work just as well for `AbstractComposeView`, since the implementation just checks the view tag. Changing the receiver type to `AbstractComposeView` would enable other subclasses to use this var too.

Jetpack Compose version: 1.4.0-beta01
Jetpack Compose component(s) used: Foundation

Comments

le...@google.com <le...@google.com> Feb 17, 2023 11:42AM

Reassigned to uo...@google.com.

uo...@google.com <uo...@google.com> #2May 16, 2023 06:36AM

Reassigned to mo...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

mo...@google.com <mo...@google.com> #3May 17, 2023 03:55PM

Reassigned to uo...@google.com.

Looks right to me.

uo...@google.com <uo...@google.com> #4May 17, 2023 07:12PM

Accepted by uo...@google.com.

Thanks, George. I'll get a CL out shortly.

uo...@google.com <uo...@google.com> Jul 14, 2023 02:10AM

Marked as fixed.

ap...@google.com <ap...@google.com> #5Jul 14, 2023 02:11AM

Project: platform/frameworks/support
Branch: androidx-main

commit cfdb41b43ee8566701e3f309145ad8f521080576
Author: Faithful Uchenna Okoye <uokoye@google.com>
Date: Wed Jul 12 04:24:57 2023

Make consumeWindowInsets use the superclass

Makes the consumeWindowInsets use the superclass AbstractComposeView
Bug: 269479941
Test: No tests needed
Relnote: Updates the modifier consumeWindowInsets to extend the superclass AbstractComposeView

Change-Id: Iacd74d1928c018276c3d923d55c959c644273b22

A compose/foundation/foundation-layout/api/current.ignore
M compose/foundation/foundation-layout/api/current.txt
A compose/foundation/foundation-layout/api/restricted_current.ignore
M compose/foundation/foundation-layout/api/restricted_current.txt
M compose/foundation/foundation-layout/src/androidMain/kotlin/androidx/compose/foundation/layout/WindowInsets.android.kt

https://android-review.googlesource.com/2655340

na...@google.com <na...@google.com> #6Jul 26, 2023 05:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation-layout:1.6.0-alpha02
androidx.compose.foundation:foundation-layout-android:1.6.0-alpha02

ah...@gmail.com <ah...@gmail.com> #7Nov 11, 2023 07:59PM

Hi, If I am not mistaken, I think this might be a binary incompatible change. I ran into it by updating compose material3 to the beta, which then transitively updated foundation-layout and foundation-layout-android to 1.6.0-alpha08, and caused crashes in my code that was setting consuemWindowInsets without explicitly updating foundation-layout and foundation-layout-android:

Caused by: java.lang.NoSuchMethodError: No static method setConsumeWindowInsets(Landroidx/compose/ui/platform/ComposeView;Z)V in class Landroidx/compose/foundation/layout/WindowInsets_androidKt; or its super classes (declaration of 'androidx.compose.foundation.layout.WindowInsets_androidKt' appears in /data/app/~~tQvQdAB1mEbqBijRkQ5WAA==/com.ayah.debug-hJ5WXMyk3hG_A7UjqKIhpA==/base.apk)

You can work around it by explicitly bumping foundation-layout (or a transitive dependency that causes foundation-layout to be bumped, such as the compose material3 beta) in the affected modules.