consumeWindowInsets extension var is on ComposeView rather than AbstractComposeView [269479941]

Fixed

Feature Request

Status Update

No update yet.

Description

di...@gmail.com

created issue #1

Feb 15, 2023 10:38PM

The `ComposeView.consumeWindowInsets: Boolean` extension var seems like it should work just as well for `AbstractComposeView`, since the implementation just checks the view tag. Changing the receiver type to `AbstractComposeView` would enable other subclasses to use this var too.

Jetpack Compose version: 1.4.0-beta01
Jetpack Compose component(s) used: Foundation

Comments

le...@google.com <le...@google.com> Feb 17, 2023 11:42AM

Reassigned to uo...@google.com.

uo...@google.com <uo...@google.com> #2May 16, 2023 06:36AM

Reassigned to mo...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

mo...@google.com <mo...@google.com> #3May 17, 2023 03:55PM

Reassigned to uo...@google.com.

Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.

uo...@google.com <uo...@google.com> #4May 17, 2023 07:12PM

Accepted by uo...@google.com.

I'll schedule it for the next release. Note that alpha04 is a complete turn-down of the library where all APIs are marked as Deprecated, so you'll also want to start removing your usages of the library.

uo...@google.com <uo...@google.com> Jul 14, 2023 02:10AM

Marked as fixed.

ap...@google.com <ap...@google.com> #5Jul 14, 2023 02:11AM

Project: platform/frameworks/support
Branch: androidx-main

commit 19ed7e69823a09f3c63f8c8cdf339af8ca1645ab
Author: Alan Viverette <alanv@google.com>
Date: Mon Mar 14 15:18:16 2022

Bump textclassifier for final release and turn-down

Bug: 210509084
Change-Id: Ib8b2386903bb49baa3211f7de7fe1587fdda1483
Test: ./gradlew checkApi

M libraryversions.toml

https://android-review.googlesource.com/2024823

na...@google.com <na...@google.com> #6Jul 26, 2023 05:21PM

Bugjuggler: wait until 2022-03-23

ah...@gmail.com <ah...@gmail.com> #7Nov 11, 2023 07:59PM

Hi. I've received your bug and will wait until 2022-03-23 00:00 -0400 EDT and then assign the bug to alanv@google.com.