Resource compilation fails when Kotlin compiler tries to update to IDEA 21.3 [269585156]

Fixed

Bug

Status Update

No update yet.

Description

ga...@google.com

created issue #1

Feb 16, 2023 12:34PM

Context: Kotlin compiler depends on IDEA platform, and it is now trying to update to IDEA 21.3. This version of IDEA SDK depends on com.fasterxml:aalto-xml:1.3.0.

Having com.fasterxml:aalto-xml:1.3.0 in the classpath causes resource compilation to fail in AGP. Using the attached project and running ./gradlew asDeb fails with:

Caused by: com.android.aaptcompiler.ResourceCompilationException: Resource compilation failed (Failed to compile resource file: /usr/local/google/home/gavra/AndroidStudioProjects/MyApplication107/app/src/main/res/drawable-v24/ic_launcher_foreground.xml: . Cause: java.lang.RuntimeException: com.example.myapplication.app-main-30:/drawable-v24/ic_launcher_foreground.xml:8:9: Invalid namespace prefix 'android' for value of 'name' attribute 'android:attr/fillColor'.). Check logs for more details.
        at com.android.aaptcompiler.ResourceCompiler.compileResource(ResourceCompiler.kt:129)
        at com.android.build.gradle.internal.res.ResourceCompilerRunnable$Companion.compileSingleResource(ResourceCompilerRunnable.kt:34)
        at com.android.build.gradle.internal.res.ResourceCompilerRunnable.run(ResourceCompilerRunnable.kt:15)
        at com.android.build.gradle.internal.profile.ProfileAwareWorkAction.execute(ProfileAwareWorkAction.kt:74)
        at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:63)
        at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:66)
        at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:62)
        at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:100)
        at org.gradle.workers.internal.NoIsolationWorkerFactory$1.lambda$execute$0(NoIsolationWorkerFactory.java:62)
        at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:44)
        at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:41)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
        at org.gradle.workers.internal.AbstractWorker.executeWrappedInBuildOperation(AbstractWorker.java:41)
        at org.gradle.workers.internal.NoIsolationWorkerFactory$1.execute(NoIsolationWorkerFactory.java:59)
        at org.gradle.workers.internal.DefaultWorkerExecutor.lambda$submitWork$0(DefaultWorkerExecutor.java:169)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runExecution(DefaultConditionalExecutionQueue.java:187)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.access$700(DefaultConditionalExecutionQueue.java:120)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner$1.run(DefaultConditionalExecutionQueue.java:162)
        at org.gradle.internal.Factories$1.create(Factories.java:31)
        at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:249)
        at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:109)
        at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:114)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runBatch(DefaultConditionalExecutionQueue.java:157)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.run(DefaultConditionalExecutionQueue.java:126)
        ... 2 more
Caused by: com.android.aaptcompiler.ResourceCompilationException: Failed to compile resource file: /usr/local/google/home/gavra/AndroidStudioProjects/MyApplication107/app/src/main/res/drawable-v24/ic_launcher_foreground.xml: 
        at com.android.aaptcompiler.ResourceCompiler.compileXml(ResourceCompiler.kt:328)
        at com.android.aaptcompiler.ResourceCompiler.access$compileXml(ResourceCompiler.kt:1)
        at com.android.aaptcompiler.ResourceCompiler$getCompileMethod$2.invoke(ResourceCompiler.kt:149)
        at com.android.aaptcompiler.ResourceCompiler$getCompileMethod$2.invoke(ResourceCompiler.kt:149)
        at com.android.aaptcompiler.ResourceCompiler.compileResource(ResourceCompiler.kt:123)
        ... 32 more
Caused by: java.lang.RuntimeException: com.example.myapplication.app-main-30:/drawable-v24/ic_launcher_foreground.xml:8:9: Invalid namespace prefix 'android' for value of 'name' attribute 'android:attr/fillColor'.
        at com.android.aaptcompiler.XmlProcessor.outlineAttribute(XmlProcessor.kt:355)
        at com.android.aaptcompiler.XmlProcessor.processElement(XmlProcessor.kt:280)
        at com.android.aaptcompiler.XmlProcessor.processElement$default(XmlProcessor.kt:185)
        at com.android.aaptcompiler.XmlProcessor.processElement(XmlProcessor.kt:289)
        at com.android.aaptcompiler.XmlProcessor.processElement$default(XmlProcessor.kt:185)
        at com.android.aaptcompiler.XmlProcessor.process(XmlProcessor.kt:127)
        at com.android.aaptcompiler.ResourceCompiler.compileXml(ResourceCompiler.kt:326)

We should investigate the root cause in order to unblock IDEA SDK update in the Kotlin compiler.

aalto.zip

424 KB

Download

Comments

ga...@google.com <ga...@google.com> #2Feb 16, 2023 12:35PM

Assigned to ga...@google.com.

The root cause is probably service one of the services registered in https://github.com/FasterXML/aalto-xml/blob/0820590fcf56ec3d5ca14608d6145e14e56f2650/src/main/resources/META-INF/services/javax.xml.stream.XMLEventFactory#L1.

ga...@google.com <ga...@google.com> #3Feb 16, 2023 12:43PM

The issue is that AGP ends up loading com.fasterxml.aalto.stax.InputFactoryImpl as that's returned by XMLInputFactory.newFactory().

Without this library on the buildscript classpath we end up loading com.sun.xml.internal.stream.XMLInputFactoryImpl.

Message last modified on Feb 16, 2023 12:44PM

ga...@google.com <ga...@google.com> #4Feb 16, 2023 12:55PM

Reassigned to je...@google.com.

Jerome, I remember you were looking into XML parsers. Should we always be using XMLInputFactory.newDefaultFactory()?

je...@google.com <je...@google.com> Sep 27, 2023 09:07PM

Reassigned to mi...@google.com.

je...@google.com <je...@google.com> #5Oct 19, 2023 09:24PM

looks like we are indeed using newFactory at https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:build-system/aaptcompiler/src/main/java/com/android/aaptcompiler/XmlUtil.kt;l=8

and should probably instead just use newDefaultFactory() as suggested in #4

mi...@google.com <mi...@google.com> Oct 24, 2023 02:50AM

Marked as fixed.

an...@google.com <an...@google.com> #6Oct 26, 2023 09:01PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Iguana | 2023.2.1 Canary 11
Android Gradle Plugin 8.3.0-alpha11

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!