Can we remove AnalyticsRecordingTask? [269758603]

Fixed

Bug

Status Update

No update yet.

Description

cm...@google.com

created issue #1

Feb 17, 2023 05:59PM

Now that application IDs are known at configuration time, can we move this behaviour back in to the AnalyticsConfiguratorService to remove a never-up-to-date task?

(Request from AndroidX team)

Comments

bi...@google.com <bi...@google.com> #2Feb 17, 2023 06:21PM

That sounds good! Out of curiosity, what has changed to make it available at configuration time now? Can you share a little bit more context?

cm...@google.com <cm...@google.com> #3Feb 20, 2023 06:43PM

We decided there was no use case for having an application ID come from a task, and it created a lot of problems from the studio side.

So it's always read during sync, so it's safe to read in AGP during configuration time

Context: b/231946504 ag/18283588

Message last modified on Feb 20, 2023 06:43PM

bi...@google.com <bi...@google.com> #4Feb 21, 2023 06:14PM

Thanks for the context, Chris!

au...@google.com <au...@google.com> #5Mar 1, 2023 10:46PM

What needs to be done here?

bi...@google.com <bi...@google.com> #6Mar 6, 2023 07:50PM

re #3, Chris, it seems the application id now only comes from dsl instead of potentially from manifest file?

cm...@google.com <cm...@google.com> #7Mar 7, 2023 04:32PM

Yes, that's correct since ag/If3dff2353168aa681de0e1b91918017762b50fd7 (so we never read package name or application id from the manifest)

bi...@google.com <bi...@google.com> #8Mar 8, 2023 04:51PM

Aurimas, it seems androidx has reference to AnalyticsRecordingTask which is going to be removed in ag/21804942. see the build failure here https://android-build.googleplex.com/builds/pending/P51738961/androidx-vitals/latest/view/logs/build_error.log Can you help with that?

bi...@google.com <bi...@google.com> Mar 8, 2023 11:38PM

Marked as fixed.