Add an option to not include line and column numbers in lint baseline [269759189]

Fixed

Feature Request

Status Update

No update yet.

Description

au...@google.com

created issue #1

Feb 17, 2023 05:58PM

Today, running updateLintBaselines adds line and column numbers to the baseline xml file. For projects that have upstream and downstream branches that automerge, this is problematic as it leads to merge conflicts if baselines are updated out of band. Lint can already run just fine without line and column numbers in the baseline file - it fuzzy matches.

This is a feature request for Android Gradle Plugin to do this for us. AndroidX currently has a task that intercepts the xml and does this rewrite and we'd like to drop that hack.

Comments

ha...@google.com <ha...@google.com> Feb 21, 2023 07:11PM

Assigned to an...@google.com.

au...@google.com <au...@google.com> #2Feb 22, 2023 10:59PM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

pa...@google.com <pa...@google.com> #3Feb 23, 2023 04:54PM

Status: New

Almost 2 months later and this is still broken

au...@google.com <au...@google.com> #4Apr 4, 2023 07:58PM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

gh...@google.com <gh...@google.com> #5Apr 4, 2023 08:43PM

Assigned to pa...@google.com.

jb...@google.com What is the update on this?

pa...@google.com <pa...@google.com> #6Apr 5, 2023 09:33AM

What is the status of this item?

au...@google.com <au...@google.com> #7May 1, 2023 09:35PM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

au...@google.com <au...@google.com> #8May 23, 2023 04:58PM

Any ETA on next release?

pa...@google.com <pa...@google.com> #9May 23, 2023 05:07PM

Reassigned to sp...@google.com.

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

sp...@google.com <sp...@google.com> #10May 23, 2023 05:23PM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

pa...@google.com <pa...@google.com> #11May 23, 2023 05:32PM

Hi, is there any update to this issue? Thanks.

au...@google.com <au...@google.com> #12May 23, 2023 05:36PM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

sp...@google.com <sp...@google.com> #13May 26, 2023 03:19PM

Marked as fixed.

Yeah, still not fixed --'