Fixed
Status Update
Comments
ha...@google.com <ha...@google.com>
ti...@google.com <ti...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit ed4cbc0c50bb906d78cc1617be5ad7fcb14c56f5
Author: Oscar Adame Vázquez <oscarad@google.com>
Date: Wed Jan 17 13:54:01 2024
Add Alignment parameter to animateContentSize
Note that it actually adds a new function altogether to fit existing
use cases where the trailing lambda causes the API to be inflexible
(can't add parameters before or after the lambda).
Relnote: "Added alignment parameter to` Modifier.animateContentSize()`."
Bug: 269803907
Test: AnimationModifierTest.testAlignmentInAnimateContentSize
Change-Id: I5623af336f137bb4464cbf7993942452e86bcd88
M compose/animation/animation/api/current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/src/androidInstrumentedTest/kotlin/androidx/compose/animation/AnimationModifierTest.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimationModifier.kt
https://android-review.googlesource.com/2915193
Branch: androidx-main
commit ed4cbc0c50bb906d78cc1617be5ad7fcb14c56f5
Author: Oscar Adame Vázquez <oscarad@google.com>
Date: Wed Jan 17 13:54:01 2024
Add Alignment parameter to animateContentSize
Note that it actually adds a new function altogether to fit existing
use cases where the trailing lambda causes the API to be inflexible
(can't add parameters before or after the lambda).
Relnote: "Added alignment parameter to` Modifier.animateContentSize()`."
Bug: 269803907
Test: AnimationModifierTest.testAlignmentInAnimateContentSize
Change-Id: I5623af336f137bb4464cbf7993942452e86bcd88
M compose/animation/animation/api/current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/src/androidInstrumentedTest/kotlin/androidx/compose/animation/AnimationModifierTest.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimationModifier.kt
os...@google.com <os...@google.com>
pr...@google.com <pr...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.animation:animation:1.7.0-alpha03
androidx.compose.animation:animation-android:1.7.0-alpha03
androidx.compose.animation:animation-desktop:1.7.0-alpha03
Description
Right now,
Modifier.animateContentSize
places its content viaplaceable.placeRelative(0, 0)
inside the animating space.This effectively means that the content is always placed with an alignment strategy
Alignment.TopStart
, which may not be the desired effect for some content.Could
Modifier.animateContentSize
add anAlignment
argument (with a default value ofAlignment.TopStart
to preserve current behavior) to allow customizing the placement strategy of the content?