androidx.webkit:webkit:1.6.0 breaks ProGuard with invalid rule [270034835]

Verified

Bug

Status Update

No update yet.

Description

an...@erstegroup.com

created issue #1

Feb 21, 2023 07:07AM

Component used: androidx.Webkit

Version used: 1.6.0

Devices/Android versions reproduced on: any

androidx.webkit:webkit:1.6.0 contains a new proguard rule that's invalid

-keepnames public class androidx.webkit.ProcessGlobalConfig {
    private static final * sProcessGlobalConfig;
}

Comments

nt...@google.com <nt...@google.com> Feb 21, 2023 05:50PM

Reassigned to ab...@google.com.

ab...@google.com <ab...@google.com> #2Feb 22, 2023 03:18PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

an...@erstegroup.com <an...@erstegroup.com> #3Feb 22, 2023 03:26PM

Great! Thanks a lot, I'll look for the live updates soon!

ap...@google.com <ap...@google.com> #4Feb 22, 2023 07:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit 95beb5f0b54b912a148fe2474ed0adb422857ba2
Author: Abhijith Nair <abhijithnair@google.com>
Date: Wed Feb 22 15:42:25 2023

Fix proguard parse error

It seems like the existing proguard config had a syntax error even
though R8 did not complain about it. This seems to cause an issue when
DexGuard is used.

Tested by analysing the APK and verifying that sProcessGlobalConfig is retained in both cases (with * and with ***) by R8. That said, according to

https://playground.proguard.com/p/bmaZvZ, it seems like '*' is not accepted syntax even though it is accepted by R8. '***' is accepted syntax.

Bug: 270034835
Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Change-Id: Ia65c2fd50327eda385bc0ec061f4ad08a7afe81d

M webkit/webkit/proguard-rules.pro

https://android-review.googlesource.com/2450645

ab...@google.com <ab...@google.com> #5Feb 24, 2023 12:55PM

We have identified the problem and has fixed it in main branch.
We will let you know once we release the fix.

Thanks again for filing the bug!

an...@erstegroup.com <an...@erstegroup.com> #6Feb 24, 2023 01:03PM

Awesome, thanks for taking care of it so fast!

ab...@google.com <ab...@google.com> #7Mar 9, 2023 11:51AM

https://developer.android.com/jetpack/androidx/releases/webkit#1.7.0-alpha03 has released and contains the fix.
Could you please verify it works for you, this would enable us to push it to stable with more confidence. Thanks!

an...@erstegroup.com <an...@erstegroup.com> #8Mar 10, 2023 01:34PM

Hi, I can verify the fix provided in 1.7.0-alpha03 now works with DexGuard. Thanks again for your help!

ab...@google.com <ab...@google.com> Mar 10, 2023 01:59PM

Verified by ab...@google.com.

pr...@google.com <pr...@google.com> #9Mar 22, 2023 08:23PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.webkit:webkit:1.6.1

pr...@google.com <pr...@google.com> #10Sep 6, 2023 07:56PM