TrustAllX509TrustManager lint check incorrectly flags interfaces that extends X509TrustManager [270065082]

Fixed

Bug

Status Update

No update yet.

Description

ry...@intune.corp-partner.google.com

created issue #1

Feb 21, 2023 04:16PM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE: 1.Create an interface that extends X509TrustManager

public interface ExtendedX509TrustManager extends X509TrustManager {
    List<X509Certificate> checkServerTrusted(X509Certificate[] chain, String authType, String host)
            throws CertificateException;
}

Extend the new interface correctly implementing checkServerTrusted and checkClientTrusted.
run gradlew lintDebug

EXPECTED: lint should pass ACTUAL: lint flags ExtendedX509TrustManager interface for not implementing checkServerTrusted or checkClientTrusted even though it is just and interface. The classes that fully implement the interface are not flagged (as expected).

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: Version of Gradle Plugin: Version of Gradle: Version of Java: OS:

Comments

ry...@intune.corp-partner.google.com <ry...@intune.corp-partner.google.com> #2Feb 21, 2023 04:20PM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

ha...@google.com <ha...@google.com> Feb 21, 2023 06:22PM

Assigned to an...@google.com.

tn...@google.com <tn...@google.com> Feb 23, 2023 08:26PM

Reassigned to tn...@google.com.

tn...@google.com <tn...@google.com> #3Feb 24, 2023 10:59PM

Marked as fixed.

Almost 2 months later and this is still broken

da...@robinhood.com <da...@robinhood.com> #4Aug 9, 2023 04:21PM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

Issue 270065082