processDebugMainManifest task is failed since Android Gradle Plugin 8.1 [270201653]

Fixed

Bug

Status Update

No update yet.

Description

ga...@linecorp.com

created issue #1

Feb 21, 2023 11:43PM

DESCRIBE THE ISSUE IN DETAIL:
Since Android Gradle Plugin 8.1.0-alpha02, `:app:processDebugMainManifest` task was failed.

STEPS TO REPRODUCE:
1. AndroidManifest.xml has following elements to display badge count on several launchers.
```
<manifest>
<queries>
<provider android:authorities="com.sonymobile.home.resourceprovider" />
<provider android:authorities="com.android.badge" />
<provider android:authorities="com.huawei.android.launcher.settings" />
</queries>
</manifest>
```

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)
```
$ ./gradlew :app:bundleDebug

> Task :app:processDebugMainManifest FAILED
app/src/main/AndroidManifest.xml:2187:19-77 Error:
Attribute provider@authorities value=(com.sonymobile.home.resourceprovider) from AndroidManifest.xml:2187:19-77
is also present at AndroidManifest.xml:2188:19-58 value=(com.android.badge).
Suggestion: add 'tools:replace="android:authorities"' to <provider> element at AndroidManifest.xml to override.
app/src/main/AndroidManifest.xml:2187:19-77 Error:
Attribute provider@authorities value=(com.sonymobile.home.resourceprovider) from AndroidManifest.xml:2187:19-77
is also present at AndroidManifest.xml:2189:19-77 value=(com.huawei.android.launcher.settings).
Suggestion: add 'tools:replace="android:authorities"' to <provider> element at AndroidManifest.xml to override.

See

https://developer.android.com/r/studio-ui/build/manifest-merger for more information about the manifest merger.

```

Workaround : Just add `tools:replace="android:authorities"` on provider element
```
<manifest>
<queries>
<provider android:authorities="com.sonymobile.home.resourceprovider" />
<provider android:authorities="com.android.badge"
tools:replace="android:authorities" />
<provider android:authorities="com.huawei.android.launcher.settings"
tools:replace="android:authorities" />
</queries>
</manifest>
```
But it seems to be weird, because these should not be replaced by `processDebugMainManifest` task.

------------------

IMPORTANT: Please read

https://developer.android.com/studio/report-bugs.html carefully and supply
all required information.

------------------

Studio Build: N/A
Version of Gradle Plugin: Android Gradle Plugin 8.1.0-alpha02 - alpha06 (latest alpha release)
Version of Gradle: 8.0
Version of Java: OpenJDK 17
OS: Any

Comments

ha...@google.com <ha...@google.com> Feb 22, 2023 01:27AM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Feb 27, 2023 07:55PM

Reassigned to am...@google.com.

am...@google.com <am...@google.com> #2Feb 27, 2023 09:09PM

Can you confirm that you started seeing this issue only from AGP 8.1 onwards? Wondering if you know the last AGP version where this can be reproduced.

am...@google.com <am...@google.com> #3Feb 28, 2023 01:18PM

I am unable to reproduce this bug. If I create a new project with a single module and add the queries block you provided in the description, the processDebugManifest does not fail. From the error message, it appears that we are merging the file with itself. Can you confirm that this fails for you on a new project with a single module and this queries block in manifest file? Please share the sample project on which we can reproduce this if possible.

ga...@linecorp.com <ga...@linecorp.com> #4Mar 2, 2023 12:42AM

I uploaded failed case on https://github.com/ganadist/VersionCodeDemo/tree/ManifestMergerFail

And I found this error is related with flavor specific AndroidManifest.xml

$ git clone https://github.com/ganadist/VersionCodeDemo -b ManifestMergerFail
$ cd VersionCodeDemo
$ ./gradlew :app:bundleDevelopDebug

> Task :app:processDevelopDebugMainManifest FAILED
VersionCodeDemo/app/src/develop/AndroidManifest.xml:24:19-77 Error:
        Attribute provider@authorities value=(com.sonymobile.home.resourceprovider) from AndroidManifest.xml:24:19-77
        is also present at AndroidManifest.xml:25:19-58 value=(com.android.badge).
        Suggestion: add 'tools:replace="android:authorities"' to <provider> element at AndroidManifest.xml to override.
VersionCodeDemo/app/src/develop/AndroidManifest.xml:24:19-77 Error:
        Attribute provider@authorities value=(com.sonymobile.home.resourceprovider) from AndroidManifest.xml:24:19-77
        is also present at AndroidManifest.xml:26:19-77 value=(com.huawei.android.launcher.settings).
        Suggestion: add 'tools:replace="android:authorities"' to <provider> element at AndroidManifest.xml to override.

am...@google.com <am...@google.com> #5Mar 2, 2023 02:49AM

Thanks. I can reproduce the issue now. The problem is in manifest merger process. We incrementally build the merged manifest as we merge the elements of manifest file of the dependencies. Here, we have 3 provider nodes and after adding the first one, when we try to merge the next provider node, we are incorrectly looking for the provider node in merged manifest. I am working on a fix right now. This is a regression.

am...@google.com <am...@google.com> #6Mar 8, 2023 11:02PM

Marked as fixed.

Fix for this is checked-in(in studio-main). It will be available in Giraffe Canary 9.

ga...@linecorp.com <ga...@linecorp.com> #7Mar 15, 2023 01:04AM

I tried to check with Giraffe Canary 9.
And I confirmed my issue was solved.

Thank you for your help.