M3 ModalBottomSheet ignores confirmValueChange [270425759]

Fixed

Bug

Status Update

No update yet.

Description

er...@gmail.com

created issue #1

Feb 22, 2023 09:39PM

Jetpack Compose version: 1.3.3, material3:1.1.0-alpha06
Jetpack Compose component used: material3 ModalBottomSheet

The callback for the ModalBottomSheet SheetState.confirmValueChange is never called before changing state, and looking at the source it seems like it's never invoked.

This prevents disabling Scrim touch-to-dismiss

Comments

se...@google.com <se...@google.com> #2Feb 23, 2023 04:19PM

Reassigned to se...@google.com.

Thanks for filing this, will look into it ASAP but in the meantime, do you mind sharing some minimal code to duplicate. Is it simply using confirmValueChange in the provided sample?

er...@gmail.com <er...@gmail.com> #3Feb 23, 2023 05:11PM

Thanks!

Yeah, you can just use the sample from here: https://developer.android.com/reference/kotlin/androidx/compose/material3/package-summary#ModalBottomSheet(kotlin.Function0,androidx.compose.ui.Modifier,androidx.compose.material3.SheetState,androidx.compose.ui.graphics.Shape,androidx.compose.ui.graphics.Color,androidx.compose.ui.graphics.Color,androidx.compose.ui.unit.Dp,androidx.compose.ui.graphics.Color,kotlin.Function0,kotlin.Function1)

But use

val bottomSheetState = rememberSheetState(skipHalfExpanded = false, confirmValueChange = {false})

for the state. You can even throw an exception in the callback, because it's never called so it's never thrown.

Looking at your code for the Scrim you have this:

detectTapGestures {
    onDismissRequest()
}

And that onDismissRequest() is defined as:

onDismissRequest = {
    scope.launch { sheetState.hide() }.invokeOnCompletion {
         if (!sheetState.isVisible) { onDismissRequest() }               
    }
},

So I guess somewhere in one of those, you'd need to look at confirmValueChange first.

se...@google.com <se...@google.com> Feb 23, 2023 05:15PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #4Feb 28, 2023 01:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 10e697083c409d189945cc57a19e45c3a6dc2e55
Author: José Figueroa Santos <serniebanders@google.com>
Date: Thu Feb 23 14:23:29 2023

[Material3][BottomSheet] Update scrim to confirm value change before tapping

RelNote: Add confirmValueChange check to scrim tap for ModalBottomSheet.
Test: Update confirmValueChange test to include scrim tap
Bug: 270425759

Change-Id: I2311a043ffbac63c4278fce9d0e73450fc808201

M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt

https://android-review.googlesource.com/2455849

se...@google.com <se...@google.com> #5Feb 28, 2023 01:16PM

Marked as fixed.

I believe this should land with alpha08

na...@google.com <na...@google.com> #6Mar 8, 2023 07:51PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.1.0-alpha08

Issue 270425759