M3 ModalBottomSheet ignores confirmValueChange [270425759]

Fixed

Bug

Status Update

No update yet.

Description

er...@gmail.com

created issue #1

Feb 22, 2023 09:39PM

Jetpack Compose version: 1.3.3, material3:1.1.0-alpha06
Jetpack Compose component used: material3 ModalBottomSheet

The callback for the ModalBottomSheet SheetState.confirmValueChange is never called before changing state, and looking at the source it seems like it's never invoked.

This prevents disabling Scrim touch-to-dismiss

Comments

se...@google.com <se...@google.com> #2Feb 23, 2023 04:19PM

Reassigned to se...@google.com.

Any update on this?
The request is DiffUtil implementation along with "items" and "indexedItems" functions to support DiffUtil and animations when adding/removing items. the same as the ListAdapter with DiffUtil.

er...@gmail.com <er...@gmail.com> #3Feb 23, 2023 05:11PM

We are working on it, but nothing to share yet. Thanks

se...@google.com <se...@google.com> Feb 23, 2023 05:15PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #4Feb 28, 2023 01:16PM

Are we allowed to post potential workarounds on issue trackers? I created this small POC repo, definitely not a solution and probably not ideal in the long run but works for my use case and thought I'd share: https://github.com/RoudyK/AnimatedLazyColumn (Please delete my comment or let me know so I can delete it, in case I'm not allowed to post workarounds)

se...@google.com <se...@google.com> #5Feb 28, 2023 01:16PM

Marked as fixed.

I think there is not much point in coming up with workaround as this is expected to be one of the main features/supports for the DiffUtil (list diffing for adapters). Entire RecyclerView implementations depend on this.

na...@google.com <na...@google.com> #6Mar 8, 2023 07:51PM

Any update on LazyList Animations

Issue 270425759