M3 ModalBottomSheet ignores confirmValueChange [270425759]

Fixed

Bug

Status Update

No update yet.

Description

er...@gmail.com

created issue #1

Feb 22, 2023 09:39PM

Jetpack Compose version: 1.3.3, material3:1.1.0-alpha06
Jetpack Compose component used: material3 ModalBottomSheet

The callback for the ModalBottomSheet SheetState.confirmValueChange is never called before changing state, and looking at the source it seems like it's never invoked.

This prevents disabling Scrim touch-to-dismiss

Comments

se...@google.com <se...@google.com> #2Feb 23, 2023 04:19PM

Reassigned to se...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

er...@gmail.com <er...@gmail.com> #3Feb 23, 2023 05:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

se...@google.com <se...@google.com> Feb 23, 2023 05:15PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #4Feb 28, 2023 01:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 10e697083c409d189945cc57a19e45c3a6dc2e55
Author: José Figueroa Santos <serniebanders@google.com>
Date: Thu Feb 23 14:23:29 2023

[Material3][BottomSheet] Update scrim to confirm value change before tapping

RelNote: Add confirmValueChange check to scrim tap for ModalBottomSheet.
Test: Update confirmValueChange test to include scrim tap
Bug: 270425759

Change-Id: I2311a043ffbac63c4278fce9d0e73450fc808201

M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt

https://android-review.googlesource.com/2455849

se...@google.com <se...@google.com> #5Feb 28, 2023 01:16PM

Marked as fixed.

I believe this should land with alpha08

na...@google.com <na...@google.com> #6Mar 8, 2023 07:51PM