Navigation with Fragments does not correctly update BottomNavigationMenu [270447657]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Feb 22, 2023 11:41PM

The most recent version of Navigation (`2.6.0-alpha06`) caused a regression where if you attempt to restore a backstack with multiple entries using `BottomNavigation`, the menu icon is not updated correctly.

Comments

ap...@gmail.com <ap...@gmail.com> #2Feb 23, 2023 01:08AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 42d5037be3a80f5ff840eee1f0a74bfb8f287d66
Author: Ben Weiss <benweiss@google.com>
Date: Thu Dec 10 16:20:02 2020

Add factory functions for DynamicNavHostFragment

Bug: 175222619
Test: updateApi and cAT
RelNote: Add factory functions for DynamicNavHostFragment
Change-Id: Icd51523a8f3cc3f93fffc1796c6a270bc28eaede

M navigation/navigation-dynamic-features-fragment/api/current.txt
M navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-dynamic-features-fragment/api/restricted_current.txt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilderTest.kt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragmentTest.kt
M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java

https://android-review.googlesource.com/1523818

ap...@google.com <ap...@google.com> #3Mar 1, 2023 01:40AM

I couldn't seem to find the create method in my codebase on the latest Navigation release 2.3.5. Has this change been merged into latest release?

https://androidx.tech/artifacts/navigation/navigation-dynamic-features-fragment/2.3.5-source/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt.html

jb...@google.com <jb...@google.com> #4Mar 1, 2023 01:42AM

Marked as fixed.

This adds new APIs therefore will be available in Navigation 2.4.0-alpha01.

ap...@google.com <ap...@google.com> #5Mar 1, 2023 11:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit 96cee05bdb8f61a92e4be00a52b991cfc1ed2f4e
Author: Clara Fok <clarafok@google.com>
Date: Wed Mar 01 12:28:09 2023

Add FragmentNavigator test to assert entry destroyed

Add test to assert that NavBackStackEntry is destroyed after being restored upon recreation/configuration change.

Asserts that the fix on this bug also fixes

b/270610768

.

Test: ./gradlew navigation:navigation-fragment
Bug: 270447657
Change-Id: I8874d2dfaa17e560dd2f6d9da54e435494c187d2

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt

https://android-review.googlesource.com/2464422

na...@google.com <na...@google.com> #6Mar 8, 2023 07:51PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.6.0-alpha07

ap...@google.com <ap...@google.com> #7Mar 16, 2023 12:41AM

Project: platform/frameworks/support
Branch: androidx-main

commit 7cf55857f0db6bd1a1e1f95be7374ed5cf3eca58
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 15 16:59:50 2023

Fix system back after popUpTo

After you do a popUpTo inclusive while using Navigation with Fragments,
if you attempt to do a system back call, the Navigation back stack is
never updated.

The reason for this is that when fragment views are DESTROYED, we need
for the observer in the FragmentNavigator to update the state so we know
that the entry was already popped.

RelNote: "When using system back after doing a navigate with popUpTo,
the state of the NavController will pop to the correct entry."
Test: Added OnBackPressedTest
Bug: 270447657

Change-Id: I3a8ec072ba6d1655ab054cc081961825909088e6

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/OnBackPressedTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt

https://android-review.googlesource.com/2493203

pr...@google.com <pr...@google.com> #8Mar 22, 2023 08:21PM