Cannot generate baseline profile for bundle [270587281]

Fixed

Bug

Status Update

No update yet.

Description

mh...@google.com

created issue #1

Feb 23, 2023 07:54PM

Component used: not sure what this means but BaselineProfileRule from macrobenchmark library

Version used: latest nightly snapshot from androidx.dev (1.2.0-SNAPSHOT)

Devices/Android versions reproduced on: Android P on go/acid

The macrobenchmark library fails to get a profile when the apk under test is actually a bundle with multiple splits. We at chrome use bundles with multiple splits (actually most of our code lives in splits rather than in the base module). When I try to generate a profile I get this in the output of the instrumentation:

java.lang.IllegalStateException: Expected no stderr from profman --dump-classes-and-methods --profile-file=/data/misc/profiles/ref/org.chromium.chrome/primary.prof --apk=/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/base.apk
package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/split_cablev2_authenticator.apk
package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/split_chrome.apk, saw /storage/emulated/0/Android/media/org.chromium.chrome.startup.benchmark.tests/temporaryScript387305115831681219.tmp[2]: package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/split_cablev2_authenticator.apk: inaccessible or not found
/storage/emulated/0/Android/media/org.chromium.chrome.startup.benchmark.tests/temporaryScript387305115831681219.tmp[4]: package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/split_chrome.apk: inaccessible or not found

	at androidx.benchmark.Shell.executeScriptCaptureStdout$default(chromium-ChromeStartupBenchmark.apk-default-1:53)
	at androidx.benchmark.macro.BaselineProfilesKt.extractProfileRooted(chromium-ChromeStartupBenchmark.apk-default-1:100)
	at androidx.benchmark.macro.junit4.BaselineProfileRule.collectBaselineProfile(chromium-ChromeStartupBenchmark.apk-default-1:22)
	at org.chromium.chrome.browser.perf.StartupBenchmarkTest.testGenerateBaselineProfile(chromium-ChromeStartupBenchmark.apk-default-1:53)

The cause of this is this line here expects only a single path to return but for bundles, you get multiple ones (one for each split). eg:

generic_x86:/ # pm path org.chromium.chrome
package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/base.apk
package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/split_cablev2_authenticator.apk
package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/split_chrome.apk

The rest of the code in BaselineProfiles.kt also expects only the one profile. But there are usually multiple (one for each split).

generic_x86:/ # ls /data/misc/profiles/ref/org.chromium.chrome/                                                                      
cablev2_authenticator.split.prof chrome.split.prof primary.prof

The documentation for baseline profiles mentions both APKs and Bundles so I assume bundles should be supported?

Comments

mh...@google.com <mh...@google.com> #2Feb 23, 2023 08:05PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ra...@google.com <ra...@google.com> #3Feb 23, 2023 09:21PM

Yes, this is something that we should be able to support.

cc...@google.com <cc...@google.com> #4Feb 28, 2023 12:59AM

Accepted by cc...@google.com.

This issue affects both compilation on unrooted devices, and baseline profile extraction for rooted devices running API 32 or lower.

I have not tried it, but you may be able to workaround the crash in BaselineProfileRule by using a rooted API 33+ emulator/device and macrobenchmark 1.2.0-alpha06 or newer, since the new ART command we use on API 33+ to extract profiles operations on packages instead of APKs.

ap...@google.com <ap...@google.com> #5Feb 28, 2023 09:07PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit bf0289331e88399e38f5486200199bc857932e24
Author: Chris Craik <ccraik@google.com>
Date: Mon Feb 27 16:46:31 2023

MacrobenchmarkRule and BaselineProfileRule support for app bundles

Fixes: 270587281
Test: BaselineProfileRuleTest (manually installed target as bundle)
Test: CompilationModeTest (manually installed target as bundle, forcing reinstall compilation)
Relnote: "Fix crashes in MacrobenchmarkRule and BaselineProfileRule
when reinstalling or extracting profiles from an app bundle with
multiple APKs."

Installed macrobenchmark target with the following steps:

```
./gradlew benchmark:integ:macrobenchmark-target:bundleRelease
java -jar bundletool.jar build-apks --local-testing --bundle=../../out/androidx/benchmark/integration-tests/macrobenchmark-target/build/outputs/bundle/release/macrobenchmark-target-release.aab --output=out.apks --overwrite --ks=/path/to/androidx/frameworks/support/development/keystore/debug.keystore --connected-device --ks-key-alias=AndroidDebugKey --ks-pass=pass:android
java -jar bundletool.jar install-apks --apks=out.apks
```

And verified both codepaths using `pm path <package>` no longer crash.

Change-Id: I0d8c8a50daee8ef3951a5d0266b5767f65fad4e7

M benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/CompilationMode.kt

https://android-review.googlesource.com/2459548

na...@google.com <na...@google.com> #6Mar 8, 2023 07:51PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-common:1.2.0-alpha11
androidx.benchmark:benchmark-macro:1.2.0-alpha11

Issue 270587281