Cannot generate baseline profile for bundle [270587281]

Fixed

Bug

Status Update

No update yet.

Description

mh...@google.com

created issue #1

Feb 23, 2023 07:54PM

Component used: not sure what this means but BaselineProfileRule from macrobenchmark library

Version used: latest nightly snapshot from androidx.dev (1.2.0-SNAPSHOT)

Devices/Android versions reproduced on: Android P on go/acid

The macrobenchmark library fails to get a profile when the apk under test is actually a bundle with multiple splits. We at chrome use bundles with multiple splits (actually most of our code lives in splits rather than in the base module). When I try to generate a profile I get this in the output of the instrumentation:

java.lang.IllegalStateException: Expected no stderr from profman --dump-classes-and-methods --profile-file=/data/misc/profiles/ref/org.chromium.chrome/primary.prof --apk=/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/base.apk
package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/split_cablev2_authenticator.apk
package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/split_chrome.apk, saw /storage/emulated/0/Android/media/org.chromium.chrome.startup.benchmark.tests/temporaryScript387305115831681219.tmp[2]: package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/split_cablev2_authenticator.apk: inaccessible or not found
/storage/emulated/0/Android/media/org.chromium.chrome.startup.benchmark.tests/temporaryScript387305115831681219.tmp[4]: package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/split_chrome.apk: inaccessible or not found

	at androidx.benchmark.Shell.executeScriptCaptureStdout$default(chromium-ChromeStartupBenchmark.apk-default-1:53)
	at androidx.benchmark.macro.BaselineProfilesKt.extractProfileRooted(chromium-ChromeStartupBenchmark.apk-default-1:100)
	at androidx.benchmark.macro.junit4.BaselineProfileRule.collectBaselineProfile(chromium-ChromeStartupBenchmark.apk-default-1:22)
	at org.chromium.chrome.browser.perf.StartupBenchmarkTest.testGenerateBaselineProfile(chromium-ChromeStartupBenchmark.apk-default-1:53)

The cause of this is this line here expects only a single path to return but for bundles, you get multiple ones (one for each split). eg:

generic_x86:/ # pm path org.chromium.chrome
package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/base.apk
package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/split_cablev2_authenticator.apk
package:/data/app/org.chromium.chrome-1CGJyRx56jh5RwfbZL4cQA==/split_chrome.apk

The rest of the code in BaselineProfiles.kt also expects only the one profile. But there are usually multiple (one for each split).

generic_x86:/ # ls /data/misc/profiles/ref/org.chromium.chrome/                                                                      
cablev2_authenticator.split.prof chrome.split.prof primary.prof

The documentation for baseline profiles mentions both APKs and Bundles so I assume bundles should be supported?

Comments

mh...@google.com <mh...@google.com> #2Feb 23, 2023 08:05PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

ra...@google.com <ra...@google.com> #3Feb 23, 2023 09:21PM

yea i'll take it.

cc...@google.com <cc...@google.com> #4Feb 28, 2023 12:59AM

Accepted by cc...@google.com.

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

ap...@google.com <ap...@google.com> #5Feb 28, 2023 09:07PM

Marked as fixed.

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

na...@google.com <na...@google.com> #6Mar 8, 2023 07:51PM

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

Issue 270587281