Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
ma...@google.com <ma...@google.com>
ab...@google.com <ab...@google.com> #2
Yea this is fine to allow. Can we ask Maps currently how they implement this? Do they use our Search Bar component or overwrite with their own?
dp...@phunware.com <dp...@phunware.com> #3
Hi! Any updates on this?
ma...@google.com <ma...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 82ce78efb3b95a6351ff3dabee9c820105230610
Author: Max Alfonso-Ying <maxying@google.com>
Date: Tue May 16 21:28:55 2023
Add shadowElevation parameter to search bars.
Bug: b/271040353
Test: added screenshots
Relnote: "Search bar now supports shadows via the newly added
shadowElevation parameter."
Change-Id: Ia5369b93f692ff1289148eb13a0fd0c44af8ec4e
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/SearchBarScreenshotTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/SearchBar.kt
https://android-review.googlesource.com/2592366
Branch: androidx-main
commit 82ce78efb3b95a6351ff3dabee9c820105230610
Author: Max Alfonso-Ying <maxying@google.com>
Date: Tue May 16 21:28:55 2023
Add shadowElevation parameter to search bars.
Bug:
Test: added screenshots
Relnote: "Search bar now supports shadows via the newly added
shadowElevation parameter."
Change-Id: Ia5369b93f692ff1289148eb13a0fd0c44af8ec4e
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/SearchBarScreenshotTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/SearchBar.kt
pr...@google.com <pr...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.2.0-alpha03
androidx.compose.material3:material3-android:1.2.0-alpha03
Description
Jetpack Compose version: 1.1.0-alpha07 Jetpack Compose component used: Material3
As described in the Material3 Guidelines, shadow elevation should be used to separate components from patterned or busy backgrounds.
The SearchBar component already supports tonal elevation, but if we need to use it on a busy background (like over a map view, for example), that's not enough to protect the component and indicate separation.
The
Surface
component already supports ashadowElevation
parameter and some other components that useSurface
also already have that parameter that they pass down to the underlyingSurface
, like theListItem
component.Can we please do the same for the SearchBar component? Simply adding a
shadowElevation
parameter and passing it to theshadowElevation
of theSurface
is enough to fix this. I copied the SearchBar component and tested the change and it worked fine.Thanks.