[Material3] Add shadowElevation parameter to SearchBar [271040353]

Fixed

Feature Request

Status Update

No update yet.

Description

dp...@phunware.com

created issue #1

Mar 1, 2023 05:35AM

Jetpack Compose version: 1.1.0-alpha07 Jetpack Compose component used: Material3

As described in the Material3 Guidelines, shadow elevation should be used to separate components from patterned or busy backgrounds.

https://m3.material.io/styles/elevation/applying-elevation

When to use visible shadows

Protect elements

When a background is patterned or visually busy, 
the hairline style might not provide sufficient protection. 
In these cases, use elevation to separate and emphasize elements 
such as cards, chips, or buttons, as in the image below.

The SearchBar component already supports tonal elevation, but if we need to use it on a busy background (like over a map view, for example), that's not enough to protect the component and indicate separation.

The Surface component already supports a shadowElevation parameter and some other components that use Surface also already have that parameter that they pass down to the underlying Surface, like the ListItem component.

Can we please do the same for the SearchBar component? Simply adding a shadowElevation parameter and passing it to the shadowElevation of the Surface is enough to fix this. I copied the SearchBar component and tested the change and it worked fine.

Thanks.

Comments

ma...@google.com <ma...@google.com> Mar 2, 2023 04:34PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> Mar 2, 2023 05:42PM

Accepted by ma...@google.com.

ab...@google.com <ab...@google.com> #2Mar 8, 2023 11:16PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

dp...@phunware.com <dp...@phunware.com> #3May 10, 2023 10:01PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

ma...@google.com <ma...@google.com> May 31, 2023 03:08PM

Marked as fixed.

ap...@google.com <ap...@google.com> #4May 31, 2023 03:08PM

Project: platform/frameworks/support
Branch: androidx-main

commit 82ce78efb3b95a6351ff3dabee9c820105230610
Author: Max Alfonso-Ying <maxying@google.com>
Date: Tue May 16 21:28:55 2023

Add shadowElevation parameter to search bars.

Bug:

b/271040353

Test: added screenshots
Relnote: "Search bar now supports shadows via the newly added
shadowElevation parameter."
Change-Id: Ia5369b93f692ff1289148eb13a0fd0c44af8ec4e

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/SearchBarScreenshotTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/SearchBar.kt

https://android-review.googlesource.com/2592366

pr...@google.com <pr...@google.com> #5Jun 21, 2023 08:57PM