[BottomSheetState] Regression: Since the removal of the targetValue is not possible to know if a bottom sheet is expanding or collapsing [271169225]

Fixed

Bug

Status Update

No update yet.

Description

ro...@veeva.com

created issue #1

Mar 1, 2023 04:35PM

Jetpack Compose version: 1.4.0-beta02 Jetpack Compose component used: androidx.compose.material.BottomSheetState Android Studio Build: Android Studio Electric Eel | 2022.1.1 Patch 2 Kotlin version: 1.8.10

As per title, after the removal of the targetValue isn't possible to know if a bottom sheet is expanding or collapsing.

The use case on why this is needed is to change the alpha of an element depending on the current expanded progress of the bottom sheet itself.

The bottomSheetState.progress goes always from 0.0 to 1.0, no matter if is expanding or collapsing.

And checking the current value doesn't help, because it switches from Expanded to Collapsed remaining with the value of 1.0:

Expanded - 0.91185045
Expanded - 0.93893886
Expanded - 0.97347516
Expanded - 0.9933874
Expanded - 1.0
Collapsed - 1.0
Collapsed - 0.342198
Collapsed - 0.39998567
Collapsed - 0.48986524
Collapsed - 0.5680212
Collapsed - 0.6550029
Collapsed - 0.7393994
Collapsed - 0.83361727
Collapsed - 0.9114269
Collapsed - 1.0
Expanded - 1.0

Before it was possible to control the alpha of the element with this logic:

        val fraction = bottomSheetState.progress.fraction
        val targetValue = bottomSheetState.targetValue
        val currentValue = bottomSheetState.currentValue
        return when {
            currentValue == BottomSheetValue.Collapsed && targetValue == BottomSheetValue.Collapsed -> 0f
            currentValue == BottomSheetValue.Expanded && targetValue == BottomSheetValue.Expanded -> 1f
            currentValue == BottomSheetValue.Collapsed && targetValue == BottomSheetValue.Expanded -> fraction
            else -> 1 - fraction
        }

But now, without the target value, it is impossible because, once you fully expand or fully collapse the bottom sheet, the currentValue will change from Expanded to Collapse, but the progress will stay to 1.0.

Steps to Reproduce or Code Sample to Reproduce: 1.Add a bottom BottomSheetScaffold with a bottom sheet 2.Try to change the alpha of a component depending on the current expanded/collapsed state, so that the alpha should decrease when the bottom sheet shrink and increase when it expand.

Comments

ma...@google.com <ma...@google.com> Mar 1, 2023 05:40PM

Reassigned to jo...@google.com.

[Deleted User] <[Deleted User]> #2Mar 6, 2023 10:14AM

We recently landed stability improvements and bugfixes in aosp/2258262 and will stabilize ModalBottomSheetLayout following a few release cycles. We are still evaluating the future API of BottomSheetScaffold and are expecting it to stay experimental for a bit more while we migrate it to Swipeable V2.

jo...@google.com <jo...@google.com> #3Mar 13, 2023 02:50PM

@jossiwolf is this on track for 1.6 or moved out to 1.7?

ro...@veeva.com <ro...@veeva.com> #4Apr 12, 2023 11:02AM

Currently slated for 1.7

jo...@google.com <jo...@google.com> #5Apr 17, 2023 07:55AM

Bumping to P1 as it is been a long while since we need to land this.

[Deleted User] <[Deleted User]> #6May 15, 2023 04:39AM

Do we expect this to land by EOW? It's in the SLO chaselist now and very on fire.

jo...@google.com <jo...@google.com> #7May 16, 2023 02:33PM

Hi jossiwolf, is this part of alpha02?

ap...@google.com <ap...@google.com> #8May 24, 2023 10:57AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e299b64fa3574b44e745173f406bc3b49e1d47f7
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon Nov 27 19:34:32 2023

[M2] Stabilize ModalBottomSheetLayout

Relnote: Material (2) modal bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 266780235, 261409034
Test: Added modalBottomSheet_show_animatesToHalfExpandedFirstAndToExpandedAfter
Change-Id: Ic53f4fe7c7183569cb7322c8f56f571be5316be0

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetStateTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt

https://android-review.googlesource.com/2852687

pr...@google.com <pr...@google.com> #9Jun 21, 2023 08:57PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8cae2e36009d6c9c6905c4385e2db39100eff3ef
Author: Jossi Wolf <jossiwolf@google.com>
Date: Wed Nov 29 14:21:26 2023

[M2] Stabilize BottomSheetScaffold

Relnote: Material (2) standard bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 261409034
Test: Existing tests
Change-Id: I3c1a892338d183db35ecf3c023255682b4e785bd

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt

https://android-review.googlesource.com/2852688

ju...@google.com <ju...@google.com> #10Jun 28, 2023 11:52PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.7.0-alpha03
androidx.compose.material:material-android:1.7.0-alpha03
androidx.compose.material:material-desktop:1.7.0-alpha03

na...@google.com <na...@google.com> #11Jul 26, 2023 05:21PM