[BottomSheetState] Regression: Since the removal of the targetValue is not possible to know if a bottom sheet is expanding or collapsing [271169225]

Fixed

Bug

Status Update

No update yet.

Description

ro...@veeva.com

created issue #1

Mar 1, 2023 04:35PM

Jetpack Compose version: 1.4.0-beta02 Jetpack Compose component used: androidx.compose.material.BottomSheetState Android Studio Build: Android Studio Electric Eel | 2022.1.1 Patch 2 Kotlin version: 1.8.10

As per title, after the removal of the targetValue isn't possible to know if a bottom sheet is expanding or collapsing.

The use case on why this is needed is to change the alpha of an element depending on the current expanded progress of the bottom sheet itself.

The bottomSheetState.progress goes always from 0.0 to 1.0, no matter if is expanding or collapsing.

And checking the current value doesn't help, because it switches from Expanded to Collapsed remaining with the value of 1.0:

Expanded - 0.91185045
Expanded - 0.93893886
Expanded - 0.97347516
Expanded - 0.9933874
Expanded - 1.0
Collapsed - 1.0
Collapsed - 0.342198
Collapsed - 0.39998567
Collapsed - 0.48986524
Collapsed - 0.5680212
Collapsed - 0.6550029
Collapsed - 0.7393994
Collapsed - 0.83361727
Collapsed - 0.9114269
Collapsed - 1.0
Expanded - 1.0

Before it was possible to control the alpha of the element with this logic:

        val fraction = bottomSheetState.progress.fraction
        val targetValue = bottomSheetState.targetValue
        val currentValue = bottomSheetState.currentValue
        return when {
            currentValue == BottomSheetValue.Collapsed && targetValue == BottomSheetValue.Collapsed -> 0f
            currentValue == BottomSheetValue.Expanded && targetValue == BottomSheetValue.Expanded -> 1f
            currentValue == BottomSheetValue.Collapsed && targetValue == BottomSheetValue.Expanded -> fraction
            else -> 1 - fraction
        }

But now, without the target value, it is impossible because, once you fully expand or fully collapse the bottom sheet, the currentValue will change from Expanded to Collapse, but the progress will stay to 1.0.

Steps to Reproduce or Code Sample to Reproduce: 1.Add a bottom BottomSheetScaffold with a bottom sheet 2.Try to change the alpha of a component depending on the current expanded/collapsed state, so that the alpha should decrease when the bottom sheet shrink and increase when it expand.

Comments

ma...@google.com <ma...@google.com> Mar 1, 2023 05:40PM

Reassigned to jo...@google.com.

[Deleted User] <[Deleted User]> #2Mar 6, 2023 10:14AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

jo...@google.com <jo...@google.com> #3Mar 13, 2023 02:50PM

Hi, thank you. We are going to re-introduce the targetValue API. Please see b/270066861 for additional context on the progress API and this overall UX pattern.

ro...@veeva.com <ro...@veeva.com> #4Apr 12, 2023 11:02AM

Hi, any news about this issue? In which release it will be fixed?

jo...@google.com <jo...@google.com> #5Apr 17, 2023 07:55AM

Hello, no news to share yet. We are currently focusing on a Foundation API for anchored draggable components and will come back to this after.

[Deleted User] <[Deleted User]> #6May 15, 2023 04:39AM

Hello, is there a release version with this issue fixed?

jo...@google.com <jo...@google.com> #7May 16, 2023 02:33PM

Hi #6, we will update this issue once the change has been merged and when it has been released.

ap...@google.com <ap...@google.com> #8May 24, 2023 10:57AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 762bbc3cea2a9bcfb6fae34e71c6bb8da917f43c
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon May 15 11:50:25 2023

[M2] Expose AnchoredDraggable components' progress

Fixes: 271169225
Fixes: 276375124
Fixes: 276776071
Fixes: 270066861
Relnote: BottomSheetState, ModalBottomSheetState and BottomDrawerState now expose a progress property indicating the progress between the current (settled) anchor and the closest anchor in the swipe direction.
Test: AnchoredDraggable tests

Change-Id: I1b31727b4f56df890e336bea9f4de526733aaacc

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AnchoredDraggable.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt

https://android-review.googlesource.com/2588925

pr...@google.com <pr...@google.com> #9Jun 21, 2023 08:57PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.6.0-alpha01
androidx.compose.material:material-android:1.6.0-alpha01

ju...@google.com <ju...@google.com> #10Jun 28, 2023 11:52PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.5.0-beta03
androidx.compose.material:material-android:1.5.0-beta03

na...@google.com <na...@google.com> #11Jul 26, 2023 05:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.wear.compose:compose-material-core:1.2.0-rc01
androidx.wear.compose:compose-ui-tooling:1.2.0-rc01

Issue 271169225

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> Mar 1, 2023 05:40PM

[Deleted User] <[Deleted User]> #2Mar 6, 2023 10:14AM

jo...@google.com <jo...@google.com> #3Mar 13, 2023 02:50PM

ro...@veeva.com <ro...@veeva.com> #4Apr 12, 2023 11:02AM

jo...@google.com <jo...@google.com> #5Apr 17, 2023 07:55AM

[Deleted User] <[Deleted User]> #6May 15, 2023 04:39AM

jo...@google.com <jo...@google.com> #7May 16, 2023 02:33PM

ap...@google.com <ap...@google.com> #8May 24, 2023 10:57AM

pr...@google.com <pr...@google.com> #9Jun 21, 2023 08:57PM

ju...@google.com <ju...@google.com> #10Jun 28, 2023 11:52PM

na...@google.com <na...@google.com> #11Jul 26, 2023 05:21PM

Add comment

Issue metadata