android.injected.testOnly=false does not work [271424910]

Fixed

Bug

Status Update

No update yet.

Description

my...@gmail.com

created issue #1

Mar 3, 2023 05:53AM

DESCRIBE THE ISSUE IN DETAIL: Setting android.injected.testOnly=false does not prevent the android:testOnly="true" from being added.

STEPS TO REPRODUCE:

Clone https://github.com/Mygod/VPNHotspot/tree/v2.16.0
Compile the app and see android:testOnly="true"
Add android.injected.testOnly=false to root gradle.properties
Recompile the app and see android:testOnly="true"

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: Flamingo beta 4 Version of Gradle Plugin: See attached code repo Version of Gradle: See attached code repo Version of Java: 17 OS: Ubuntu

Comments

am...@google.com <am...@google.com> Mar 3, 2023 03:33PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> #2Mar 6, 2023 05:08PM

Reassigned to je...@google.com.

Here is the stacktrace:

java.lang.VerifyError: Verifier rejected class WN: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent) failed to verify: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent): [0x4]  can't resolve returned type 'Reference: android.app.Notification$Style' or 'Unresolved Reference: android.app.Notification$CallStyle' (declaration of 'WN' appears in base.apk!classes4.dex)
	at Tj.<init>(SourceFile:17)
	at kT1.<init>(SourceFile:23)
	at aL1.<init>(SourceFile:293)
	at bh4.get(SourceFile:1606)
	at cL1.a(SourceFile:29)
	at cL1.e(SourceFile:17)
	at s1i.getValue(Unknown Source:17)
	at dL1.a(SourceFile:11)
	at RQ1.b(Unknown Source:2)
	at EQ1.execute(SourceFile:15)
	at lU1.handleMessage(SourceFile:18)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at N52.dispatchMessage(SourceFile:7)
	at android.os.Looper.loop(Looper.java:237)
	at android.os.HandlerThread.run(HandlerThread.java:67)

Unfortunately, I can't share the dex2oat logs for this as I'm running into this problem on Android 11 emulator and I don't have a rooted Android 11 device on-hand.

hm...@google.com <hm...@google.com> #3Mar 6, 2023 06:06PM

Thanks for the report. Can you share the APK failing and give suggestions to force the error such that I can see the entire logcat on device. The outline is looking correct so I believe the error is someplace else and logcat will show that.

Message last modified on Mar 6, 2023 06:07PM

my...@gmail.com <my...@gmail.com> #4Mar 6, 2023 08:29PM

I shared the APK and instructions to reproduce over email. Let me know if you have any trouble reproing the crash.

hm...@google.com <hm...@google.com> #5Mar 7, 2023 09:37AM

Thank you for the dump and information. Turns out that behavior of the verifier changed on Android 11 and 12 but was reverted again. I am working on a fix that should be easy to merge to the 4.0 branch.

Note that the verification error is actually also easy to create by manual outlining, but our pattern just emphasize it.

my...@gmail.com <my...@gmail.com> #6Mar 7, 2023 03:26PM

Project: r8
Branch: main

commit b7b22190797c9b74218fb1d2fdfb497a9be9fb3b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 13:03:38 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

Change-Id: I2479d669217d90f057fa248fcea0f0f27faf91a6

M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
M src/main/java/com/android/tools/r8/ir/code/Return.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java
M src/main/java/com/android/tools/r8/ir/desugar/apimodel/ApiInvokeOutlinerDesugaring.java
A src/main/java/com/android/tools/r8/ir/optimize/RemoveVerificationErrorForUnknownReturnedValues.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineHorizontalMergingTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineInstanceInitializerTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77221

hm...@google.com <hm...@google.com> #7Mar 7, 2023 06:05PM

Project: r8
Branch: main

commit 88dd6ed0006725301bcbe88942e474569c9aa1b1
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 12:43:54 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

Change-Id: I5684a12bf42422bb96122422e063ffd0503fb5e5

M src/main/java/com/android/tools/r8/utils/AndroidApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77180

my...@gmail.com <my...@gmail.com> #8Mar 7, 2023 06:41PM

thanks for the fix. if this can be backported to 4.0 that would be great

Message last modified on Mar 7, 2023 06:44PM

my...@gmail.com <my...@gmail.com> #9Mar 7, 2023 06:51PM

Project: r8
Branch: 8.0

commit e1cdcb66b3a225076a41b646a2684d150a594693
Author: Rico Wind <ricow@google.com>
Date: Tue Mar 21 18:58:29 2023

Version 8.0.39

Bug:

b/272725341

Change-Id: Iad8a15631027cf587871f6c8df12a8b4c601296c

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77428

hm...@google.com <hm...@google.com> #10Mar 8, 2023 10:37AM

Accepted by hm...@google.com.

Project: r8
Branch: 8.0

commit 7248df9f87378eda019093887585afba9631a669
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Mar 21 13:59:20 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

https://r8-review.googlesource.com/77425

hm...@google.com <hm...@google.com> #11Mar 8, 2023 05:14PM

Marked as fixed.

Project: r8
Branch: 8.0

commit 4c0694de75503094bb84d6e28fd091453b172e2e
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Mar 21 13:59:12 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

https://r8-review.googlesource.com/77424

Message last modified on Mar 8, 2023 05:15PM

my...@gmail.com <my...@gmail.com> #12Mar 8, 2023 08:32PM

Project: r8
Branch: 4.0

commit 4fe0ece4d3da01068bf0b63cd7a5f37d47fa6244
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:30 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

https://r8-review.googlesource.com/77496

my...@gmail.com <my...@gmail.com> #13Mar 8, 2023 08:33PM

Project: r8
Branch: 4.0

commit 1e7c88c78ac0636eae649e132b862306ea416d48
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:43 2023

Version 4.0.58

Bug:

b/272725341

Change-Id: If899ee42bdf757985546807d785639e98b3360e6

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77494

my...@gmail.com <my...@gmail.com> #14Mar 8, 2023 09:28PM

Project: r8
Branch: 4.0

commit b367460c6cab514f9c8c974f2a48e7ed862610de
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:37 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

https://r8-review.googlesource.com/77492

my...@gmail.com <my...@gmail.com> #15Mar 8, 2023 09:32PM

I've backported the fix to version 4.0.58. Could you take that version for a spin to see if that solves the issues?

hm...@google.com <hm...@google.com> #16Mar 9, 2023 10:08AM

I verified the fix works. Thanks!

my...@gmail.com <my...@gmail.com> #17Mar 9, 2023 05:36PM

Thanks for reporting back and your help with this issue.

hm...@google.com <hm...@google.com> #18Mar 9, 2023 10:06PM

deleted

my...@gmail.com <my...@gmail.com> #19Mar 9, 2023 10:31PM

ชอบ

my...@gmail.com <my...@gmail.com> #20Mar 9, 2023 10:53PM

ชอบเรียนรู้

su...@gmail.com <su...@gmail.com> #21Mar 20, 2023 06:52AM

Comment has been deleted.

Message last modified on Mar 22, 2023 09:31AM

ja...@gmail.com <ja...@gmail.com> #22Mar 30, 2023 08:52PM

Ab date

la...@gmail.com <la...@gmail.com> #23Aug 28, 2023 06:18AM

Add android.injected.testOnly=false to root gradle.properties fixed my issue.

Issue 271424910

Description

Issue summary

Comments

am...@google.com <am...@google.com> Mar 3, 2023 03:33PM

je...@google.com <je...@google.com> #2Mar 6, 2023 05:08PM

hm...@google.com <hm...@google.com> #3Mar 6, 2023 06:06PM

my...@gmail.com <my...@gmail.com> #4Mar 6, 2023 08:29PM

hm...@google.com <hm...@google.com> #5Mar 7, 2023 09:37AM

my...@gmail.com <my...@gmail.com> #6Mar 7, 2023 03:26PM

hm...@google.com <hm...@google.com> #7Mar 7, 2023 06:05PM

my...@gmail.com <my...@gmail.com> #8Mar 7, 2023 06:41PM

my...@gmail.com <my...@gmail.com> #9Mar 7, 2023 06:51PM

hm...@google.com <hm...@google.com> #10Mar 8, 2023 10:37AM

hm...@google.com <hm...@google.com> #11Mar 8, 2023 05:14PM

my...@gmail.com <my...@gmail.com> #12Mar 8, 2023 08:32PM

my...@gmail.com <my...@gmail.com> #13Mar 8, 2023 08:33PM

my...@gmail.com <my...@gmail.com> #14Mar 8, 2023 09:28PM

my...@gmail.com <my...@gmail.com> #15Mar 8, 2023 09:32PM

hm...@google.com <hm...@google.com> #16Mar 9, 2023 10:08AM

my...@gmail.com <my...@gmail.com> #17Mar 9, 2023 05:36PM

hm...@google.com <hm...@google.com> #18Mar 9, 2023 10:06PM

my...@gmail.com <my...@gmail.com> #19Mar 9, 2023 10:31PM

my...@gmail.com <my...@gmail.com> #20Mar 9, 2023 10:53PM

su...@gmail.com <su...@gmail.com> #21Mar 20, 2023 06:52AM

ja...@gmail.com <ja...@gmail.com> #22Mar 30, 2023 08:52PM

la...@gmail.com <la...@gmail.com> #23Aug 28, 2023 06:18AM

Add comment

Issue metadata