Fixed
Status Update
Comments
au...@google.com <au...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
js...@google.com <js...@google.com> #3
au...@google.com <au...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
js...@google.com <js...@google.com>
ap...@google.com <ap...@google.com> #5
Project: platform/tools/metalava
Branch: metalava-main
commit ac6b7a3779511b5be53c4f8dfbdfcdf1508764e6
Author: Jinseong Jeon <jsjeon@google.com>
Date: Thu Mar 02 23:37:39 2023
Propagate deprecation of containing class to property
...in the same way method/field are deprecated
Bug: 271441831
Test: unit test added
Change-Id: I899b80a484866a44be9aa244d00552ebce148335
M src/main/java/com/android/tools/metalava/ApiAnalyzer.kt
M src/test/java/com/android/tools/metalava/ApiFileTest.kt
https://android-review.googlesource.com/2468803
Branch: metalava-main
commit ac6b7a3779511b5be53c4f8dfbdfcdf1508764e6
Author: Jinseong Jeon <jsjeon@google.com>
Date: Thu Mar 02 23:37:39 2023
Propagate deprecation of containing class to property
...in the same way method/field are deprecated
Bug: 271441831
Test: unit test added
Change-Id: I899b80a484866a44be9aa244d00552ebce148335
M src/main/java/com/android/tools/metalava/ApiAnalyzer.kt
M src/test/java/com/android/tools/metalava/ApiFileTest.kt
au...@google.com <au...@google.com>
ap...@google.com <ap...@google.com> #6
Project: platform/prebuilts/androidx/external
Branch: androidx-main
commit b712ab052930d4900a7f060d67bbd3cee2933970
Author: Jinseong Jeon <jsjeon@google.com>
Date: Sun Mar 05 22:51:50 2023
Update Metalava for build ID 9692962
./development/importMaven/importMaven.sh \
--metalava-build-id 9692962 \
--redownload com.android.tools.metalava:metalava:1.0.0-alpha07
Bug: 271441831
Bug: 271662790
Change-Id: Ide5946ed2a6b4248ffe5e822c760ed0b05034afd
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.jar
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.jar.md5
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.jar.sha1
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.module
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.module.md5
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.module.sha1
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.pom
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.pom.md5
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.pom.sha1
https://android-review.googlesource.com/2471011
Branch: androidx-main
commit b712ab052930d4900a7f060d67bbd3cee2933970
Author: Jinseong Jeon <jsjeon@google.com>
Date: Sun Mar 05 22:51:50 2023
Update Metalava for build ID 9692962
./development/importMaven/importMaven.sh \
--metalava-build-id 9692962 \
--redownload com.android.tools.metalava:metalava:1.0.0-alpha07
Bug: 271441831
Bug: 271662790
Change-Id: Ide5946ed2a6b4248ffe5e822c760ed0b05034afd
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.jar
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.jar.md5
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.jar.sha1
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.module
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.module.md5
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.module.sha1
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.pom
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.pom.md5
M com/android/tools/metalava/metalava/1.0.0-alpha07/metalava-1.0.0-alpha07.pom.sha1
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 5d6108703fa3db420dde7b7ee805ca4172ed44fa
Author: Jinseong Jeon <jsjeon@google.com>
Date: Sun Mar 05 23:03:10 2023
Update current API signature after Metalava update
Relnote: propagation of @Deprecated class to property
Bug: 271441831
Test: ./gradlew updateApi
Change-Id: I882d15d1d0d17f2227262e682d05d9dc7d082e8a
M annotation/annotation-experimental/api/current.txt
M annotation/annotation-experimental/api/public_plus_experimental_current.txt
M annotation/annotation-experimental/api/restricted_current.txt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M paging/paging-common/api/current.txt
M paging/paging-common/api/public_plus_experimental_current.txt
M paging/paging-common/api/restricted_current.txt
M paging/paging-runtime/api/current.txt
M paging/paging-runtime/api/public_plus_experimental_current.txt
M paging/paging-runtime/api/restricted_current.txt
M wear/compose/compose-material/api/current.txt
M wear/compose/compose-material/api/public_plus_experimental_current.txt
M wear/compose/compose-material/api/restricted_current.txt
M wear/watchface/watchface-client/api/current.txt
M wear/watchface/watchface-client/api/public_plus_experimental_current.txt
M wear/watchface/watchface-client/api/restricted_current.txt
M wear/watchface/watchface/api/current.txt
M wear/watchface/watchface/api/public_plus_experimental_current.txt
M wear/watchface/watchface/api/restricted_current.txt
https://android-review.googlesource.com/2469886
Branch: androidx-main
commit 5d6108703fa3db420dde7b7ee805ca4172ed44fa
Author: Jinseong Jeon <jsjeon@google.com>
Date: Sun Mar 05 23:03:10 2023
Update current API signature after Metalava update
Relnote: propagation of @Deprecated class to property
Bug: 271441831
Test: ./gradlew updateApi
Change-Id: I882d15d1d0d17f2227262e682d05d9dc7d082e8a
M annotation/annotation-experimental/api/current.txt
M annotation/annotation-experimental/api/public_plus_experimental_current.txt
M annotation/annotation-experimental/api/restricted_current.txt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M paging/paging-common/api/current.txt
M paging/paging-common/api/public_plus_experimental_current.txt
M paging/paging-common/api/restricted_current.txt
M paging/paging-runtime/api/current.txt
M paging/paging-runtime/api/public_plus_experimental_current.txt
M paging/paging-runtime/api/restricted_current.txt
M wear/compose/compose-material/api/current.txt
M wear/compose/compose-material/api/public_plus_experimental_current.txt
M wear/compose/compose-material/api/restricted_current.txt
M wear/watchface/watchface-client/api/current.txt
M wear/watchface/watchface-client/api/public_plus_experimental_current.txt
M wear/watchface/watchface-client/api/restricted_current.txt
M wear/watchface/watchface/api/current.txt
M wear/watchface/watchface/api/public_plus_experimental_current.txt
M wear/watchface/watchface/api/restricted_current.txt
pr...@google.com <pr...@google.com> #8
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.compose:compose-material:1.2.0-alpha07
pr...@google.com <pr...@google.com> #9
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.watchface:watchface:1.2.0-alpha08
androidx.wear.watchface:watchface-client:1.2.0-alpha08
Description
The getters and setters are marked @Deprecated properly, but the property itself in Metalava’s output is not.
If you have any clarifying questions or feedback, please reassign this issue back toandroid-api-council@google.com for a response.
Android API Council has been reviewing newly added APIs, and these questions/requests came up during a review of APIs associated with a Buganizer issue for which you are the assignee. To learn more about the API review process, including best practices for making API changes, visithttp://go/android-api-bugs .