Assigned
Status Update
Comments
kh...@microsoft.corp-partner.google.com <kh...@microsoft.corp-partner.google.com> #2
After some googling I found https://github.com/android/camera-samples/blob/master/CameraXBasic/app/src/main/java/com/android/example/cameraxbasic/utils/AutoFitPreviewBuilder.kt which does what I want. Would it be possible to fold this into the main library or at least make it configurable without the need for that class?
au...@google.com <au...@google.com> #3
Hi Charcoal,
Are we getting a crop mode here? Thanks!
Are we getting a crop mode here? Thanks!
jo...@google.com <jo...@google.com> #4
Hello,
Thanks for raising this up. May we know did you set aspect ratio or resolution for Preview use case? And could you also attach the captured image file?
Thanks for raising this up. May we know did you set aspect ratio or resolution for Preview use case? And could you also attach the captured image file?
kh...@microsoft.corp-partner.google.com <kh...@microsoft.corp-partner.google.com> #5
The captured image file is part of the image file that I've already attached (the right part).
I did not set anything on the Preview use case other than the lens facing.
```
val cameraPreview = Preview(Builder()
.setLensFacing(CameraX.LensFacing.BACK)
.build())
cameraPreview.setOnPreviewOutputUpdateListener {
// Every time the viewfinder is updated, recompute the layout. By removing and re-adding it.
val parent = parent as ViewGroup
parent.removeView(this)
parent.addView(this, 0)
surfaceTexture = it.surfaceTexture
updateTransform()
}
CameraX.bindToLifecycle(lifecycleOwner, cameraPreview, *useCase)
```
I did not set anything on the Preview use case other than the lens facing.
```
val cameraPreview = Preview(Builder()
.setLensFacing(CameraX.LensFacing.BACK)
.build())
cameraPreview.setOnPreviewOutputUpdateListener {
// Every time the viewfinder is updated, recompute the layout. By removing and re-adding it.
val parent = parent as ViewGroup
parent.removeView(this)
parent.addView(this, 0)
surfaceTexture = it.surfaceTexture
updateTransform()
}
CameraX.bindToLifecycle(lifecycleOwner, cameraPreview, *useCase)
```
Description
Metalava version: 1.0.0-alpha06 Metalava-gradle version: 0.3.2 Kotlin version: 1.8.10
We are using Metalava through metalava-gradle over in Accompanist and recently updated to 1.0.0-alpha06, although I am not sure from which version. It seems to fail on this symbol, but only if its visibility is https://github.com/google/accompanist/pull/1500/files#diff-0f6208aeeaf8b68be66365303ea42327ff5af16014374f75a47cead9968009d2R104
private
:It works fine if the visibility is
internal
. Unfortunately, I have not had time to create an isolated repro yet.Here's the full commit:https://github.com/google/accompanist/pull/1500/commits/4877c4e579895937e4609993ba9f2d6b59e7eb1a
Screenshot of the stack trace attached, I will add it as plain text later too.