IssueTracker

While doing some other work in ReplaceStringQuickFix I was able to induce the following exception during intention preview:

com.intellij.util.IncorrectOperationException: Must not change PSI outside command or undo-transparent action. See com.intellij.openapi.command.WriteCommandAction or com.intellij.openapi.command.CommandProcessor
    ...
    at com.intellij.psi.impl.source.codeStyle.CodeStyleManagerImpl.reformatRange(CodeStyleManagerImpl.java:97)
    at com.android.tools.idea.lint.common.ReplaceStringQuickFix.apply(ReplaceStringQuickFix.java:322)
    at com.intellij.codeInsight.intention.IntentionAction.generatePreview(IntentionAction.java:145)
    ...
    at com.intellij.codeInsight.intention.impl.preview.IntentionPreviewComputable.invokePreview(IntentionPreviewComputable.kt:144)
    at com.intellij.codeInsight.intention.impl.preview.IntentionPreviewComputable.generatePreview(IntentionPreviewComputable.kt:103)

I think part of the problem is this line in ReplaceStringQuickFix:

if (myRange != null) {
  file = myRange.getContainingFile();

That line has the effect of changing the PsiFile back to a physical file (replacing the non-physical file synthesized by the intention preview code). The line was originally added to support applying Lint fixes to a different file than the one being edited (ag/12351963). Probably we can disable intention preview in this case.