Canceling registration modal throws ConstraintError [271863184]

Fixed

Bug

Status Update

No update yet.

Description

va...@shopify.com

created issue #1

Mar 7, 2023 12:04AM

Component used: Credentials

Version used: 1.0.0-alpha03

Devices/Android versions reproduced on: Huawei P30 Pro (VOG-L29)

I have multiple Google accounts on my phone. After triggering the passkey registration modal, I pressed the "Cancel" button and I got a CreatePublicKeyCredentialDomException with ConstraintError instead of the expected CreateCredentialCancellationException

Here are some logs (PasskeyUtils is from my application):

03-06 18:59:09.005 19307 19307 I Fido    : [AuthenticateChimeraActivity] FIDO2 operation is called from com.shopify.arrive.debug [CONTEXT service_id=287 ]
03-06 18:59:09.007 19307 19307 I Fido    : [AuthenticateViewModel] Determining the attachment [CONTEXT service_id=287 ]
03-06 18:59:09.017 19307 19307 I Fido    : [AuthenticateChimeraActivity] onAttachmentUpdate [CONTEXT service_id=287 ]
03-06 18:59:09.018 19307 19385 I Fido    : [AuthenticateViewModel] StrongBox not needed. [CONTEXT service_id=287 ]
03-06 18:59:09.020 19307 19307 I Fido    : [AuthenticateChimeraActivity] Using default UserVerifier. [CONTEXT service_id=287 ]
03-06 18:59:09.023 19307 19307 I Fido    : [StringStoreKeyHandleCache] initU2fDeviceCache
03-06 18:59:09.023 19307 19307 I Fido    : [FidoApiImpl] updateTransaction is called for resume
03-06 18:59:09.099  1508  5553 I ActivityManager: Process com.huawei.skytone (pid 25789) has died: svcb SVC
03-06 18:59:09.099  1508  5553 W ActivityManager: Scheduling restart of crashed service com.huawei.skytone/com.huawei.android.vsim.service.VSimService in 1000ms
03-06 18:59:09.248 19307 19384 I Fido    : [RegistrationRequestHandler] Registering key via credential store.
03-06 18:59:09.304 19307 19307 I Fido    : [PasskeysCreationFragment] PasskeysCreationFragment is shown [CONTEXT service_id=287 ]
03-06 18:59:10.897 19307 19384 I Fido    : [RequestController] Timeout Runnable is removed, and timer is stopped.
03-06 18:59:10.901 19307 19384 I Fido    : [RequestController] Timeout Runnable is removed, and timer is stopped.
03-06 18:59:10.915 19307 19307 I Fido    : [FidoApiImpl] updateTransaction is called for pause
03-06 18:59:10.915 19307 19307 E Fido    : [FidoApiImpl] pauseSecurityKeyRequestController should not be called when SecurityKeyRequestController is null.
03-06 18:59:10.957 31580 31580 D PasskeyUtils: error:androidx.credentials.exceptions.publickeycredential.CreatePublicKeyCredentialDomException: Unable to get sync account.
03-06 18:59:10.957 31580 31580 D PasskeyUtils: domError:androidx.credentials.exceptions.domerrors.ConstraintError@8d8d7a9
03-06 18:59:10.979 19307 19307 I Fido    : [FidoApiImpl] updateTransaction is called for stop
03-06 18:59:10.979 19307 19307 E Fido    : [FidoApiImpl] finishSecurityKeyRequestController should not be called when SecurityKeyRequestController is null.

Comments

he...@google.com <he...@google.com> #2Mar 7, 2023 12:43AM

Reassigned to he...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Mar 7, 2023 05:07AM

Project: platform/frameworks/support
Branch: androidx-main

commit 30bc433be253e025de208514abf083c9c18e6fba
Author: Helen Qin <helenqin@google.com>
Date: Tue Mar 07 02:46:46 2023

Properly report the user cancellation error.

For passkey registration flow, user cancellation was improperly reported
as a ConstraintError. Now it should report
CreateCredentialCancellationException.

Bug: 271863184
Test: unit tested and locally verified.
Change-Id: I9ff3448a98cd8df945b2589f0b8ab64d636d2b09

M credentials/credentials-play-services-auth/src/main/java/androidx/credentials/playservices/controllers/CreatePublicKeyCredential/PublicKeyCredentialControllerUtility.kt

https://android-review.googlesource.com/2472961

he...@google.com <he...@google.com> #4Mar 7, 2023 07:37PM

Marked as fixed.

Hey!

The fix is complete and is on track to go into the next release (ETA March 22nd).

In the meantime, to try this out you can use a snapshot SDK from https://androidx.dev/. Any buildId >= 9700081 works. Here's an example of using the 9700081 snapshot:

Step 1: Add the following maven url line to your build.gradle file.

allprojects {
    repositories {
        google()
        jcenter()
        maven { url 'https://androidx.dev/snapshots/builds/9700081/artifacts/repository' }
    }
}

Step 2: Depend on the snapshot version artifact:

dependencies {
    def work_version = '1.0.0-SNAPSHOT'
    implementation "androidx.credentials:credentials-play-services-auth:$work_version"
    ...
}

pr...@google.com <pr...@google.com> #5Mar 22, 2023 08:23PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.credentials:credentials-play-services-auth:1.0.0-alpha05

sh...@gmail.com <sh...@gmail.com> #6Mar 23, 2023 07:52AM

I'm thinking that the issue still exists in 1.0.0-alpha05. FYI, I have a single Google account on the device.
The same error 'CreatePublicKeyCredentialDomException' is thrown with weird error message (errorMessage) - "Unable to get sync account."

va...@shopify.com <va...@shopify.com> #7Mar 25, 2023 12:57AM

I also confirm that the issue still exists in 1.0.0-alpha05

va...@shopify.com <va...@shopify.com> #8Apr 4, 2023 05:20PM

I think the error type changed from ConstraintError to NotAllowedError for alpha05, but still not CreateCredentialCancellationException as expected.

he...@google.com <he...@google.com> #9Apr 4, 2023 09:26PM

It's possible that ConstraintError is thrown once the passkey flow is started. This is according to the webauthn spec:

"If the user does not consent, return an error code equivalent to "NotAllowedError" and terminate the operation."

"If the user exercises a user agent user-interface option to cancel the process" ... "Throw a "NotAllowedError" DOMException."

Therefore, for a passkey request, you should be ready to handle both the CancellationException and the PublicKeyCredentialException(ConstraintError) as a signal for user cancellation.

va...@shopify.com <va...@shopify.com> #10Apr 4, 2023 10:01PM

Therefore, for a passkey request, you should be ready to handle both the CancellationException and the PublicKeyCredentialException(ConstraintError) as a signal for user cancellation.

You mean NotAllowedError?

he...@google.com <he...@google.com> #11Apr 4, 2023 10:02PM

Oops good catch. Yes by ConstraintError I meant NotAllowedError