Focus in route A is not restored upon going to route B and returning back to A [272302679]

Fixed

Bug

Status Update

No update yet.

Description

ni...@gmail.com

created issue #1

Mar 9, 2023 02:21PM

When we go from one route (A) to another (B) and then
Steps to reduce:
- Go from one route to another, while having an element focused
- Go back to the initial route
Actual behaviour - the focus is lost
Expected behaviour - the focus should be present

TvLazyRow was used as a demonstration, but the same bug is reproduced while using other components.

NB: The expected behaviour is present in components of Leanback library.

Additional notes on behaviour - If you use a sample project I attach you can observe, that position in the list is retained correctly, but the focus is lost. When you try to press LEFT/RIGHT button, the focus will be moved to a wrong item.
Example: Select element 2, press Enter, go back, press left -> the element 4 is selected.
Example: Select element 2, press Enter, go back, press right -> the element 1 is selected
Example: Select element 2, press Enter, go back, press Enter -> the element 1 is selected and navigation is triggered.

The issue is not device/android version specific.

While it is possible to implement saving/restoring focus on your own, it would be nice to have this this as an out the box feature, since custom solution complexity can significantly increase with complexity of a screen

deleted

Restricted

0 B

deleted

Restricted

0 B

Comments

ra...@google.com <ra...@google.com> Mar 10, 2023 06:13AM

Assigned to vi...@google.com.

my...@globallogic.com <my...@globallogic.com> #2May 18, 2023 02:22PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

Message last modified on May 18, 2023 02:23PM

vi...@google.com <vi...@google.com> #3May 18, 2023 02:25PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

ap...@google.com <ap...@google.com> #4Jun 2, 2023 11:25PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ma...@gmail.com <ma...@gmail.com> #5Dec 7, 2024 05:41PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

rv...@google.com <rv...@google.com> #6Jan 6, 2025 08:44AM

Marked as fixed.

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

Issue 272302679