Misconfiguration of component can cause home launcher to crash in infinite loop [272310200]

Assigned

Bug

Status Update

No update yet.

Description

dl...@atlassian.com

created issue #1

Mar 8, 2023 09:11PM

Component used:

LazyColumn -> Image -> GlanceModifier.height

Version used:

1.0.0-alpha05

Devices/Android versions reproduced on:

Samsung Galaxy S22 SM-S901U1 on Android 13 - issue occurs in infinite loop
Pixel 2 on Android 10 - No crash, widget shows with red "Glance App Widget Error"
Pixel 5 on Android 13 - Home launcher crashes when dropping the widget, but does not loop
Xiaomi Redmi Note 9 on MIUI 13.0.2, Android 12 - Stuck in loading state, launcher is still usable, but logcat indicates loop

Issue:

When building a Glance widget, I misconfigured a GlanceModifer.height parameter that ended up causing a crash in an infinite loop of the device's launcher making the tested Samsung phone unusable until I installed a fix and restarted the phone. Further testing had varying results dependent on device.

The issue is caused by a widget misconfiguration, but should probably be handled within Glance rather than allowing the device's launcher to crash as this could potentially unresolvably impact a user's experience outside of the app/widget.

The issue seems to only manifest when the misconfiguration occurs in a LazyColumn item, but I haven't tested too many other configurations.

Stacktrace:

FATAL EXCEPTION: main
Process: com.sec.android.app.launcher, PID: 3703
android.widget.RemoteViews$ActionException: android.content.res.Resources$NotFoundException: Resource ID #0xc
	at android.widget.RemoteViews$LayoutParamAction.getPixelSize(RemoteViews.java:3405)
	at android.widget.RemoteViews$LayoutParamAction.apply(RemoteViews.java:3347)
	at android.widget.RemoteViews.performApply(RemoteViews.java:6275)
	at android.widget.RemoteViews.apply(RemoteViews.java:5884)
	at android.widget.RemoteCollectionItemsAdapter.getView(RemoteCollectionItemsAdapter.java:199)
	at android.widget.AbsListView.obtainView(AbsListView.java:2622)
	at android.widget.ListView.measureHeightOfChildren(ListView.java:1452)
	at android.widget.ListView.onMeasure(ListView.java:1358)
	at android.view.View.measure(View.java:27720)
	at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:7352)
	at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
	at android.view.View.measure(View.java:27720)
	at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:7352)
	at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
	at com.android.launcher3.widget.LauncherAppWidgetHostView.onMeasure(LauncherAppWidgetHostView.java:1)
	at android.view.View.measure(View.java:27720)
	at com.android.launcher3.ShortcutAndWidgetContainer.measureChild(ShortcutAndWidgetContainer.java:27)
	at com.android.launcher3.ShortcutAndWidgetContainer.onMeasure(ShortcutAndWidgetContainer.java:7)
	at android.view.View.measure(View.java:27720)
	at com.android.launcher3.CellLayout.onMeasure(CellLayout.java:17)
	at com.android.homescreen.home.WorkspaceCellLayout.onMeasure(WorkspaceCellLayout.java:5)
	at android.view.View.measure(View.java:27720)
	at android.view.ViewGroup.measureChild(ViewGroup.java:7323)
	at android.view.ViewGroup.measureChildren(ViewGroup.java:7300)
	at com.android.launcher3.PagedView.onMeasure(PagedView.java:10)
	at android.view.View.measure(View.java:27720)
	at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:7352)
	at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
	at android.view.View.measure(View.java:27720)
	at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:7352)
	at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
	at android.view.View.measure(View.java:27720)
	at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:7352)
	at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
	at android.view.View.measure(View.java:27720)
	at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:7352)
	at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1552)
	at android.widget.LinearLayout.measureVertical(LinearLayout.java:842)
	at android.widget.LinearLayout.onMeasure(LinearLayout.java:721)
	at android.view.View.measure(View.java:27720)
	at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:7352)
	at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
	at com.android.internal.policy.DecorView.onMeasure(DecorView.java:1375)
	at android.view.View.measure(View.java:27720)
	at android.view.ViewRootImpl.performMeasure(ViewRootImpl.java:4841)
	at android.view.ViewRootImpl.measureHierarchy(ViewRootImpl.java:3426)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3732)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:3116)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:10885)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1301)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1309)
	at android.view.Choreographer.doCallbacks(Choreographer.java:923)
	at android.view.Choreographer.doFrame(Choreographer.java:852)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1283)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:226)

Code sample:

import androidx.compose.runtime.Composable
import androidx.compose.ui.unit.sp
import androidx.datastore.preferences.core.Preferences
import androidx.glance.GlanceModifier
import androidx.glance.Image
import androidx.glance.ImageProvider
import androidx.glance.appwidget.GlanceAppWidget
import androidx.glance.appwidget.SizeMode
import androidx.glance.appwidget.lazy.LazyColumn
import androidx.glance.layout.height
import androidx.glance.state.GlanceStateDefinition
import androidx.glance.state.PreferencesGlanceStateDefinition
import com.myapp.R

class ExampleWidget : GlanceAppWidget() {

  override val sizeMode: SizeMode = SizeMode.Single

  override val stateDefinition: GlanceStateDefinition<Preferences> = PreferencesGlanceStateDefinition

  @Composable
  override fun Content() {
    val someValue = 12
    LazyColumn {
      item {
        Image(
          modifier = GlanceModifier.height(someValue.sp.value.toInt()),
          provider = ImageProvider(R.drawable.ic_reply),
          contentDescription = null
        )
      }
    }
  }
}

Result of the issue seems to be different per manufacturer and OS version. Devices tested, all with default launchers:

Galaxy S22 SM-S901U1 on Android 13 - issue occurs in loop
Pixel 2 on Android 10 - No crash, widget shows with red "Glance App Widget Error"
Pixel 5 on Android 13 - Home launcher crashes when dropping the widget, but does not loop
Xiaomi Redmi Note 9 on MIUI 13.0.2, Android 12 - Stuck in loading state, launcher is still usable, but logcat indicates loop

Comments

dl...@atlassian.com <dl...@atlassian.com> #2Mar 8, 2023 09:26PM

Hello,

I'm only a little familiar with Power Apps. Is your app a mobile app or a web app?

This link lists out the alternatives.

The primary recommended alternative for the Google Fit REST API is Health Connect.

If your app does not work on Android mobile devices, you can also consider the Fitbit Web API.

za...@google.com <za...@google.com> #3Mar 9, 2023 12:46AM

Es muy parecido a una webapp

El mié, 22 may 2024, 15:48, <buganizer-system@google.com> escribió:

- Show quoted text -

dl...@atlassian.com <dl...@atlassian.com> #4Mar 9, 2023 01:24PM

No, it is not supposed to take a raw value. The height takes either a @DimenRes (just realized I put DrawableRes before which is incorrect) or Dp if you look at the function signature, but this passes in a raw integer that doesn't map to a resource, so you end up with a crash and the stack trace that I shared. This ends up propagating to the system launcher and results in a potential crash loop like on the S22 that prevents user's from using the launcher and the phone for the most part. The only way to recover from this is install a new version of the app with a fixed widget and restart the phone.

dl...@atlassian.com <dl...@atlassian.com> #5Mar 13, 2023 05:21PM

To be clear, this issue is the exception propagates outside the widget, potentially impacting the phone and the user's ability to use their phone (not just the widget) if the launcher doesn't gracefully handle the exception as exhibited by the Samsung S22. I understand the crash loop is likely occurring due to the app launchers not handling the exception properly, but considering the result could be catastrophic to user experience by preventing them from using the launcher, this is something that should be addressed by the Glance or widget team as it could negatively impact Android as a product if this was erroneously shipped into production by any app maker.

za...@google.com <za...@google.com> #6Apr 4, 2023 07:21PM

Thanks for your detailed report. We have filed a bug on the launcher to track this issue.

We're also investigating whether resource existence can be tested in process in a practical way in the library too.