M3 ModalBottomSheet - The keyboard does not open when clicking on a text field in the modal [272483584]

Fixed

Bug

Status Update

No update yet.

Description

b....@gmail.com

created issue #1

Mar 9, 2023 04:53PM

Jetpack Compose version: 1.3.3

Material 3 version : 1.1.0-alpha08

Jetpack Compose component used: ModalBottomSheet

Android Studio Build: #AI-221.6008.13.2211.9619390

Kotlin version: 1.8.0

Issue : If we add a text field in a modal. When clicking on the text field of the modal. The keyboard does not open. Once you close the modal, the keyboard opens.

Simple code :


val scope = rememberCoroutineScope()
val sheetState = rememberModalBottomSheetState()
Button(onClick = {
    scope.launch {
        sheetState.show()
    }
}) {
    Text("Open it")
}
if (sheetState.isVisible) {
    ModalBottomSheet(
        sheetState = sheetState,
        onDismissRequest = {
            scope.launch {
                sheetState.hide()
            }
        },
    ) {
        TextField(
            value = "",
            onValueChange = { },
        )
    }
}

Comments

dy...@gmail.com <dy...@gmail.com> #2Mar 9, 2023 06:27PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ta...@gmail.com <ta...@gmail.com> #3Mar 10, 2023 12:00PM

I'm having the same problem, which makes this a dealbreaker for using it unfortunately.

se...@google.com <se...@google.com> #4Mar 10, 2023 04:48PM

I have somewhat tracked down the issue here and

https://issuetracker.google.com/268380384

In the other bug, the underlying popup is not set as focusable, so the keyboard opens. In alpha08 we have set the popup as focusable to intercept focus when the popup opens for A11y purposes. However it has the unintended consequence of intercepting ime actions, for some reason not passing them to child content despite the content (like textfield) still being focusable... Working on a solution.

se...@google.com <se...@google.com> Mar 13, 2023 12:39PM

Accepted by se...@google.com.

lx...@gmail.com <lx...@gmail.com> #5Mar 16, 2023 09:55AM

I find a way to make TextField editable for me. you can make a try.

ModalBottomSheet(/* .... */) {
    
    // add follow code here to make your text filed edtable.
    val view = LocalView.current.rootView.allViews
                    .filter { it.javaClass.name == "androidx.compose.ui.window.PopupLayout" }
                    .toList()
                    .first()
    (view.context.getSystemService(Context.WINDOW_SERVICE) as WindowManager)
                    .updateViewLayout(view,
                        (view.layoutParams as WindowManager.LayoutParams).apply {
                            flags = flags and WindowManager.LayoutParams.FLAG_NOT_FOCUSABLE.inv()
                        })
    
    // your bottom sheet content code
    TextField(/* ... */)
}

mr...@gmail.com <mr...@gmail.com> #6Apr 13, 2023 06:19PM

Has anyone found any way to fix this?

se...@google.com <se...@google.com> #7Apr 19, 2023 04:55PM

This issue which extends to any custom windows seems to have been resolved with: https://issuetracker.google.com/262140644

Waiting on that change to land to proceed on this issue.

ap...@google.com <ap...@google.com> #8Apr 20, 2023 03:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7545cec3617ab5d1ea83d66822bc094e7f03c562
Author: José Figueroa Santos <serniebanders@google.com>
Date: Wed Apr 19 16:04:18 2023

[Material3][gradle] Update compose dependencies to 1.4.2

Upgrade needed to intake the following bug fix:

b/262140644

, which resolves issue of new windows not calling IME keyboard.

Bug: 268380384
Bug: 272483584
RelNote: ModalBottomSheet now can display IME keyboard
Test: Manual
Change-Id: Idc5082008acb547cac2100a69cab4be7db85f50f

M compose/material3/material3/build.gradle
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt

https://android-review.googlesource.com/2548352

se...@google.com <se...@google.com> Apr 20, 2023 03:01PM

Marked as fixed.

za...@gmail.com <za...@gmail.com> #9Apr 22, 2023 02:28PM

It doesn't seem to be fixed for me. I used a snapshot build from androidx.dev (9991820) which has the updated dependencies, but the keyboard still doesn't show up when a text field is focused. It also no longer shows up once the bottom sheet is dismissed, so something did change, but not enough.

se...@google.com <se...@google.com> #10Apr 24, 2023 05:51PM

@ Comment#9 what device and API are you using.

za...@gmail.com <za...@gmail.com> #11Apr 24, 2023 06:26PM

I tested on a Pixel 7 running Android 14 Beta 1 and a Galaxy S23 Ultra running Android 13, both with Gboard.

When I tap a text field, it focuses and the cursor shows up, but the text scrubber handle also appears and is aligned to the top of the field instead of below the text.

za...@gmail.com <za...@gmail.com> #12May 13, 2023 12:31AM

It seems to be fully fixed in 1.2.0-alpha01.

ju...@google.com <ju...@google.com> #13May 24, 2023 07:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3-android:1.2.0-alpha02

ty...@udisc.com <ty...@udisc.com> #14Jun 25, 2023 03:01PM

Is this fix going to be back ported to 1.1? Seems like 1.2 alpha 2 does fix the issue but also introduces other issues such as the sheets not respecting system bars, some issue with insets always being zero unless you enable "edge to edge" mode.

va...@gmail.com <va...@gmail.com> #15Jan 18, 2024 03:41PM

there are couple of concerns related to the behavior of the BottomSheet in Jetpack Compose and its subsequent versions:

Overlapping with System Navigation Button:
Version 1.1.0 effectively resolves the issue of the BottomSheet overlapping with the system navigation button.
However, in versions above 1.1.0, including 1.2 alpha2, the BottomSheet reintroduces the problem of overlapping with the system navigation button.

TextField Click Behavior and Keyboard Activation:
The keyboard activation works fine in higher versions (1.2 alpha-2). However, the primary concern remains with the overlapping issue in these higher versions, which requires attention.

Seeking a comprehensive fix that addresses the overlapping with the system navigation button in higher versions, while acknowledging the keyboard activation improvement. Your attention to this matter would be highly appreciated.