IssueTracker

Background

We upgraded from AGP 7.2.2 to AGP 7.4.2 and are now seeing hard class verification failures (crash on startup) on Android 11. It appears the root cause is due to the ApiModelOutliner now being enabled and having a weird interaction with our existing ApiHelper classes (as described here).

I'll share artifacts (dex2oat logs, compiler dump) over email.

Details

Original Code:

@RequiresApi(api = Build.VERSION_CODES.S)
@AvoidRuntimeVerification
object Api31Helper {
    fun ongoingNotificationCallStyle(person: Person, hangUpIntent: PendingIntent): Notification.Style {
        return Notification.CallStyle.forOngoingCall(person, hangUpIntent)
    }

Proguard Rules:

# Disable inlining on classes which could trigger a runtime verification
# Ref: https://chromium.googlesource.com/chromium/src/+/HEAD/build/android/docs/class_verification_failures.md
-keep,allowshrinking,allowobfuscation @com.snap.framework.annotations.AvoidRuntimeVerification class * {
  *;
}

-keepclasseswithmembers,allowshrinking,allowobfuscation class * {
    @com.snap.framework.annotations.AvoidRuntimeVerification <methods>;
}

-keepclasseswithmembers,allowshrinking,allowobfuscation class * {
    @com.snap.framework.annotations.AvoidRuntimeVerification <init>(...);
}

Smali Before (AGP 7.2):

class Api31Helper

.method public final h(Landroid/app/Person;Landroid/app/PendingIntent;)Landroid/app/Notification$Style;
    .registers 3

    0022cbec: 7120 146e 2100          0000: invoke-static       {v1, v2}, Landroid/app/Notification$CallStyle;->forOngoingCall(Landroid/app/Person;, Landroid/app/PendingIntent;)Landroid/app/Notification$CallStyle; # method@6e14
    0022cbf2: 0c01                    0003: move-result-object  v1
    0022cbf4: 1101                    0004: return-object       v1
    
.end method

Smali After (AGP 7.4):

class WN (Api31Helper)


.method public final h(Landroid/app/Person;Landroid/app/PendingIntent;)Landroid/app/Notification$Style;
    .registers 3

    00227804: 7120 df57 2100          0000: invoke-static       {v1, v2}, LVN;->f(Landroid/app/Person;, Landroid/app/PendingIntent;)Landroid/app/Notification$CallStyle; # method@57df
    0022780a: 0c01                    0003: move-result-object  v1
    0022780c: 1101                    0004: return-object       v1
    

class VN (com.snap.framework.apihelpers.Api31Helper$$ExternalSyntheticApiModelOutline0
)

.method public static bridge synthetic f(Landroid/app/Person;Landroid/app/PendingIntent;)Landroid/app/Notification$CallStyle;
    .registers 2

    002274e8: 7120 4e6e 1000          0000: invoke-static       {v0, v1}, Landroid/app/Notification$CallStyle;->forOngoingCall(Landroid/app/Person;, Landroid/app/PendingIntent;)Landroid/app/Notification$CallStyle; # method@6e4e
    002274ee: 0c00                    0003: move-result-object  v0
    002274f0: 1100                    0004: return-object       v0
    
.end method

Workaround

We can fix the crash by removing our proguard rules; however, we see that it will cause class verification failures to be re-introduced in other spots. In other words, ApiModelOutliner does not yet appear to be 100% effective so we'd need to keep our approach for the time being and thus revert back to AGP 7.2 in the interim.