Prevent passing detached fragment to BackStackChangedListener callbacks [273568280]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Mar 14, 2023 08:11PM

The new `OnBackStackChangedListener` callback APIs, `onBackStackChangeStarted` and `onBackStackChangeCommitted` were added as part of the current release but have different timing. The `onBackStackChangeStarted` callbacks are executed before any operations are executed while `onBackStackChangeCommitted` is executed after the operations are executed.

The current timing of `onBackStackChangeCommitted` means that it received fragments that have been detached from the `FragmentManager` and had all of the state deleted, which is not very useful in the callback.

It seems that the timing of `onBackStackChangeStarted` is the correct timing for both callback as currently implemented. We should adjust `onBackStackChangeCommitted` to reflect that. In the future, as fragment integrates with predictive back APIs, we anticipate that the timing of `onBackStackChangeStarted` may change.

Comments

ap...@google.com <ap...@google.com> #2Mar 14, 2023 10:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit 822b94312ab0e71054dcf8c007d4d8b6ba61db98
Author: Clara Fok <clarafok@google.com>
Date: Wed Dec 06 16:09:13 2023

Refactor PagingDataDiffer PageEvent processing

Streamline the process in preparation for upcoming refactors

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Bug: 315214786
Change-Id: I809a5197633e9d7167388160509bec00566d7417

M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagePresenter.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataDiffer.kt

https://android-review.googlesource.com/2871509

jb...@google.com <jb...@google.com> #3Mar 16, 2023 11:51PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit fb741839c9be2e2a0a9e023bbba3c0cbac3c9ebb
Author: Clara Fok <clarafok@google.com>
Date: Wed Dec 06 16:22:46 2023

Rename PagePresenter to PageStore

PageStore will be refactored to only process and store loaded data.

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Bug: 315214786
Change-Id: Ic3502d2a541e02355d65cc5154025a0301a50ec5

M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageStore.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataDiffer.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotStateTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageStoreTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/ProcessPageEventCallbackCapture.kt

https://android-review.googlesource.com/2871510

pr...@google.com <pr...@google.com> #4Mar 22, 2023 08:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3621927b29ae21d513ea12dc171bf795397b6a0a
Author: Clara Fok <clarafok@google.com>
Date: Fri Dec 08 14:19:41 2023

Rename PagingDataDiffer to PagingDataPresenter

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Test: ./gradlew paging:paging-compose:cC
Bug: 315214786
Change-Id: I9e0c98ef8508c267c2d02ff64a40d698f9f10bb3

M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PageFetcherTest.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageEvent.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageStore.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/ViewportHint.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageEventTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingDataDifferTest.kt
M paging/paging-compose/src/commonMain/kotlin/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-guava/src/test/java/androidx/paging/ListenableFuturePagingDataTest.kt
M paging/paging-runtime/src/main/java/androidx/paging/AsyncPagingDataDiffer.kt
M paging/paging-rxjava2/src/test/java/androidx/paging/rxjava2/RxPagingDataTest.kt
M paging/paging-rxjava3/src/test/java/androidx/paging/rxjava3/RxPagingDataTest.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/LoadErrorHandler.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/PagerFlowSnapshot.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/SnapshotLoader.kt
M testutils/testutils-paging/src/commonMain/kotlin/androidx/paging/TestPagingDataPresenter.kt

https://android-review.googlesource.com/2871511

Issue 273568280

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 14, 2023 10:23PM

jb...@google.com <jb...@google.com> #3Mar 16, 2023 11:51PM

pr...@google.com <pr...@google.com> #4Mar 22, 2023 08:21PM

Add comment

Issue metadata