Compose BottomSheetScaffold crashes when given a BottomSheetScaffoldState with SheetState where initialValue = SheetValue.Hidden [273870234]

Fixed

Bug

Status Update

No update yet.

Description

dt...@phunware.com

created issue #1

Mar 16, 2023 08:21PM

```
Build: AI-222.4459.24.2221.9471578, 202301100208,

AI-222.4459.24.2221.9471578, JRE 17.0.4.1+0-17.0.4.1b469.62-9127311x64 JetBrains s.r.o., OS Mac OS X(aarch64) v12.6, screens 3456.0x2234.0, 2560.0x1440.0; Retina

AS: Flamingo | 2022.2.1 Beta 1
Kotlin plugin: 222-1.8.0-release-AS3739.54
Android Gradle Plugin: 7.3.1
Gradle: 7.4.2
Gradle JDK: version 17.0.4
NDK: from local.properties: (not specified), latest from SDK: (not found)
CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)

```

lib versions
compose-material3 = "1.1.0-alpha08"
androidx-compose-bom = "2023.01.00"
composeCompiler = "1.4.2"

Thu Mar 16 2023 13:18:46 GMT-0700 (Pacific Daylight Time).png

19 KB

View

Download

bottomsheetscaffold_crash.txt

19 KB

View

Download

Comments

ae...@google.com <ae...@google.com> Mar 18, 2023 12:07AM

Assigned to je...@google.com.

jo...@google.com <jo...@google.com> Mar 20, 2023 10:22AM

Reassigned to jo...@google.com.

jo...@google.com <jo...@google.com> Mar 20, 2023 05:32PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> Mar 21, 2023 05:15PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #2Mar 22, 2023 05:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit e40004b9e772b5e4e66a8dcdc3d2e2a1628108ad
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Mar 21 14:39:09 2023

[M3][BottomSheetScaffold] Adds Hidden state boolean flag to sheet state.

This enables standardBottomSheet to implement a fully Hidden state should the user choose to.

Additionally adds documentation to SheetState.requireOffset(), and updates BottomSheetDefaults.MinimizedShape -> BottomSheetDefaults.HiddenShape

Bug: 274463511
Bug: 273870234
Test: Tests updated Hidden functionality for BottomSheetScaffold
Test: Preserves existing unit tests where Hidden state does not exist
RelNote: SheetState now has optional skipHiddenState parameter
RelNote: rememberStandardBottomSheetState now has optional skipHiddenState parameter
RelNote: BottomSheetScaffold now has a defined Hidden anchor, though it is disabled by default
RelNote: SheetState.requireOffset documentation has been updated
RelNote: BottomSheetDefaults.MinimizedShape has been renamed as BottomSheetDefaults.HiddenShape
Change-Id: I839f464c556eafb1b6fd823134da46943475919d

M compose/material3/material3/api/public_plus_experimental_1.1.0-beta01.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/BottomSheetScaffoldTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/BottomSheetScaffold.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Strings.kt
M compose/material3/material3/src/desktopMain/kotlin/androidx/compose/material3/Strings.desktop.kt

https://android-review.googlesource.com/2500395

se...@google.com <se...@google.com> #3Mar 22, 2023 05:57PM

Marked as fixed.

Resolved as of next release. Please note the default behavior for BottomSheetScaffold will still be to not allow Hidden value, but this can be overriden with a new flag for the State object. This is because StandardBottomSheet by design should generally coexist with the UI, in a Partially or fully expanded state.

na...@google.com <na...@google.com> #4Apr 5, 2023 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.1.0-beta02

ka...@gmail.com <ka...@gmail.com> #5Aug 11, 2023 05:03AM

I'm facing this issue again in the new version of material3 1.2.0.alpha-05, It was working fine until alpha-04 but the moment I change it to 05 the app crashes and I get this error. I am also facing this issue if I change the foundation version from 1.6.0-alpha02 to 1.6.0-alpha03

Message last modified on Aug 11, 2023 05:04AM

64...@gmail.com <64...@gmail.com> #6Aug 20, 2023 03:36AM

Same here as described in #5 the issue seems back in 1.2.0-alpha05 and was working fine on 1.2.0-alpha04 and before. However, this time it doesn't seem to be working even with the defaults (which uses PartiallyExpanded as initialState internally). I've created a new bug ticket for this: b/296707223.

fo...@gmail.com <fo...@gmail.com> #7Aug 30, 2023 12:39PM

Crashing for me as well on `1.2.0-alpha06`

gu...@cheerz.com <gu...@cheerz.com> #8Jul 1, 2024 04:46PM

Still present on 1.2.1. Can you reopen the issue please ?

as...@gmail.com <as...@gmail.com> #9Aug 12, 2024 03:05PM

Comment has been deleted.

Message last modified on Sep 15, 2024 08:53AM