Assigned
Status Update
Comments
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 8d80f9b425a10b045f6de03ae521e8c7d368cb0d
Author: Chris Craik <ccraik@google.com>
Date: Mon May 01 14:12:18 2023
Handle new shader directory on U / API 34
Fixes: 274314544
Test: MacrobenchmarkScopeTest (API 33 + 34)
Relnote: "Fixes crash when dropping shaders on Android U (API 34), as
well as on emulators."
Android U moved the shader directory, which now needs to be handled in
macrobench/profileinstaller.
Also fixes access error to shellWrapper.sh after adb unroot (or
disconnect/reconnect.
Change-Id: I031ca38e15b9412e84a33eee4eb709cbf3014066
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/BenchmarkOperation.java
https://android-review.googlesource.com/2573042
Branch: androidx-main
commit 8d80f9b425a10b045f6de03ae521e8c7d368cb0d
Author: Chris Craik <ccraik@google.com>
Date: Mon May 01 14:12:18 2023
Handle new shader directory on U / API 34
Fixes: 274314544
Test: MacrobenchmarkScopeTest (API 33 + 34)
Relnote: "Fixes crash when dropping shaders on Android U (API 34), as
well as on emulators."
Android U moved the shader directory, which now needs to be handled in
macrobench/profileinstaller.
Also fixes access error to shellWrapper.sh after adb unroot (or
disconnect/reconnect.
Change-Id: I031ca38e15b9412e84a33eee4eb709cbf3014066
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/BenchmarkOperation.java
cc...@google.com <cc...@google.com> #4
Reopening this to track disabling shader clearing by default on API 34, since it no longer happens once per app update, starting in API 34.
Note though that we'll need to start triggering cold start with a warmup iteration to ensure shaders are compiled on API 34, like we already do with hot/warm starts.
Description
TLDR: Attempting to run startupBenchmark tests on emulator with api 33 (had a similar dropShader error on physical device so using emulator). Looks like shell command is missing an argument
Component used:
Version used:
profileinstaller:1.3.0-rc01
benchmark-macro-junit4:1.2.0-alpha11
Devices/Android versions reproduced on: Emulator - api 33
If this is a bug in the library, we would appreciate if you could attach:
log output:
function in question: