dropShaderCache causes exception during benchmark tests [274314544]

Assigned

Bug

Status Update

No update yet.

Description

bb...@jeniusbank.com

created issue #1

Mar 20, 2023 04:13PM

TLDR: Attempting to run startupBenchmark tests on emulator with api 33 (had a similar dropShader error on physical device so using emulator). Looks like shell command is missing an argument

Component used:

benchmarkRule.measureRepeated(
        packageName = "com.myApp",
        metrics = listOf(StartupTimingMetric()),
        iterations = 10,
        compilationMode = compilationMode, // occurs on full, none, and partial
        startupMode = StartupMode.COLD

Version used:

profileinstaller:1.3.0-rc01

benchmark-macro-junit4:1.2.0-alpha11

Devices/Android versions reproduced on: Emulator - api 33

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

log output:

java.lang.IllegalStateException: Expected no stdout/stderr from find /data/user_de/0/[com.MyApp]/code_cache -type f | xargs rm, saw Output(stdout=, stderr=rm: Needs 1 argument (see "rm --help"))
at androidx.benchmark.Shell.executeScriptSilent(Shell.kt:232)
at androidx.benchmark.Shell.executeScriptSilent$default(Shell.kt:230)
at androidx.benchmark.macro.MacrobenchmarkScope.dropShaderCache(MacrobenchmarkScope.kt:249)

function in question:

public fun dropShaderCache() {
        Log.d(TAG, "Dropping shader cache for $packageName")
        val dropError = ProfileInstallBroadcast.dropShaderCache(packageName)
        if (dropError != null) {
            if (Shell.isSessionRooted()) {
                // fall back to root approach
                val path = getShaderCachePath(packageName)
                Shell.executeScriptSilent("find $path -type f | xargs rm")
            } else {
                throw IllegalStateException(dropError)
            }
        }
    }

Comments

cc...@google.com <cc...@google.com> #2May 2, 2023 12:00AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3May 2, 2023 12:02AM

Project: platform/frameworks/support
Branch: androidx-main

commit 8d80f9b425a10b045f6de03ae521e8c7d368cb0d
Author: Chris Craik <ccraik@google.com>
Date: Mon May 01 14:12:18 2023

Handle new shader directory on U / API 34

Fixes: 274314544
Test: MacrobenchmarkScopeTest (API 33 + 34)
Relnote: "Fixes crash when dropping shaders on Android U (API 34), as
well as on emulators."

Android U moved the shader directory, which now needs to be handled in
macrobench/profileinstaller.

Also fixes access error to shellWrapper.sh after adb unroot (or
disconnect/reconnect.

Change-Id: I031ca38e15b9412e84a33eee4eb709cbf3014066

M benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/BenchmarkOperation.java

https://android-review.googlesource.com/2573042

cc...@google.com <cc...@google.com> #4May 12, 2023 06:00PM

Status: Assigned (reopened)

Reopening this to track disabling shader clearing by default on API 34, since it no longer happens once per app update, starting in API 34.

Note though that we'll need to start triggering cold start with a warmup iteration to ensure shaders are compiled on API 34, like we already do with hot/warm starts.

Message last modified on May 12, 2023 06:00PM

Issue 274314544

Description

Issue summary

Comments

cc...@google.com <cc...@google.com> #2May 2, 2023 12:00AM

ap...@google.com <ap...@google.com> #3May 2, 2023 12:02AM

cc...@google.com <cc...@google.com> #4May 12, 2023 06:00PM

Add comment

Issue metadata