R8 NullPointerException at markTypeAsLive AGP 7.4.1 [274337639]

Fixed

Bug

Status Update

No update yet.

Description

ju...@veepee.com

created issue #1

Mar 20, 2023 12:07PM

I am trying to update from AGP 7.2.2 to 7.4.1, however I am getting the results from compilation_log_without_dump.txt in the terminal (the exact command I run is in the beginning of the file).

Caused by: java.lang.NullPointerException
        at com.android.tools.r8.shaking.Enqueuer.markTypeAsLive(Enqueuer.java:2012)

When running it with -Dcom.android.tools.r8.dumpinputtofile=mydump.zip We get what is in mydump.zip and compilation_log_with_dump.txt, where I don't see printed in the terminal the null pointer, but I suppose it still happens.

I got similar results with r8 4.0.41 to 4.0.55 and 8.0.35.

Sadly, I couldn't reproduce it in a small shareable project.

Let me know if there is anything else I can do/share.

compilation_log_without_dump.txt

30 KB

View

Download

compilation_log_with_dump.txt

29 KB

View

Download

mydump.zip

133 MB

Download

Comments

sg...@google.com <sg...@google.com> #2Mar 20, 2023 12:19PM

Reassigned to sg...@google.com.

I also have the same issue so it seems to be a real problem.

ap...@google.com <ap...@google.com> #3Mar 21, 2023 10:06AM

Marked as fixed.

Dup here:

http://code.google.com/p/android/issues/detail?id=27959&can=1&q=fixed%20position&colspec=ID%20Type%20Status%20Owner%20Summary%20Stars

Though it's a bit more detailed with the minimum necessary to reproduce.

ap...@google.com <ap...@google.com> #4Mar 21, 2023 10:07AM

why is this marked has Obsolete? this is still a bug that is happening and its difficult to fix.
for all who are looking for a solution use this:

http://stackoverflow.com/questions/16200972/android-css-positionfixed-after-a-device-rotate

sg...@google.com <sg...@google.com> #5Mar 21, 2023 10:10AM

I will backport this to the 8.0 and 4.0 branches.

ju...@veepee.com <ju...@veepee.com> #6Mar 21, 2023 02:10PM

Thank you very much for taking a look at this!

Is this fix related to the nullpointer or the malformed inner-class attributes ?

Do you have a separated ticket for it? Could you share it?

ap...@google.com <ap...@google.com> #7Mar 21, 2023 04:06PM

Project: r8
Branch: 4.0

commit 6edb00fb23e41b28d4794cfa69d706d5c5aa3fba
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:55:01 2023

Version 4.0.56

Bug:

b/274337639

Change-Id: I88a20fc922ce892d38fa3a34f9a3f1f4714354ae

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77447

ap...@google.com <ap...@google.com> #8Mar 21, 2023 04:06PM

Project: r8
Branch: 4.0

commit d9215af3b02f64d1207b9ebd63a6925229307b9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:50 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

Change-Id: Iae204ed529f9af5bf5fa3eaacba45128dfa6fd9e

M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77446

ap...@google.com <ap...@google.com> #9Mar 21, 2023 04:06PM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

Change-Id: I7573883d6a649eed47b10d7bf0cdea2e11710268

M build.gradle
M src/main/java/com/android/tools/r8/cf/code/frame/UninitializedNew.java
A src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77445

ap...@google.com <ap...@google.com> #10Mar 21, 2023 04:06PM

Project: r8
Branch: 8.0

commit 6686e7dffea83ea894438b496c065d0a18cda206
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:53:01 2023

Version 8.0.37

Bug:

b/274337639

Change-Id: I43a723a94638088d921cd3fb6e22ef6e41f07d5f

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77444

ap...@google.com <ap...@google.com> #11Mar 21, 2023 04:06PM

Project: r8
Branch: 8.0

commit 57f55fb70aa678a61f9c7ff1826fbc695faeac7d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:52:27 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77443

ap...@google.com <ap...@google.com> #12Mar 21, 2023 04:06PM

Project: r8
Branch: 8.0

commit cd00c053222b06bb27fdd90bbed56af9c9ef0744
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:51:57 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77442

ap...@google.com <ap...@google.com> #13Mar 21, 2023 04:07PM

b/274337639

https://r8-review.googlesource.com/77446

ap...@google.com <ap...@google.com> #14Mar 21, 2023 04:07PM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

sg...@google.com <sg...@google.com> #15Mar 21, 2023 04:17PM

Answer to #comment6. This fix only addresses the NPE.

The malformed inner-class attributes is an issue with the input class files, and they where not related to the NPE. You will have to contact the supplier of the library where they are present if you would like to get rid of the "Info" messages (you will have to run ./gradlew --info ... to see them). From what I can see the issue is that the innerName: ψξψξψξξ$ψξξψξξξ should have been innerName: ψξξψξξξ.

ap...@google.com <ap...@google.com> #16Mar 21, 2023 05:15PM

Project: r8
Branch: 4.0

commit 49f738ff7377dacecf0fca39fec5146beb251ea3
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 18:14:15 2023

Version 4.0.57

Backport test to 4.0 test APIs.

Bug:

b/274337639

Change-Id: Iecf03a2ad9dcdbd53e6c572d2f08915248435682

M src/main/java/com/android/tools/r8/Version.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77450

ap...@google.com <ap...@google.com> #17Mar 21, 2023 05:18PM

Project: r8
Branch: 8.0

commit c11ddf096e58245c2c67514dc9e5a2098dd8f705
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 18:16:54 2023

Version 8.0.38

Backport test to 8.0 test APIs.

Bug:

b/274337639

Change-Id: I35ae6d701fa92a6a7a734f9c0296d1383fed8e20

M src/main/java/com/android/tools/r8/Version.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77451

pa...@gmail.com <pa...@gmail.com> #18May 11, 2023 04:11AM

Comment has been deleted.

Message last modified on Jul 14, 2023 05:45AM

pa...@gmail.com <pa...@gmail.com> #19May 11, 2023 04:12AM

Comment has been deleted.

Message last modified on Jul 14, 2023 05:45AM

tw...@gmail.com <tw...@gmail.com> #20Jul 13, 2023 10:35PM

Comment has been deleted.

Message last modified on Jul 14, 2023 05:45AM

Issue 274337639

Description

Issue summary

Comments

sg...@google.com <sg...@google.com> #2Mar 20, 2023 12:19PM

ap...@google.com <ap...@google.com> #3Mar 21, 2023 10:06AM

ap...@google.com <ap...@google.com> #4Mar 21, 2023 10:07AM

sg...@google.com <sg...@google.com> #5Mar 21, 2023 10:10AM

ju...@veepee.com <ju...@veepee.com> #6Mar 21, 2023 02:10PM

ap...@google.com <ap...@google.com> #7Mar 21, 2023 04:06PM

ap...@google.com <ap...@google.com> #8Mar 21, 2023 04:06PM

ap...@google.com <ap...@google.com> #9Mar 21, 2023 04:06PM

ap...@google.com <ap...@google.com> #10Mar 21, 2023 04:06PM

ap...@google.com <ap...@google.com> #11Mar 21, 2023 04:06PM

ap...@google.com <ap...@google.com> #12Mar 21, 2023 04:06PM

ap...@google.com <ap...@google.com> #13Mar 21, 2023 04:07PM

ap...@google.com <ap...@google.com> #14Mar 21, 2023 04:07PM

sg...@google.com <sg...@google.com> #15Mar 21, 2023 04:17PM

ap...@google.com <ap...@google.com> #16Mar 21, 2023 05:15PM

ap...@google.com <ap...@google.com> #17Mar 21, 2023 05:18PM

pa...@gmail.com <pa...@gmail.com> #18May 11, 2023 04:11AM

pa...@gmail.com <pa...@gmail.com> #19May 11, 2023 04:12AM

tw...@gmail.com <tw...@gmail.com> #20Jul 13, 2023 10:35PM

Add comment

Issue metadata