Move PlatformTextInputModifierNode.dispose() call to autoInvalidateNode when it is fixed [274661182]

Fixed

Internal Cleanup

Status Update

No update yet.

Description

kl...@google.com

created issue #1

Mar 21, 2023 09:13PM

Currently autoInvalidateNode is only called when modifier nodes are removed from modifier chain on a layout node, not when the entire layout node is detached. That will be fixed eventually so that it's called whenever a modifier node is going away for any reason.

PlatformTextInputModifierNode needs to be told when it's going away. That code should live in autoInvalidateNode, but cannot currently because of the above bug. Instead that call has been put in LayoutNode.detach(), but that's the wrong place for it to live long-term. When the above bug is fixed, it should be moved.

Comments

ap...@google.com <ap...@google.com> #2Jun 27, 2023 06:33PM

Marked as fixed.

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

na...@google.com <na...@google.com> #3Jul 26, 2023 05:21PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

Issue 274661182

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Jun 27, 2023 06:33PM

na...@google.com <na...@google.com> #3Jul 26, 2023 05:21PM

Add comment

Issue metadata