StackOverflowError when linking Kotlin/Native tests against datastore-preferences-core:1.1.0-alpha02 [274786186]

Fixed

Bug

Status Update

Updated by @

2 years ago

there is a new version of these library shipped on Mar 24 that works around this issue.

We'll keep the bug open for a better workaround.
corresponding youtrack bug:

https://youtrack.jetbrains.com/issue/KT-57531/KotlinNativeLink-StackOverflowError-when-consuming-library-with-dependency-cycles-from-constraints

Description

ru...@gmail.com

created issue #1

Mar 23, 2023 05:22AM

DataStore Component used: datastore-preferences-core
DataStore Version used: 1.1.0-alpha02
Devices/Android versions reproduced on: Kotlin 1.8.10

I get a StackOverflowError when building a project against datastore-preferences-core that includes native targets and test sources. I've uploaded a demo project to https://github.com/russhwolf/Datastore-Test-1.1.0-alpha02. You can see example build output at https://github.com/russhwolf/Datastore-Test-1.1.0-alpha02/actions/runs/4497253758/jobs/7912684754#step:4:124.

That build shows Linux output, but I've also seen the same behavior for the other Kotlin/Native targets. The issue goes away if the test sources are not included because the native test link step will then be skipped.

Comments

yb...@gmail.com <yb...@gmail.com> #2Mar 23, 2023 08:09AM

Agree

yb...@gmail.com <yb...@gmail.com> #3Mar 23, 2023 08:11AM

Also it causes slider to be unusable while onValuChangeFinished != null

yb...@gmail.com <yb...@gmail.com> #4Mar 23, 2023 08:30AM

Agree, big problem, started from alpha 11 +-

yb...@google.com <yb...@google.com> Mar 23, 2023 08:37AM

Reassigned to yb...@google.com.

ap...@google.com <ap...@google.com> #5Mar 23, 2023 09:25PM

I think this is because they are changed 1761 line of code

https://android-review.googlesource.com/c/platform/frameworks/support/+/2804280/1/compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Slider.kt#271

yb...@google.com <yb...@google.com> Jul 6, 2023 09:41PM

Marked as fixed.

ap...@google.com <ap...@google.com> #6Jul 19, 2023 06:28PM

#comment1 could you provide all of your dependencies for your project that you saw the issue in? It might have been fixed by a foundational module that Material3 depends on.

na...@google.com <na...@google.com> #7Jul 26, 2023 05:21PM

#comment6

this is all my dependencies, and i have similar problem on material3 version 1.2.0-rc01, slider is just don't move with using onValueChangeFinish param

[versions]
agp = "8.2.2"
coil-compose = "2.5.0"
compose-shimmer = "1.2.0"
sealedx-processor = "1.0.2"
sealedx-core = "1.0.2"
vico = "2.0.0-alpha.6"
github-core = "1.9.62"
github-glassmorphic-composables = "0.0.7"
github-sandwich = "2.0.5"
gson = "2.10.1"
haze-jetpack-compose = "0.4.5"
hilt-android = "2.46"
hilt-navigation-compose = "1.1.0"
kotlin = "1.9.22"
core-ktx = "1.12.0"
junit = "4.13.2"
androidx-test-ext-junit = "1.1.5"
espresso-core = "3.5.1"
ksp = "1.9.62"
lifecycle-runtime-ktx = "2.7.0"
activity-compose = "1.8.2"
compose-bom = "2023.10.01"
moshi = "1.15.0"
moshi-kotlin-codegen = "1.15.0"
retrofit = "2.9.0"
room-runtime = "2.6.1"
stories = "1.0.2"

[libraries]
androidx-hilt-navigation-compose = { module = "androidx.hilt:hilt-navigation-compose", version.ref = "hilt-navigation-compose" }
androidx-room-compiler = { module = "androidx.room:room-compiler", version.ref = "room-runtime" }
androidx-room-runtime = { module = "androidx.room:room-runtime", version.ref = "room-runtime" }
coil-compose = { module = "io.coil-kt:coil-compose", version.ref = "coil-compose" }

compose-shimmer = { module = "com.valentinilk.shimmer:compose-shimmer", version.ref = "compose-shimmer" }
converter-moshi = { module = "com.squareup.retrofit2:converter-moshi", version.ref = "retrofit" }
destinationCore = { module = "io.github.raamcosta.compose-destinations:core", version.ref = "github-core" }
core-ktx = { group = "androidx.core", name = "core-ktx", version.ref = "core-ktx" }
haze-jetpack-compose = { module = "dev.chrisbanes.haze:haze-jetpack-compose", version.ref = "haze-jetpack-compose" }
hilt-android = { module = "com.google.dagger:hilt-android", version.ref = "hilt-android" }
hilt-android-compiler = { module = "com.google.dagger:hilt-android-compiler", version.ref = "hilt-android" }
junit = { group = "junit", name = "junit", version.ref = "junit" }
androidx-test-ext-junit = { group = "androidx.test.ext", name = "junit", version.ref = "androidx-test-ext-junit" }
espresso-core = { group = "androidx.test.espresso", name = "espresso-core", version.ref = "espresso-core" }
destinationKsp = { module = "io.github.raamcosta.compose-destinations:ksp", version.ref = "ksp" }
lifecycle-runtime-ktx = { group = "androidx.lifecycle", name = "lifecycle-runtime-ktx", version.ref = "lifecycle-runtime-ktx" }
activity-compose = { group = "androidx.activity", name = "activity-compose", version.ref = "activity-compose" }
compose-bom = { group = "androidx.compose", name = "compose-bom", version.ref = "compose-bom" }
moshi = { module = "com.squareup.moshi:moshi", version.ref = "moshi" }
moshi-kotlin = { module = "com.squareup.moshi:moshi-kotlin", version.ref = "moshi" }
moshi-kotlin-codegen = { module = "com.squareup.moshi:moshi-kotlin-codegen", version.ref = "moshi-kotlin-codegen" }
retrofit = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit" }
sandwich-retrofit = { module = "com.github.skydoves:sandwich-retrofit", version.ref = "github-sandwich" }
sealedx-processor = { module = "com.github.skydoves:sealedx-processor", version.ref = "sealedx-processor" }
sealedx-core = { module = "com.github.skydoves:sealedx-core", version.ref = "sealedx-core" }
skydoves-sandwich = { module = "com.github.skydoves:sandwich", version.ref = "github-sandwich" }
stories = { module = "com.github.raipankaj:Stories", version.ref = "stories" }
ui = { group = "androidx.compose.ui", name = "ui" }
ui-graphics = { group = "androidx.compose.ui", name = "ui-graphics" }
ui-tooling = { group = "androidx.compose.ui", name = "ui-tooling" }
ui-tooling-preview = { group = "androidx.compose.ui", name = "ui-tooling-preview" }
ui-test-manifest = { group = "androidx.compose.ui", name = "ui-test-manifest" }
ui-test-junit4 = { group = "androidx.compose.ui", name = "ui-test-junit4" }
material3 = { group = "androidx.compose.material3", name = "material3", version = "1.2.0-rc01" }

vico-compose-m3 = { module = "com.patrykandpatryk.vico:compose-m3", version.ref = "vico" }

[plugins]
androidApplication = { id = "com.android.application", version.ref = "agp" }
kotlinAndroid = { id = "

org.jetbrains.kotlin.android", version.ref = "kotlin" }

[bundles]

lo...@gmail.com <lo...@gmail.com> #8Jul 31, 2023 12:42PM

Ran into the same issue, the onValuChangeFinished lambda is being passed as a remember key so recreates the state if that lambda reference changes (as seen in https://issuetracker.google.com/issues/322269951#comment5). You can work around it by remembering the lambda itself.

val context = LocalContext.current
var sliderPosition by remember { mutableStateOf(0f) }
val onValueChangeFinished: () -> Unit = remember {
  { Toast.makeText(context, sliderPosition.toString(), Toast.LENGTH_SHORT).show() }
}
Text(text = sliderPosition.toString())

Slider(
    value = sliderPosition, 
    onValueChange = { sliderPosition = it }, 
    onValueChangeFinished = onValueChangeFinished
)

yb...@google.com <yb...@google.com> #9Jul 31, 2023 03:48PM

Feb 19 is a U.S. holiday, there are 12+ impacted so far, Kevin, could you please take a look on tues once you are back at work? ty!