AndroidView with weight in a Column consumes all available space [274797771]

Fixed

Bug

Status Update

No update yet.

Description

di...@gmail.com

created issue #1

Mar 27, 2023 02:36PM

Jetpack Compose version: 1.4.0 Jetpack Compose component used: AndroidView Android Studio Build: Giraffe Canary 10 Kotlin version: 1.8.10

Given this setup:

Column {
  AndroidView(
    ...,
    Modifier.weight(1f)
  )
  Box(Modifier.height(100.dp))
}

In Compose 1.3, the AndroidView fills up most of the column, leaving 100dp for the Box.

In Compose 1.4, the AndroidView fills up the whole Column, leaving no room for the Box.

Sample project attached.

AndroidViewWeightBug.zip

498 KB

Download

Comments

sj...@gmail.com <sj...@gmail.com> #2Mar 27, 2023 02:40PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

as...@google.com <as...@google.com> #3Mar 27, 2023 04:18PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

Message last modified on Mar 27, 2023 05:56PM

ga...@gmail.com <ga...@gmail.com> #4Mar 27, 2023 08:50PM

deleted

ap...@google.com <ap...@google.com> #5Mar 28, 2023 05:15PM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

as...@google.com <as...@google.com> #6Mar 29, 2023 03:01AM

The fix should be part of the April 5th release.

sj...@gmail.com <sj...@gmail.com> #7Mar 29, 2023 05:04AM

Thank you!

na...@google.com <na...@google.com> #8Apr 5, 2023 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.4.1
androidx.compose.ui:ui:1.5.0-alpha02

la...@gmail.com <la...@gmail.com> #9Apr 8, 2023 04:55AM

Issue https://issuetracker.google.com/274741610 related to AndroidView is not yet resolved

mt...@gmail.com <mt...@gmail.com> #10Apr 8, 2023 02:52PM

I still observe the issue with 1.4.1 whereas it is fixed with 1.5.0-alpha02.

as...@google.com <as...@google.com> #11Apr 17, 2023 10:46PM

Status: Assigned (reopened)

Seems like 1.5.0-alpha02 also includes aosp/2470074, which forced the invalidation.

da...@gmail.com <da...@gmail.com> #12Apr 18, 2023 07:48AM

This should be fixes ASAP to 1.4.2, as like mentioned above it is still observed for 1.4.1

qw...@gmail.com <qw...@gmail.com> #13Apr 20, 2023 05:42AM

Reproduces even for 1.4.2

ae...@google.com <ae...@google.com> #14Apr 28, 2023 10:17PM

Marked as fixed.

The initial fix aosp/2510735 was cherry-picked into 1.4.1 and fixes part of the bug. aosp/2470074 provides a complete fix, and it's been cherry-picked (as aosp/2544354) into the upcoming 1.4.3 (to be released next week I think).

Therefore, any release at 1.5.0-alpha02 or 1.4.3 or newer should have this fixed.

na...@google.com <na...@google.com> #15May 3, 2023 06:24PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.4.3

ma...@wnco.com <ma...@wnco.com> #16Jun 12, 2024 10:10PM

Comment has been deleted.

Message last modified on Jun 12, 2024 10:15PM

Issue 274797771

Description

Issue summary

Comments

sj...@gmail.com <sj...@gmail.com> #2Mar 27, 2023 02:40PM

as...@google.com <as...@google.com> #3Mar 27, 2023 04:18PM

ga...@gmail.com <ga...@gmail.com> #4Mar 27, 2023 08:50PM

ap...@google.com <ap...@google.com> #5Mar 28, 2023 05:15PM

as...@google.com <as...@google.com> #6Mar 29, 2023 03:01AM

sj...@gmail.com <sj...@gmail.com> #7Mar 29, 2023 05:04AM

na...@google.com <na...@google.com> #8Apr 5, 2023 06:27PM

la...@gmail.com <la...@gmail.com> #9Apr 8, 2023 04:55AM

mt...@gmail.com <mt...@gmail.com> #10Apr 8, 2023 02:52PM

as...@google.com <as...@google.com> #11Apr 17, 2023 10:46PM

da...@gmail.com <da...@gmail.com> #12Apr 18, 2023 07:48AM

qw...@gmail.com <qw...@gmail.com> #13Apr 20, 2023 05:42AM

ae...@google.com <ae...@google.com> #14Apr 28, 2023 10:17PM

na...@google.com <na...@google.com> #15May 3, 2023 06:24PM

ma...@wnco.com <ma...@wnco.com> #16Jun 12, 2024 10:10PM

Add comment

Issue metadata