Fixed
Status Update
No update yet.
Comments
il...@google.com
sa...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020
Semantics no-op cleanups
Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:
- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".
- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)
Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."
Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt
https://android-review.googlesource.com/1360099
Branch: androidx-master-dev
commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020
Semantics no-op cleanups
Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:
- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".
- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)
Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."
Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit cd3c1d7751462b5e42ae54e2d68299f955dcb6c3
Author: Sanura Njaka <sanura@google.com>
Date: Mon Aug 07 07:34:20 2023
Folding lifecycle-livedata-ktx back into main
module
Now that Lifecycle tests are written in kotlin, all files in lifecycle-livedata-ktx can now be added into the main lifecycle-livedata module.
RelNote: "All files from the lifecycle-livedata-ktx modules have been moved into the main lifecycle-livedata module"
Test: ./gradlew bOS
Bug: 274800183
Change-Id: I10c6f70c82a64e80eec704f548911f42bdd0b56a
M lifecycle/lifecycle-livedata-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata/api/current.txt
M lifecycle/lifecycle-livedata/api/restricted_current.txt
M lifecycle/lifecycle-livedata/build.gradle
M lifecycle/lifecycle-livedata/src/androidTest/java/androidx.lifecycle/FlowAsLiveDataIntegrationTest.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/FlowLiveData.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataFlowJavaTest.java
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/ScopesRule.kt
https://android-review.googlesource.com/2695173
Branch: androidx-main
commit cd3c1d7751462b5e42ae54e2d68299f955dcb6c3
Author: Sanura Njaka <sanura@google.com>
Date: Mon Aug 07 07:34:20 2023
Folding lifecycle-livedata-ktx back into main
module
Now that Lifecycle tests are written in kotlin, all files in lifecycle-livedata-ktx can now be added into the main lifecycle-livedata module.
RelNote: "All files from the lifecycle-livedata-ktx modules have been moved into the main lifecycle-livedata module"
Test: ./gradlew bOS
Bug: 274800183
Change-Id: I10c6f70c82a64e80eec704f548911f42bdd0b56a
M lifecycle/lifecycle-livedata-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata/api/current.txt
M lifecycle/lifecycle-livedata/api/restricted_current.txt
M lifecycle/lifecycle-livedata/build.gradle
M lifecycle/lifecycle-livedata/src/androidTest/java/androidx.lifecycle/FlowAsLiveDataIntegrationTest.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/FlowLiveData.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataFlowJavaTest.java
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/ScopesRule.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 32c1896b0506529674f03076a1141daaa0749b28
Author: Sanura Njaka <sanura@google.com>
Date: Tue Aug 22 11:20:50 2023
Moving ScopesRule into util package
ScopesRule.kt will now be included in lifecycle-livedata's util package
Test: ./gradlew bOS
BUg: 274800183
Change-Id: I2df34eebffcdacc716ce0235e29601436918f955
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/util/ScopesRule.kt
https://android-review.googlesource.com/2721674
Branch: androidx-main
commit 32c1896b0506529674f03076a1141daaa0749b28
Author: Sanura Njaka <sanura@google.com>
Date: Tue Aug 22 11:20:50 2023
Moving ScopesRule into util package
ScopesRule.kt will now be included in lifecycle-livedata's util package
Test: ./gradlew bOS
BUg: 274800183
Change-Id: I2df34eebffcdacc716ce0235e29601436918f955
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/util/ScopesRule.kt
il...@google.com
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 4140c78328013f4fea4bd48f286c46a98c358270
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 14:43:43 2024
Move `lifecycle-viewmodel-ktx` source to the base module
* Transferred source code from `lifecycle-viewmodel-ktx` to the main `lifecycle-viewmodel` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
* Renamed the file from `ViewModel` to `ViewModelCoroutineScope` to reflect the content: coroutines support. Use `file:JvmName("ViewModelKt")` to maintain source compatibility.
* Add a resolutionStrategy to `:playground` and `:presentation` in `:tv:integration-tests` to resolve "minifyReleaseWithR8 FAILED: Class is defined multiple times" issue caused by moving classes from `-ktx` to the base module.
RelNote: "The `lifecycle-viewmodel-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: ViewModelCoroutinesTest
Change-Id: Id787b6db6817e69e4ec50748a07ccdbef074e99d
A lifecycle/lifecycle-viewmodel-ktx/api/current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/current.txt
A lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-ktx/build.gradle
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/build.gradle
M lifecycle/lifecycle-viewmodel/src/androidTest/java/androidx/lifecycle/ViewModelCoroutineScopeTest.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelCoroutineScope.kt
M tv/integration-tests/playground/build.gradle
M tv/integration-tests/presentation/build.gradle
https://android-review.googlesource.com/2930010
Branch: androidx-main
commit 4140c78328013f4fea4bd48f286c46a98c358270
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 14:43:43 2024
Move `lifecycle-viewmodel-ktx` source to the base module
* Transferred source code from `lifecycle-viewmodel-ktx` to the main `lifecycle-viewmodel` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
* Renamed the file from `ViewModel` to `ViewModelCoroutineScope` to reflect the content: coroutines support. Use `file:JvmName("ViewModelKt")` to maintain source compatibility.
* Add a resolutionStrategy to `:playground` and `:presentation` in `:tv:integration-tests` to resolve "minifyReleaseWithR8 FAILED: Class is defined multiple times" issue caused by moving classes from `-ktx` to the base module.
RelNote: "The `lifecycle-viewmodel-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: ViewModelCoroutinesTest
Change-Id: Id787b6db6817e69e4ec50748a07ccdbef074e99d
A lifecycle/lifecycle-viewmodel-ktx/api/current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/current.txt
A lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-ktx/build.gradle
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/build.gradle
M lifecycle/lifecycle-viewmodel/src/androidTest/java/androidx/lifecycle/ViewModelCoroutineScopeTest.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelCoroutineScope.kt
M tv/integration-tests/playground/build.gradle
M tv/integration-tests/presentation/build.gradle
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit ce327843c4c6bfeb3410a1203e0e2aac0f0a59cc
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 16:21:38 2024
Move `lifecycle-livedata-core-ktx` source to the base module
* Transferred source code from `lifecycle-livedata-core-ktx` to the base `lifecycle-livedata-core` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
RelNote: "The `lifecycle-livedata-core-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: manual
Change-Id: I54a3d4346b4a9c5861f5f3bdb0079dbb27f29668
A lifecycle/lifecycle-livedata-core-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/current.txt
A lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core-ktx/build.gradle
M lifecycle/lifecycle-livedata-core/api/current.txt
M lifecycle/lifecycle-livedata-core/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core/src/main/java/androidx/lifecycle/LiveData.kt
https://android-review.googlesource.com/2927827
Branch: androidx-main
commit ce327843c4c6bfeb3410a1203e0e2aac0f0a59cc
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 16:21:38 2024
Move `lifecycle-livedata-core-ktx` source to the base module
* Transferred source code from `lifecycle-livedata-core-ktx` to the base `lifecycle-livedata-core` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
RelNote: "The `lifecycle-livedata-core-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: manual
Change-Id: I54a3d4346b4a9c5861f5f3bdb0079dbb27f29668
A lifecycle/lifecycle-livedata-core-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/current.txt
A lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core-ktx/build.gradle
M lifecycle/lifecycle-livedata-core/api/current.txt
M lifecycle/lifecycle-livedata-core/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core/src/main/java/androidx/lifecycle/LiveData.kt
mg...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit b08ac008ee00cedd68d5f21a54c4035a7778c875
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Feb 07 11:19:04 2024
Move `lifecycle-runtime-ktx` source to the base module
* Transferred source code from `lifecycle-runtime-ktx` to the main `lifecycle-runtime` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
* Changed the method signature of `androidx.lifecycle.View.findViewTreeLifecycleOwner` from `View.findViewTreeLifecycleOwner()` to `findViewTreeLifecycleOwner(view)` to avoid a conflicting overload.
* Add a resolutionStrategy to `:playground` and `:presentation` in `:tv:integration-tests` to resolve "minifyReleaseWithR8 FAILED: Class is defined multiple times" issue caused by moving classes from `-ktx` to the base module.
RelNote: "The `lifecycle-runtime-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: FlowWithLifecycleTest
Test: LaunchWhenTest
Test: PausingDispatcherTest
Test: RepeatOnLifecycleTest
Test: ViewTreeLifecycleOwnerTest
Test: WithLifecycleStateTest
Change-Id: Ic368640a7e66dd0b748601d61b7aa23d99e5a1d6
D lifecycle/lifecycle-runtime-compose/api/current.ignore
D lifecycle/lifecycle-runtime-compose/api/restricted_current.ignore
A lifecycle/lifecycle-runtime-ktx/api/current.ignore
M lifecycle/lifecycle-runtime-ktx/api/current.txt
A lifecycle/lifecycle-runtime-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-runtime-ktx/api/restricted_current.txt
M lifecycle/lifecycle-runtime-ktx/build.gradle
D lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/ViewTreeLifecycleOwnerTest.kt
M lifecycle/lifecycle-runtime/api/current.txt
M lifecycle/lifecycle-runtime/api/restricted_current.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/Expectations.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FakeLifecycleOwner.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FlowWithLifecycleTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/LaunchWhenTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/PausingDispatcherTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/RepeatOnLifecycleTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TaskTracker.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TrackedExecutor.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/WithLifecycleStateTest.kt
M lifecycle/lifecycle-runtime/src/androidMain/AndroidManifest.xml
M lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/View.android.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/FlowExt.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/RepeatOnLifecycle.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/WithLifecycleState.kt
M tv/integration-tests/playground/build.gradle
M tv/integration-tests/presentation/build.gradle
https://android-review.googlesource.com/2928837
Branch: androidx-main
commit b08ac008ee00cedd68d5f21a54c4035a7778c875
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Feb 07 11:19:04 2024
Move `lifecycle-runtime-ktx` source to the base module
* Transferred source code from `lifecycle-runtime-ktx` to the main `lifecycle-runtime` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
* Changed the method signature of `androidx.lifecycle.View.findViewTreeLifecycleOwner` from `View.findViewTreeLifecycleOwner()` to `findViewTreeLifecycleOwner(view)` to avoid a conflicting overload.
* Add a resolutionStrategy to `:playground` and `:presentation` in `:tv:integration-tests` to resolve "minifyReleaseWithR8 FAILED: Class is defined multiple times" issue caused by moving classes from `-ktx` to the base module.
RelNote: "The `lifecycle-runtime-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: FlowWithLifecycleTest
Test: LaunchWhenTest
Test: PausingDispatcherTest
Test: RepeatOnLifecycleTest
Test: ViewTreeLifecycleOwnerTest
Test: WithLifecycleStateTest
Change-Id: Ic368640a7e66dd0b748601d61b7aa23d99e5a1d6
D lifecycle/lifecycle-runtime-compose/api/current.ignore
D lifecycle/lifecycle-runtime-compose/api/restricted_current.ignore
A lifecycle/lifecycle-runtime-ktx/api/current.ignore
M lifecycle/lifecycle-runtime-ktx/api/current.txt
A lifecycle/lifecycle-runtime-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-runtime-ktx/api/restricted_current.txt
M lifecycle/lifecycle-runtime-ktx/build.gradle
D lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/ViewTreeLifecycleOwnerTest.kt
M lifecycle/lifecycle-runtime/api/current.txt
M lifecycle/lifecycle-runtime/api/restricted_current.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/Expectations.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FakeLifecycleOwner.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FlowWithLifecycleTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/LaunchWhenTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/PausingDispatcherTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/RepeatOnLifecycleTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TaskTracker.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TrackedExecutor.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/WithLifecycleStateTest.kt
M lifecycle/lifecycle-runtime/src/androidMain/AndroidManifest.xml
M lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/View.android.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/FlowExt.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/RepeatOnLifecycle.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/WithLifecycleState.kt
M tv/integration-tests/playground/build.gradle
M tv/integration-tests/presentation/build.gradle
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit ce705f9552422d5cccd145244b3402fbade2768f
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Mon Feb 12 15:13:37 2024
Move `lifecycle-runtime-ktx-lint` to base module
* Rename `lifecycle-runtime-ktx-lint` to `lifecycle-runtime-lint`.
* Move `lintPublish` from obsolete `lifecycle-runtime-ktx` to `lifecycle-runtime`.
Bug: 274800183
Test: manual
Change-Id: I83bc2787fb3636b32e772f100bb8733793829708
M lifecycle/lifecycle-runtime-ktx/build.gradle
M lifecycle/lifecycle-runtime-lint/build.gradle
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/LifecycleRuntimeIssueRegistry.kt
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/LifecycleWhenChecks.kt
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/RepeatOnLifecycleDetector.kt
M lifecycle/lifecycle-runtime-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/ApiLintVersionsTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/LifecycleWhenChecksTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/RepeatOnLifecycleDetectorTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/WhenMethodsTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/stubs/Stubs.kt
M lifecycle/lifecycle-runtime/build.gradle
M settings.gradle
https://android-review.googlesource.com/2957874
Branch: androidx-main
commit ce705f9552422d5cccd145244b3402fbade2768f
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Mon Feb 12 15:13:37 2024
Move `lifecycle-runtime-ktx-lint` to base module
* Rename `lifecycle-runtime-ktx-lint` to `lifecycle-runtime-lint`.
* Move `lintPublish` from obsolete `lifecycle-runtime-ktx` to `lifecycle-runtime`.
Bug: 274800183
Test: manual
Change-Id: I83bc2787fb3636b32e772f100bb8733793829708
M lifecycle/lifecycle-runtime-ktx/build.gradle
M lifecycle/lifecycle-runtime-lint/build.gradle
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/LifecycleRuntimeIssueRegistry.kt
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/LifecycleWhenChecks.kt
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/RepeatOnLifecycleDetector.kt
M lifecycle/lifecycle-runtime-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/ApiLintVersionsTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/LifecycleWhenChecksTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/RepeatOnLifecycleDetectorTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/WhenMethodsTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/stubs/Stubs.kt
M lifecycle/lifecycle-runtime/build.gradle
M settings.gradle
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 7497f5ec6cd6deda184e32b612f468d739916be8
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Mon Feb 12 14:31:43 2024
Move `lifecycle-livedata-core-ktx-lint` to base module
* Rename `lifecycle-livedata-core-ktx-lint` to `lifecycle-livedata-core-lint`.
* Move `lintPublish` from obsolete `lifecycle-livedata-core-ktx` to `lifecycle-livedata-core`.
Bug: 274800183
Test: manual
Change-Id: Ib306e4c199d8a26d3465ad479249497909c46ff4
M lifecycle/lifecycle-livedata-core-ktx/build.gradle
M lifecycle/lifecycle-livedata-core-lint/build.gradle
M lifecycle/lifecycle-livedata-core-lint/src/main/java/androidx/lifecycle/lint/LiveDataCoreIssueRegistry.kt
M lifecycle/lifecycle-livedata-core-lint/src/main/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetector.kt
M lifecycle/lifecycle-livedata-core-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
M lifecycle/lifecycle-livedata-core-lint/src/test/java/androidx/lifecycle/livedata/core/lint/ApiLintVersionsTest.kt
M lifecycle/lifecycle-livedata-core-lint/src/test/java/androidx/lifecycle/livedata/core/lint/NonNullableMutableLiveDataDetectorTest.kt
M lifecycle/lifecycle-livedata-core-lint/src/test/java/androidx/lifecycle/livedata/core/lint/stubs/Stubs.kt
M lifecycle/lifecycle-livedata-core/build.gradle
M settings.gradle
https://android-review.googlesource.com/2957873
Branch: androidx-main
commit 7497f5ec6cd6deda184e32b612f468d739916be8
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Mon Feb 12 14:31:43 2024
Move `lifecycle-livedata-core-ktx-lint` to base module
* Rename `lifecycle-livedata-core-ktx-lint` to `lifecycle-livedata-core-lint`.
* Move `lintPublish` from obsolete `lifecycle-livedata-core-ktx` to `lifecycle-livedata-core`.
Bug: 274800183
Test: manual
Change-Id: Ib306e4c199d8a26d3465ad479249497909c46ff4
M lifecycle/lifecycle-livedata-core-ktx/build.gradle
M lifecycle/lifecycle-livedata-core-lint/build.gradle
M lifecycle/lifecycle-livedata-core-lint/src/main/java/androidx/lifecycle/lint/LiveDataCoreIssueRegistry.kt
M lifecycle/lifecycle-livedata-core-lint/src/main/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetector.kt
M lifecycle/lifecycle-livedata-core-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
M lifecycle/lifecycle-livedata-core-lint/src/test/java/androidx/lifecycle/livedata/core/lint/ApiLintVersionsTest.kt
M lifecycle/lifecycle-livedata-core-lint/src/test/java/androidx/lifecycle/livedata/core/lint/NonNullableMutableLiveDataDetectorTest.kt
M lifecycle/lifecycle-livedata-core-lint/src/test/java/androidx/lifecycle/livedata/core/lint/stubs/Stubs.kt
M lifecycle/lifecycle-livedata-core/build.gradle
M settings.gradle
mg...@google.com
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.lifecycle:lifecycle-livedata-core:2.8.0-alpha02androidx.lifecycle:lifecycle-livedata-core-ktx:2.8.0-alpha02androidx.lifecycle:lifecycle-runtime:2.8.0-alpha02androidx.lifecycle:lifecycle-runtime-compose:2.8.0-alpha02androidx.lifecycle:lifecycle-runtime-ktx:2.8.0-alpha02androidx.lifecycle:lifecycle-viewmodel:2.8.0-alpha02androidx.lifecycle:lifecycle-viewmodel-ktx:2.8.0-alpha02
Description
We should move all classes and functions from the -ktx artifacts into the base artifacts and have an empty -ktx artifacts that only depends on the originals.