IssueTracker

>>>> Pixel 4a landscape is not clipping the bottom of the sheet anymore, but a white box is appearing on the right side of the screen the size of the system navigation buttons when not using gesture navigation. <<<<

This is really a big problem. So unfortunately we cannot use the ModalBottomSheet productively yet.
When can we expect a correction?

upgraded to compose bom 2023.09.00. The right side no scrim issue is still there. Tested with Samsung m21 Android 13

such a shame that this issue still persists, it's been almost eight months

is there any update on this?

ModalBottomSheet is not ready for production yet, our project have a lot of code, I can't just enable edge-to-edge for my Activity.

Without edge-to-edge enabled (`decorFitsSystemWindows` is true) material ModalBottomSheet works incorrect, it always overlaps navigation bar.

I tried different solutions, but the only one that works for me is very ugly:

```
@Composable
@SuppressLint("DiscouragedApi")
// todo: https://issuetracker.google.com/issues/274872542
private fun rememberDimensionByName(name: String): Int {
    val resources = LocalContext.current.resources
    return remember {
        val id = resources.getIdentifier(name, "dimen", "android")
        if (id == 0) 0 else resources.getDimensionPixelSize(id)
    }
}

<...>

val topInsets = WindowInsets(top = rememberDimensionByName("status_bar_height"))
val bottomInsets = WindowInsets(bottom = rememberDimensionByName("navigation_bar_height"))
ModalBottomSheet(
    ...
    windowInsets = topInsets,
    content = {
        Box(Modifier.padding(bottomInsets.asPaddingValues())) {
            ...
        }
    },
)
```
android plugin "8.2.2"
kotlin version "1.9.22"
kotlinCompilerExtensionVersion = "1.5.8"
androidx.activity:activity-compose:1.8.2
androidx.compose.ui:ui:1.6.0
androidx.compose.material3:material3:1.1.2

Was really hoping that M3 1.2 moving to Rc1 meant this was fixed but appears its still very much an issue.

It's amazing how this is taking so long to fix.

When this will be fixed

Maybe when they release Material 4

We are in March 2024 and this is still an issue. When is this planned to be fixed?

Project: platform/frameworks/support
Branch: androidx-main

commit 33c32f65dd7879954cfa7a46a76eb959c977e291
Author: Jose Figueroa <serniebanders@google.com>
Date:   Tue Mar 19 17:08:01 2024

    [M3][BottomSheet] Migrate bottom sheet to dialog implementation from popup.
   
    Dialog provides access to the new window created, which allows for system bars styling, setDecorFitsSystemWindows for edge to edge functionality, and unconsumed window insets for proper content padding.
   
    Bug: 274872542
    Bug: 300280229
    Bug: 290893168
    Test: "Existing tests now check for dialog, toggle decorFitsSystemWindows for edge to edge. Added Unit Test for content window inset consumption. Manual testing on API 28, 31, 33, 34 on Pixel 4a, 7, 8, Tablet, and Samsung Galaxy S24"
    RelNote: "ModalBottomSheet more accurately draws scrim over status bar when edge to edge is enabled. Modal bottom sheet content can now consume window insets, allowing for visible content above navigation bar. ModalBottomSheet parameter windowInsets renamed to contentWindowInsets to specify where the insets will be applied, these are no longer tied to window logic. contentWindowInsets type has been changed to a function which returns WindowInsets, to allow it to be resolved within its new window."
    Change-Id: I39630f2d9a1b159ef27fa62750ffa26b00e078a0

M       compose/material3/material3/api/current.txt
M       compose/material3/material3/api/restricted_current.txt
M       compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/ui/common/CatalogScaffold.kt
M       compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt
M       compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M       compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M       compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
A       compose/material3/material3/src/main/res/values-v30/styles.xml
A       compose/material3/material3/src/main/res/values/styles.xml

https://android-review.googlesource.com/3007166

nice! thanks

Is there a fix available for this issue now?

hi, i'm testing 1.3.0-alpha06. the scrim now goes over the status bar when in edge to edge, which is great! however, i do have this problem (not sure if specific to alpha06) that the status bar color (and nav bar) is set to light whenever the scrim is on. any way to control weather the status bar color is light or dark? it looks like no matter what scrim i use, it is always light. thanks!

Do you have any plans for releasing a stable material3 1.3.0? If there is no plan for releasing a stable 1.3.0 soon, is it possible to cherry pick the fix to a 1.2.x release?

    ModalBottomSheet(
        onDismissRequest = { onDismiss() },
        sheetState = state,
        dragHandle = { BottomSheetDefaults.DragHandle() },
        modifier = Modifier.statusBarsPadding().navigationBarsPadding()
    ) {
        //Compose Body
    }

Similar issue I was facing while showing BottomSheet in full screen. I did some experiment with modifier and it worked.
My design requirement was to show full screen BottomSheet but below toolbar so I've added two properties.

I faced the issue recently. Using m3 1.3.0, fillMaxSize() skip partially expanded, it still go behind status bar although with windowInsetsPadding(WindowInsets.statusBars). I have to enableEdgeToEdge and manually going through my app to applied inset for other components if needed. Now the btm sheet work flawlessly with inset api.