Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit b2dde00cacbbb6e82822c9d02da233c0589a9609
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Nov 24 16:36:19 2021
Converting room-migration from Java to Kotlin.
Test: All tests in the room-migration directory.
Bug: 206858622
Relnote: Converting room-migration from Java to Kotlin.
Change-Id: I2724b688fc6dcd3c632dfe167364924edc5248b9
A room/room-migration/api/restricted_current.ignore
M room/room-compiler/src/main/kotlin/androidx/room/vo/Entity.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/SchemaEqualityUtil.kt
M room/room-compiler/src/test/kotlin/androidx/room/util/SchemaDifferTest.kt
M room/room-migration/build.gradle
M room/room-migration/src/test/java/androidx/room/migration/bundle/IndexBundleTest.kt
M room/room-migration/api/restricted_current.txt
M room/room-migration/src/main/java/androidx/room/migration/bundle/DatabaseViewBundle.kt
M room/room-migration/src/test/java/androidx/room/migration/bundle/EntityBundleTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/vo/DatabaseView.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/SchemaEquality.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/BundleUtil.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/ForeignKeyBundle.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/IndexBundle.kt
M room/room-migration/src/test/java/androidx/room/migration/bundle/PrimaryKeyBundleTest.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/PrimaryKeyBundle.kt
M room/room-migration/src/test/java/androidx/room/migration/bundle/FieldBundleTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/vo/FtsEntity.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/EntityBundle.kt
M room/room-migration/src/test/java/androidx/room/migration/bundle/DatabaseViewBundleTest.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/FtsOptionsBundle.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/SchemaBundle.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/FieldBundle.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/DatabaseBundle.kt
M room/room-compiler/src/main/kotlin/androidx/room/vo/Index.kt
M room/room-migration/src/test/java/androidx/room/migration/bundle/ForeignKeyBundleTest.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/FtsEntityBundle.kt
M room/room-migration/src/test/java/androidx/room/migration/bundle/DatabaseBundleTest.kt
https://android-review.googlesource.com/1902291
Branch: androidx-main
commit b2dde00cacbbb6e82822c9d02da233c0589a9609
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Nov 24 16:36:19 2021
Converting room-migration from Java to Kotlin.
Test: All tests in the room-migration directory.
Bug: 206858622
Relnote: Converting room-migration from Java to Kotlin.
Change-Id: I2724b688fc6dcd3c632dfe167364924edc5248b9
A room/room-migration/api/restricted_current.ignore
M room/room-compiler/src/main/kotlin/androidx/room/vo/Entity.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/SchemaEqualityUtil.kt
M room/room-compiler/src/test/kotlin/androidx/room/util/SchemaDifferTest.kt
M room/room-migration/build.gradle
M room/room-migration/src/test/java/androidx/room/migration/bundle/IndexBundleTest.kt
M room/room-migration/api/restricted_current.txt
M room/room-migration/src/main/java/androidx/room/migration/bundle/DatabaseViewBundle.kt
M room/room-migration/src/test/java/androidx/room/migration/bundle/EntityBundleTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/vo/DatabaseView.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/SchemaEquality.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/BundleUtil.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/ForeignKeyBundle.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/IndexBundle.kt
M room/room-migration/src/test/java/androidx/room/migration/bundle/PrimaryKeyBundleTest.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/PrimaryKeyBundle.kt
M room/room-migration/src/test/java/androidx/room/migration/bundle/FieldBundleTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/vo/FtsEntity.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/EntityBundle.kt
M room/room-migration/src/test/java/androidx/room/migration/bundle/DatabaseViewBundleTest.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/FtsOptionsBundle.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/SchemaBundle.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/FieldBundle.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/DatabaseBundle.kt
M room/room-compiler/src/main/kotlin/androidx/room/vo/Index.kt
M room/room-migration/src/test/java/androidx/room/migration/bundle/ForeignKeyBundleTest.kt
M room/room-migration/src/main/java/androidx/room/migration/bundle/FtsEntityBundle.kt
M room/room-migration/src/test/java/androidx/room/migration/bundle/DatabaseBundleTest.kt
da...@google.com <da...@google.com>
pr...@google.com <pr...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.room:room-runtime:2.6.0-alpha02
androidx.room:room-runtime:2.5.2
Description
Component used:
androidx.room:room-runtime
Version used:
2.5.0+
Devices/Android versions reproduced on:
Robolectric tests
When the here , a
RoomDatabase
class has been converted from Java to Kotlinnull
check was skipped and this causes issues when instantiating the database in Robolectric.master code can be found here
By looking into SystemServiceRegistry , it's clear that this function can return
getSystemService
's implementation found innull
so the null check should still be kept.