Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit f63ddfecdd518d2a2015f71b5c7965508785fdb4
Author: Marcello Albano <maralb@google.com>
Date: Fri Mar 24 13:13:48 2023
Added support to generate startup-prof.txt in BaselineProfileRule
This PR adds a profile type parameter when generating a baseline
profile. When the profile type is `STARTUP` the generated file is a
startup-prof.txt. The internal format is the same HRF of baseline
profile.
Relnote: Added profile type parameter when generating baseline profiles
Bug: 275093123
Test: ./gradlew :benchmark:integration-tests:baselineprofile-library-consumer:testBaselineProfileGeneration :benchmark:integration-tests:baselineprofile-flavor-consumer:testBaselineProfileGeneration :benchmark:integration-tests:baselineprofile-consumer:testBaselineProfileGeneration :benchmark:benchmark-baseline-profile-gradle-plugin:test
Change-Id: Ie20d730efea37940bf9df519c86cdb29a4074d34
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Arguments.kt
M benchmark/benchmark-macro-junit4/api/current.txt
M benchmark/benchmark-macro-junit4/api/public_plus_experimental_current.txt
M benchmark/benchmark-macro-junit4/api/restricted_current.txt
M benchmark/benchmark-macro-junit4/src/main/java/androidx/benchmark/macro/junit4/BaselineProfileRule.kt
M benchmark/benchmark-macro/api/restricted_current.txt
D benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupProfilesTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
D benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/StartupProfiles.kt
M benchmark/integration-tests/macrobenchmark/src/androidTest/java/androidx/benchmark/integration/macrobenchmark/BaselineProfileRuleTest.kt
https://android-review.googlesource.com/2507957
Branch: androidx-main
commit f63ddfecdd518d2a2015f71b5c7965508785fdb4
Author: Marcello Albano <maralb@google.com>
Date: Fri Mar 24 13:13:48 2023
Added support to generate startup-prof.txt in BaselineProfileRule
This PR adds a profile type parameter when generating a baseline
profile. When the profile type is `STARTUP` the generated file is a
startup-prof.txt. The internal format is the same HRF of baseline
profile.
Relnote: Added profile type parameter when generating baseline profiles
Bug: 275093123
Test: ./gradlew :benchmark:integration-tests:baselineprofile-library-consumer:testBaselineProfileGeneration :benchmark:integration-tests:baselineprofile-flavor-consumer:testBaselineProfileGeneration :benchmark:integration-tests:baselineprofile-consumer:testBaselineProfileGeneration :benchmark:benchmark-baseline-profile-gradle-plugin:test
Change-Id: Ie20d730efea37940bf9df519c86cdb29a4074d34
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Arguments.kt
M benchmark/benchmark-macro-junit4/api/current.txt
M benchmark/benchmark-macro-junit4/api/public_plus_experimental_current.txt
M benchmark/benchmark-macro-junit4/api/restricted_current.txt
M benchmark/benchmark-macro-junit4/src/main/java/androidx/benchmark/macro/junit4/BaselineProfileRule.kt
M benchmark/benchmark-macro/api/restricted_current.txt
D benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupProfilesTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
D benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/StartupProfiles.kt
M benchmark/integration-tests/macrobenchmark/src/androidTest/java/androidx/benchmark/integration/macrobenchmark/BaselineProfileRuleTest.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 41eec90e662e83ead24770058fb3b3ae659e6f45
Author: Marcello Albano <maralb@google.com>
Date: Fri Mar 24 16:37:04 2023
Added startup profile artifact management to baseline profile plugin
This PR ensure the `startup-prof` artifacts are moved and managed
same as the baseline profile artifacts. Startup profiles are merged
in `src/<variant>/baselineProfiles/startup-prof.txt`, support all the
options of baseline profiles and are not filtered.
Bug: 275093123
Test: ./gradlew :benchmark:integration-tests:baselineprofile-library-consumer:testBaselineProfileGeneration :benchmark:integration-tests:baselineprofile-flavor-consumer:testBaselineProfileGeneration :benchmark:integration-tests:baselineprofile-consumer:testBaselineProfileGeneration :benchmark:benchmark-baseline-profile-gradle-plugin:test
Change-Id: Idb98475cc0b978b0a12039f35d84e620831fd87e
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/task/MergeBaselineProfileTask.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/producer/tasks/CollectBaselineProfileTask.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/utils/BaselineProfileProjectSetupRule.kt
M benchmark/integration-tests/baselineprofile-producer/src/main/java/androidx/benchmark/integration/baselineprofile/producer/BaselineProfileTest.kt
https://android-review.googlesource.com/2506846
Branch: androidx-main
commit 41eec90e662e83ead24770058fb3b3ae659e6f45
Author: Marcello Albano <maralb@google.com>
Date: Fri Mar 24 16:37:04 2023
Added startup profile artifact management to baseline profile plugin
This PR ensure the `startup-prof` artifacts are moved and managed
same as the baseline profile artifacts. Startup profiles are merged
in `src/<variant>/baselineProfiles/startup-prof.txt`, support all the
options of baseline profiles and are not filtered.
Bug: 275093123
Test: ./gradlew :benchmark:integration-tests:baselineprofile-library-consumer:testBaselineProfileGeneration :benchmark:integration-tests:baselineprofile-flavor-consumer:testBaselineProfileGeneration :benchmark:integration-tests:baselineprofile-consumer:testBaselineProfileGeneration :benchmark:benchmark-baseline-profile-gradle-plugin:test
Change-Id: Idb98475cc0b978b0a12039f35d84e620831fd87e
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/task/MergeBaselineProfileTask.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/producer/tasks/CollectBaselineProfileTask.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/utils/BaselineProfileProjectSetupRule.kt
M benchmark/integration-tests/baselineprofile-producer/src/main/java/androidx/benchmark/integration/baselineprofile/producer/BaselineProfileTest.kt
ma...@google.com <ma...@google.com>
na...@google.com <na...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.2.0-alpha13
androidx.benchmark:benchmark-common:1.2.0-alpha13
androidx.benchmark:benchmark-macro:1.2.0-alpha13
androidx.benchmark:benchmark-macro-junit4:1.2.0-alpha13
Description
In order to support startup profiles in baseline profiles gradle plugin we need to:
startup-prof
in the baseline profile rulesrc/<variant>/baselineProfiles/startup-prof.txt
.