ModalBottomSheet doesn't support navigation bar padding [275849044]

Duplicate

of 274872542

Bug

Status Update

No update yet.

Description

a3...@heb.com

created issue #1

Mar 29, 2023 09:40PM

androidx.compose.material3 = 1.1.0-alpha08 Jetpack Compose component used: ModalBottomSheet Android Studio Build: Android Studio Electric Eel | 2022.1.1 Patch 2 Kotlin version: 1.8.10

Steps to Reproduce or Code Sample to Reproduce:

Create ModalBottomSheet
Add a padding modifier

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun BottomSheetBug() {
    var showBS by remember { mutableStateOf(false) }

    Row {
        Text(text = "Click me", onClick = { showBS = true })
    }
    if (showBS) {
        ModalBottomSheet(
            onDismissRequest = { showBS = false},
            // .padding(bottom = ...) doesn't work either. 
            modifier = Modifier.navigationBarsPadding()
        ) {
            Row() {
                Text(text = "Hello World")
            }
        }
    }
}

Screen Shot 2023-03-29 at 4.36.56 PM.png

64 KB

View

Download

Screen Shot 2023-03-29 at 4.39.21 PM.png

21 KB

View

Download

Comments

a3...@heb.com <a3...@heb.com> #2Mar 29, 2023 10:00PM

Comment has been deleted.

Message last modified on Mar 29, 2023 10:26PM

ma...@google.com <ma...@google.com> #3Apr 6, 2023 08:08PM

Tested with 1.2-alpha02. There are some improvements but the cases still all have problems.

Pixel 4a landscape is not clipping the bottom of the sheet anymore, but a white box is appearing on the right side of the screen the size of the system navigation buttons when not using gesture navigation.

Pixel C API33 emulator in landscape the bottomsheet is now sized so all the items would be visible, IF it was appearing over top the system navigation bar, but the bottom is behind it still in that tablet case. On a Pixel C API29 emulator in landscape the bottomsheet appears on top of the system navigation bar, but taps are not being recognized on that are. (don't have samsung s5e tablet with android 9 to test right now)

in the sample and our usage, we are not using edge to edge mode or full scaffold infrastructure (actual app usage is with a ComposeView thats not full screen)

ap...@google.com <ap...@google.com> #4May 10, 2023 07:54PM

>>>> Pixel 4a landscape is not clipping the bottom of the sheet anymore, but a white box is appearing on the right side of the screen the size of the system navigation buttons when not using gesture navigation. <<<<

This is really a big problem. So unfortunately we cannot use the ModalBottomSheet productively yet.
When can we expect a correction?

se...@google.com <se...@google.com> #5May 10, 2023 08:07PM

Reassigned to se...@google.com.

upgraded to compose bom 2023.09.00. The right side no scrim issue is still there. Tested with Samsung m21 Android 13

eq...@gmail.com <eq...@gmail.com> #6May 18, 2023 04:57PM

Any updates on this?

se...@google.com <se...@google.com> #7Jun 1, 2023 07:30PM

Accepted by se...@google.com.

such a shame that this issue still persists, it's been almost eight months

se...@google.com <se...@google.com> Jun 27, 2023 03:02PM

Assigned to se...@google.com.

ag...@league.com <ag...@league.com> #8Jul 20, 2023 03:13PM

Some news about that?

aa...@gmail.com <aa...@gmail.com> #9Aug 7, 2023 01:32PM

is there any update on this?

se...@google.com <se...@google.com> #10Aug 15, 2023 06:07PM

ModalBottomSheet is not ready for production yet, our project have a lot of code, I can't just enable edge-to-edge for my Activity.

Without edge-to-edge enabled (`decorFitsSystemWindows` is true) material ModalBottomSheet works incorrect, it always overlaps navigation bar.

I tried different solutions, but the only one that works for me is very ugly:

```
@Composable
@SuppressLint("DiscouragedApi")
// todo:

https://issuetracker.google.com/issues/274872542
private fun rememberDimensionByName(name: String): Int {
val resources = LocalContext.current.resources
return remember {
val id = resources.getIdentifier(name, "dimen", "android")
if (id == 0) 0 else resources.getDimensionPixelSize(id)
}
}

<...>

val topInsets = WindowInsets(top = rememberDimensionByName("status_bar_height"))
val bottomInsets = WindowInsets(bottom = rememberDimensionByName("navigation_bar_height"))
ModalBottomSheet(
...
windowInsets = topInsets,
content = {
Box(Modifier.padding(bottomInsets.asPaddingValues())) {
...
}
},
)
```
android plugin "8.2.2"
kotlin version "1.9.22"
kotlinCompilerExtensionVersion = "1.5.8"
androidx.activity:activity-compose:1.8.2
androidx.compose.ui:ui:1.6.0
androidx.compose.material3:material3:1.1.2

se...@google.com <se...@google.com> Aug 29, 2023 02:11PM

Status: Duplicate of

274872542