ModalBottomSheet doesn't support navigation bar padding [275849044]

Duplicate

of 274872542

Bug

Status Update

No update yet.

Description

a3...@heb.com

created issue #1

Mar 29, 2023 09:40PM

androidx.compose.material3 = 1.1.0-alpha08 Jetpack Compose component used: ModalBottomSheet Android Studio Build: Android Studio Electric Eel | 2022.1.1 Patch 2 Kotlin version: 1.8.10

Steps to Reproduce or Code Sample to Reproduce:

Create ModalBottomSheet
Add a padding modifier

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun BottomSheetBug() {
    var showBS by remember { mutableStateOf(false) }

    Row {
        Text(text = "Click me", onClick = { showBS = true })
    }
    if (showBS) {
        ModalBottomSheet(
            onDismissRequest = { showBS = false},
            // .padding(bottom = ...) doesn't work either. 
            modifier = Modifier.navigationBarsPadding()
        ) {
            Row() {
                Text(text = "Hello World")
            }
        }
    }
}

Screen Shot 2023-03-29 at 4.36.56 PM.png

64 KB

View

Download

Screen Shot 2023-03-29 at 4.39.21 PM.png

21 KB

View

Download

Comments

a3...@heb.com <a3...@heb.com> #2Mar 29, 2023 10:00PM

Comment has been deleted.

Message last modified on Mar 29, 2023 10:26PM

ma...@google.com <ma...@google.com> #3Apr 6, 2023 08:08PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

ap...@google.com <ap...@google.com> #4May 10, 2023 07:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit 46eea23c96f45f0ee1e57d8aef2f1375507b0dec
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Apr 11 14:38:58 2023

[M3][ModalBottomSheet] Enable edge to edge functionality for ModalBottomSheet

Bug: 274872542
Bug: 272973615
Bug: 272334475
Bug: 268432129
Bug: 275849044
Bug: 275486106
Bug: 268433162
RelNote: Add window insets parameter to ModalBottomSheet.
RelNote: Scrim for ModalBottomSheet may now be drawn behind status bar with windowInsets set to zero
RelNote: Updated default ModalBottomSheet functionality to stay outside of system bars including navigation
RelNote: Status bar inset handling is provided by drag handle in edge-to-edge mode.
RelNote: BottomSheetDefaults includes window insets for BottomSheetWindow.
Test: Parameterizes existing tests to work with and without edgeToEdge enabled.
Test: Manual EdgeToEdge testing on various devices and android APIs
Change-Id: I312008e48573ebd21326f77216be0bcd0372aa78

M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt

https://android-review.googlesource.com/2531428

se...@google.com <se...@google.com> #5May 10, 2023 08:07PM

Reassigned to se...@google.com.

Bottom sheet window can now be moved outside of specified inset areas with windowInsets parameter. However, there is a known issue where even if the top level insets are zero'd out, they seem to be consumed preventing content from using system bar padding. Currently investigating.

eq...@gmail.com <eq...@gmail.com> #6May 18, 2023 04:57PM

Will this be backported to 1.1 or will we have to wait months for 1.2?

se...@google.com <se...@google.com> #7Jun 1, 2023 07:30PM

Accepted by se...@google.com.

Working on a bugfix release for 1.1, we will update here when that is landed.

se...@google.com <se...@google.com> Jun 27, 2023 03:02PM

Assigned to se...@google.com.

ag...@league.com <ag...@league.com> #8Jul 20, 2023 03:13PM

Any updates on this issue?

aa...@gmail.com <aa...@gmail.com> #9Aug 7, 2023 01:32PM

Any update team,

se...@google.com <se...@google.com> #10Aug 15, 2023 06:07PM

No updates yet but we are pushing to increase the priority of bottom sheet edge to edge fixes

se...@google.com <se...@google.com> Aug 29, 2023 02:11PM

Status: Duplicate of

274872542