ModalBottomSheet doesn't support navigation bar padding [275849044]

Duplicate

of 274872542

Bug

Status Update

No update yet.

Description

a3...@heb.com

created issue #1

Mar 29, 2023 09:40PM

androidx.compose.material3 = 1.1.0-alpha08 Jetpack Compose component used: ModalBottomSheet Android Studio Build: Android Studio Electric Eel | 2022.1.1 Patch 2 Kotlin version: 1.8.10

Steps to Reproduce or Code Sample to Reproduce:

Create ModalBottomSheet
Add a padding modifier

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun BottomSheetBug() {
    var showBS by remember { mutableStateOf(false) }

    Row {
        Text(text = "Click me", onClick = { showBS = true })
    }
    if (showBS) {
        ModalBottomSheet(
            onDismissRequest = { showBS = false},
            // .padding(bottom = ...) doesn't work either. 
            modifier = Modifier.navigationBarsPadding()
        ) {
            Row() {
                Text(text = "Hello World")
            }
        }
    }
}

Screen Shot 2023-03-29 at 4.36.56 PM.png

64 KB

View

Download

Screen Shot 2023-03-29 at 4.39.21 PM.png

21 KB

View

Download

Comments

a3...@heb.com <a3...@heb.com> #2Mar 29, 2023 10:00PM

Comment has been deleted.

Message last modified on Mar 29, 2023 10:26PM

ma...@google.com <ma...@google.com> #3Apr 6, 2023 08:08PM

Thanks for the report!

ap...@google.com <ap...@google.com> #4May 10, 2023 07:54PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

se...@google.com <se...@google.com> #5May 10, 2023 08:07PM

Reassigned to se...@google.com.

deleted

eq...@gmail.com <eq...@gmail.com> #6May 18, 2023 04:57PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

se...@google.com <se...@google.com> #7Jun 1, 2023 07:30PM

Accepted by se...@google.com.

Working on a bugfix release for 1.1, we will update here when that is landed.

se...@google.com <se...@google.com> Jun 27, 2023 03:02PM

Assigned to se...@google.com.

ag...@league.com <ag...@league.com> #8Jul 20, 2023 03:13PM

Any updates on this issue?

aa...@gmail.com <aa...@gmail.com> #9Aug 7, 2023 01:32PM

Any update team,

se...@google.com <se...@google.com> #10Aug 15, 2023 06:07PM

No updates yet but we are pushing to increase the priority of bottom sheet edge to edge fixes

se...@google.com <se...@google.com> Aug 29, 2023 02:11PM

Status: Duplicate of

274872542