Configuration change breaks passkey operation [276316128]

Fixed

Bug

Status Update

No update yet.

Description

dm...@ownid.com

created issue #1

Mar 31, 2023 08:42AM

Component used: Credentials

Version used: androidx.credentials:credentials:1.0.0-alpha05

androidx.credentials:credentials-play-services-auth:1.0.0-alpha05

Steps to reproduce:

Launch getCredential() or createCredential() like:

coroutineScope.launch {
    try {
        val result = credentialManager.getCredential(request,activity)
        handleSignIn(result)
    } catch (e : GetCredentialException) {
        handleFailure(e)
    }
 }

On Passkeys prompt slider (or on biometry/pin prompt) rotate device (trigger configuration change)
Result: coroutineScope is canceled but credential operation is not, causing:
1. Passkeys prompt slider is doubled
2. If we were on biometry prompt the Passkeys prompt slider is doubled + biometry prompt on top
3. If we confirm biometry prompt - Passkeys prompt is still present + no callback triggered as it checks CancellationSignal.
Expected correct behavior: Passkey operation is canceled correctly:
1. All Passkeys prompt sliders are closed
2. All biometry/pin prompts are closed.
3. Corresponding cancelation error (GetCredentialCancellationException/CreateCredentialCancellationException) is triggered.

Comments

su...@google.com <su...@google.com> Mar 31, 2023 08:59AM

Assigned to sg...@google.com.

he...@google.com <he...@google.com> #2Mar 31, 2023 03:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit 03b0fb9489943d5ed54cfe65fb8146fd83707418
Author: Alan Viverette <alanv@google.com>
Date: Fri Jun 30 11:15:14 2023

Deprecate BuildCompat.isAtLeastU()

Relnote: Deprecated BuildCompat.isAtLeastU(). Use SDK_INT >= 34 instead.
Fixes: 289269026
Test: ./gradlew lintDebug
Change-Id: I4f8e795cbfa8c965b5f21331645af55c6709e7ab

M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/os/BuildCompat.kt

https://android-review.googlesource.com/2647280

he...@google.com <he...@google.com> #3Mar 31, 2023 03:36PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2d0bac96f2d8f9ef7dd1d988e9c43fc622369977
Author: Alan Viverette <alanv@google.com>
Date: Fri Jul 07 11:10:07 2023

Replace usages of deprecated BuildCompat.isAtLeastU() et al

Bug: 289269026
Relnote: Removed usages of experimental isAtLeastU() API
Test: ./gradlew lintDebug
Change-Id: Ie9117598f70e8873011f98ebbe0e6cd502772c87

M activity/activity/src/main/java/androidx/activity/BackEventCompat.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/DropDownListView.java
M appsearch/appsearch/src/androidTest/java/androidx/appsearch/cts/app/AppSearchSessionPlatformCtsTest.java
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/CompilationMode.kt
M core/core-i18n/src/androidTest/java/androidx/core/i18n/CheckTheJavaApisTest.java
M core/core-i18n/src/androidTest/java/androidx/core/i18n/DateTimeFormatterCommonOptionsTest.kt
M core/core-i18n/src/androidTest/java/androidx/core/i18n/DateTimeFormatterTest.kt
M core/core/src/androidTest/java/androidx/core/app/ActivityCompatTest.java
M core/core/src/androidTest/java/androidx/core/content/ContextCompatTest.java
M core/core/src/androidTest/java/androidx/core/content/IntentCompatTest.java
M core/core/src/androidTest/java/androidx/core/content/res/ResourcesCompatTest.java
M core/core/src/androidTest/java/androidx/core/os/BundleCompatTest.java
M core/core/src/androidTest/java/androidx/core/os/ParcelCompatTest.java
M core/core/src/androidTest/java/androidx/core/view/DisplayCutoutCompatTest.java
M core/core/src/main/java/androidx/core/app/ActivityCompat.java
M core/core/src/main/java/androidx/core/app/ComponentActivity.java
M core/core/src/main/java/androidx/core/app/GrammaticalInflectionManagerCompat.java
M core/core/src/main/java/androidx/core/app/ServiceCompat.java
M core/core/src/main/java/androidx/core/content/ContextCompat.java
M core/core/src/main/java/androidx/core/content/IntentCompat.java
M core/core/src/main/java/androidx/core/os/LocaleListCompat.java
M core/core/src/main/java/androidx/core/os/ParcelCompat.java
M core/core/src/main/java/androidx/core/text/util/LocalePreferences.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityNodeInfoCompat.java
M credentials/credentials-play-services-auth/src/androidTest/java/androidx/credentials/playservices/CredentialProviderPlayServicesImplJavaTest.java
M credentials/credentials-play-services-auth/src/androidTest/java/androidx/credentials/playservices/CredentialProviderPlayServicesImplTest.kt
M credentials/credentials/src/androidTest/java/androidx/credentials/PrepareGetCredentialResponseJavaTest.java
M credentials/credentials/src/androidTest/java/androidx/credentials/PrepareGetCredentialResponseTest.kt
M credentials/credentials/src/androidTest/java/androidx/credentials/TestUtils.kt
M credentials/credentials/src/androidTest/java/androidx/credentials/provider/CredentialProviderServiceJavaTest.java
M credentials/credentials/src/androidTest/java/androidx/credentials/provider/CredentialProviderServiceTest.kt
M credentials/credentials/src/androidTest/java/androidx/credentials/provider/PendingIntentHandlerJavaTest.java
M credentials/credentials/src/androidTest/java/androidx/credentials/provider/PendingIntentHandlerTest.kt
M graphics/graphics-core/src/androidTest/java/androidx/graphics/lowlatency/CanvasFrontBufferedRendererTest.kt
M graphics/graphics-core/src/androidTest/java/androidx/graphics/lowlatency/SingleBufferedCanvasRendererV34Test.kt
M graphics/graphics-core/src/main/java/androidx/graphics/lowlatency/SingleBufferedCanvasRenderer.kt
M graphics/graphics-path/api/current.txt
M graphics/graphics-path/api/restricted_current.txt
M graphics/graphics-path/src/main/java/androidx/graphics/path/PathIterator.kt
M graphics/graphics-path/src/main/java/androidx/graphics/path/PathIteratorImpl.kt
M media/media/src/main/java/androidx/media/app/NotificationCompat.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/MediaRoute2Provider.java
M privacysandbox/ads/ads-adservices-java/src/androidTest/java/androidx/privacysandbox/ads/adservices/java/endtoend/TestUtil.java
M privacysandbox/sdkruntime/sdkruntime-client/src/main/java/androidx/privacysandbox/sdkruntime/client/SdkSandboxManagerCompat.kt
M privacysandbox/sdkruntime/sdkruntime-core/src/main/java/androidx/privacysandbox/sdkruntime/core/controller/SdkSandboxControllerCompat.kt
M recyclerview/recyclerview/src/androidTest/java/androidx/recyclerview/widget/StretchEdgeEffectTest.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/RoutesManager.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/activities/RouteListingPreferenceActivity.java
M text/text/src/main/java/androidx/compose/ui/text/android/BoringLayoutFactory.kt
M text/text/src/main/java/androidx/compose/ui/text/android/StaticLayoutFactory.kt
M transition/transition/src/androidTest/java/androidx/transition/ChangeBoundsTest.java
M transition/transition/src/androidTest/java/androidx/transition/ChangeClipBoundsTest.java
M transition/transition/src/androidTest/java/androidx/transition/ChangeImageTransformTest.java
M transition/transition/src/androidTest/java/androidx/transition/ChangeScrollTest.java
M transition/transition/src/androidTest/java/androidx/transition/ExplodeTest.java
M transition/transition/src/androidTest/java/androidx/transition/FadeTest.java
M transition/transition/src/androidTest/java/androidx/transition/SeekTransitionTest.kt
M transition/transition/src/androidTest/java/androidx/transition/SlideEdgeTest.java
M transition/transition/src/main/java/androidx/transition/Transition.java
M transition/transition/src/main/java/androidx/transition/TransitionManager.java

https://android-review.googlesource.com/2647279

dm...@ownid.com <dm...@ownid.com> #4Mar 31, 2023 04:13PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8479537c5d8391619a500a8c8ad18197dacf760b
Author: Alan Viverette <alanv@google.com>
Date: Thu Jun 29 09:23:38 2023

Rename BuildCompat prior to Kotlin migration

Bug: 289269026
Test: BuildCompatTest
Change-Id: I982a309fe5d8d95d915d0ad7ab69ebbf80c13933

M core/core/src/main/java/androidx/core/os/BuildCompat.kt

https://android-review.googlesource.com/2645579

he...@google.com <he...@google.com> #5Mar 31, 2023 04:25PM

Project: platform/frameworks/support
Branch: androidx-main

commit e9944e08804986b874b2dac5e563a2fcc725c011
Author: Alan Viverette <alanv@google.com>
Date: Thu Jun 29 09:26:04 2023

Convert BuildCompat to Kotlin

Relnote: Migrated BuildCompat to Kotlin for enhanced Deprecated tag
Bug: 289269026
Test: BuildCompatTest
Change-Id: I56775e11c79e893138b67add76f758489a4262de

M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/os/BuildCompat.kt

https://android-review.googlesource.com/2642076

dm...@ownid.com <dm...@ownid.com> #6Mar 31, 2023 04:52PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.2.0-beta01

Fri Mar 31 2023 19:41:31 GMT+0300 (Eastern European Summer Time).png

55 KB

View

Download

Fri Mar 31 2023 19:42:51 GMT+0300 (Eastern European Summer Time).png

108 KB

View

Download

dm...@ownid.com <dm...@ownid.com> #7Mar 31, 2023 05:39PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.appcompat:appcompat:1.7.0-alpha03
androidx.core:core:1.12.0-beta01
androidx.credentials:credentials:1.2.0-beta01
androidx.credentials:credentials-play-services-auth:1.2.0-beta01
androidx.privacysandbox.sdkruntime:sdkruntime-client:1.0.0-alpha07
androidx.privacysandbox.sdkruntime:sdkruntime-core:1.0.0-alpha07

he...@google.com <he...@google.com> Apr 3, 2023 06:45PM

Reassigned to ak...@google.com.

ak...@google.com <ak...@google.com> #8Apr 5, 2023 09:52PM

Accepted by ak...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.mediarouter:mediarouter:1.6.0-beta01
androidx.privacysandbox.ads:ads-adservices-java:1.1.0-alpha01

ak...@google.com <ak...@google.com> #9Apr 5, 2023 10:19PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.graphics:graphics-core:1.0.0-alpha05

NonConfiguredDefaultCanceled.mp4

7.4 MB

Download

AppConfigured.mp4

16 MB

Download

ap...@google.com <ap...@google.com> #10Apr 6, 2023 12:58AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.recyclerview:recyclerview:1.4.0-alpha01

dm...@ownid.com <dm...@ownid.com> #11Apr 6, 2023 07:04AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.media:media:1.7.0-beta01

ah...@gmail.com <ah...@gmail.com> #12Apr 6, 2023 09:41PM

Comment has been deleted.

Message last modified on Apr 6, 2023 10:04PM

ah...@gmail.com <ah...@gmail.com> #13Apr 6, 2023 09:57PM

Comment has been deleted.

Message last modified on Apr 6, 2023 10:00PM

ah...@gmail.com <ah...@gmail.com> #14Apr 6, 2023 09:58PM

ah...@gmail.com <ah...@gmail.com> #15Apr 6, 2023 09:59PM

ah...@gmail.com <ah...@gmail.com> #16Apr 6, 2023 10:03PM

Comment has been deleted.

Message last modified on Apr 6, 2023 10:05PM

ah...@gmail.com <ah...@gmail.com> #17
Restricted+
Apr 6, 2023 10:06PM

Comment has been deleted.

ap...@google.com <ap...@google.com> #18Apr 12, 2023 04:40PM

Project: platform/frameworks/support
Branch: androidx-main

commit a75fcac0d319a411a6d750119b9ac2e0f3585a7c
Author: Arpan Kaphle <akaphle@google.com>
Date: Mon Apr 10 20:56:24 2023

Configuration Change Consistency in Play Auth Flow

This change is a follow up to a prior change that handles more general
configuration changes - or really anything that restarts the app
(assuming it is run in the proper scope, namely a non cancellation
inducing scope in the programming). This ensures that the behaviour of the underlying
module is consistent and returns credentials as expected.

Bug: 276316128
Bug: 276939495
Test: E2E Test and Build
Change-Id: Iae8ce99fa56d237d874c5af2c61a914aaaeb85e4

M credentials/credentials-play-services-auth/src/main/java/androidx/credentials/playservices/HiddenActivity.kt
M credentials/credentials-play-services-auth/src/main/java/androidx/credentials/playservices/controllers/CredentialProviderBaseController.kt
M credentials/credentials-play-services-auth/src/main/java/androidx/credentials/playservices/controllers/CredentialProviderController.kt

https://android-review.googlesource.com/2530241

ak...@google.com <ak...@google.com> #19Apr 12, 2023 04:58PM

I hope you can excuse me for the delayed response. We have put up a new solution that should contain the expected behavior. If the calling application uses a cancellable scope as @he...@google.com mentioned above, a proper JobCancellationException will be thrown. If a non cancellable scope is used, even on configuration change, our library will ensure proper return of credentials. You can expect this change to arrive in the next release, around May.

In the meantime, to try this out you can use a snapshot SDK from https://androidx.dev/. Any buildId >= 9928302 works. Here's an example of using the 9928302 snapshot:

Step 1: Add the following maven url line to your build.gradle file.

allprojects {
    repositories {
        google()
        jcenter()
        maven { url 'https://androidx.dev/snapshots/builds/9928302/artifacts/repository' }
    }
}

Step 2: Depend on the snapshot version artifact:

dependencies {
    def work_version = '1.0.0-SNAPSHOT'
    implementation "androidx.credentials:credentials-play-services-auth:$work_version"
    ...
}

Thank you for your patience, and please let us know if there are any other issues. We appreciate your help in making Credential Manager better prior to the final launch.

sg...@google.com <sg...@google.com> Apr 12, 2023 05:21PM

Marked as fixed.

dm...@ownid.com <dm...@ownid.com> #20Apr 13, 2023 05:46AM

I confirm that issue is fixed. Thanks! However memory leak is still present. Will open another issue for that.

pr...@google.com <pr...@google.com> #21Apr 19, 2023 06:13PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.credentials:credentials-play-services-auth:1.0.0-alpha07

gu...@gmail.com <gu...@gmail.com> #22Dec 15, 2023 10:50AM

Hello, I also have the same problem, but not because of the landscape portrait.
When I call getCredential() and the identity selection pops up, I select an account and the popover cancels, and then nothing
The code:
fun Login(mActivity:Activity,mCredentialManager: CredentialManager,mGoogleIdOption: GetGoogleIdOption){
viewModelScope.launch {
try {
val request: GetCredentialRequest = GetCredentialRequest.Builder()
.addCredentialOption(mGoogleIdOption)
.build()
val result = mCredentialManager.getCredential(mActivity,request)
if (result != null) {
handleSignIn(result)
} else {

}
} catch (e: GetCredentialException) {
Log.e(LoginActivity.TAG, e.toJson())
}
}
}
Error: {"errorMessage":"activity is cancelled by the user.","type":"android.credentials.GetCredentialException. TYPE_USER_CANCELED","detailMessage":"activity is cancelled by the user.","stackTrace":[]}

Configured version: implementation "com.google.android.libraries.identity.googleid:googleid:1.1.0"
implementation("androidx.credentials:credentials:1.3.0-alpha01")
implementation("androidx.credentials:credentials-play-services-auth:1.3.0-alpha01”)

gu...@gmail.com <gu...@gmail.com> #23Dec 15, 2023 10:56AM

This is my screen

1092_1702636763.mp4

785 KB

Download

sg...@google.com <sg...@google.com> #24Dec 15, 2023 08:57PM

This looks like a different issue, could you please open a new bug with more details about which version of jetpack you're using, which version of android you're running, a bug report and etc.

Issue 276316128

Description

Issue summary

Comments

su...@google.com <su...@google.com> Mar 31, 2023 08:59AM

he...@google.com <he...@google.com> #2Mar 31, 2023 03:30PM

he...@google.com <he...@google.com> #3Mar 31, 2023 03:36PM

dm...@ownid.com <dm...@ownid.com> #4Mar 31, 2023 04:13PM

he...@google.com <he...@google.com> #5Mar 31, 2023 04:25PM

dm...@ownid.com <dm...@ownid.com> #6Mar 31, 2023 04:52PM

dm...@ownid.com <dm...@ownid.com> #7Mar 31, 2023 05:39PM

he...@google.com <he...@google.com> Apr 3, 2023 06:45PM

ak...@google.com <ak...@google.com> #8Apr 5, 2023 09:52PM

ak...@google.com <ak...@google.com> #9Apr 5, 2023 10:19PM

ap...@google.com <ap...@google.com> #10Apr 6, 2023 12:58AM

dm...@ownid.com <dm...@ownid.com> #11Apr 6, 2023 07:04AM

ah...@gmail.com <ah...@gmail.com> #12Apr 6, 2023 09:41PM

ah...@gmail.com <ah...@gmail.com> #13Apr 6, 2023 09:57PM

ah...@gmail.com <ah...@gmail.com> #14Apr 6, 2023 09:58PM

ah...@gmail.com <ah...@gmail.com> #15Apr 6, 2023 09:59PM

ah...@gmail.com <ah...@gmail.com> #16Apr 6, 2023 10:03PM

ah...@gmail.com <ah...@gmail.com> #17 Restricted+ Apr 6, 2023 10:06PM

ap...@google.com <ap...@google.com> #18Apr 12, 2023 04:40PM

ak...@google.com <ak...@google.com> #19Apr 12, 2023 04:58PM

Step 1: Add the following maven url line to your build.gradle file.

Step 2: Depend on the snapshot version artifact:

sg...@google.com <sg...@google.com> Apr 12, 2023 05:21PM

dm...@ownid.com <dm...@ownid.com> #20Apr 13, 2023 05:46AM

pr...@google.com <pr...@google.com> #21Apr 19, 2023 06:13PM

gu...@gmail.com <gu...@gmail.com> #22Dec 15, 2023 10:50AM

gu...@gmail.com <gu...@gmail.com> #23Dec 15, 2023 10:56AM

sg...@google.com <sg...@google.com> #24Dec 15, 2023 08:57PM

Add comment

Issue metadata

ah...@gmail.com <ah...@gmail.com> #17
Restricted+
Apr 6, 2023 10:06PM