Calling postponeEnterTransition caused leak [276375110]

Fixed

Bug

Status Update

No update yet.

Description

ni...@ansman.se

created issue #1

Mar 31, 2023 01:25AM

Component used: Fragment
Version used: 1.5.6

If you call Fragment.postponeEnterTransition with a delay, Fragment will post a runnable on a Handler with the specified delay as the delay. This runnable is not removed when calling startPostponedEnterTransition however which means that if the fragment is destroyed it will be retained until the runnable finally runs.

You can easily verify this with LeakCanary by having two fragments where in the first fragment you call postponeEnterTransition(1, TimeUnit.HOURS) and then you navigate to the other fragment. When leak canary runs you can see that the initial fragment is retained.

The solution should be to remove the runnable when calling startPostponedEnterTransition. This might not be feasible in the case where you call postponeEnterTransition before the fragment is attached but it feels OK to ignore that case for now.

Comments

il...@google.com <il...@google.com> Mar 31, 2023 08:55PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Apr 9, 2023 01:42PM

We'll track fixing specifically DialogFragment in this issue.

ni...@ansman.se <ni...@ansman.se> #3Apr 10, 2023 01:59PM

Project: platform/frameworks/support
Branch: androidx-main

commit 75ee4a9efb5e1f8ff1b1dfca5bfeb151a7605f54
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Feb 22 15:44:08 2021

Set ViewTree owners for dialogs in DialogFragment

While Fragments with a view set their ViewTree owners automatically,
since DialogFragments do not always have a view (as in the case of only
using onCreateDialog), it is possible to have a DialogFragment but no
ViewTree owners set.

We should set the ViewTree owners on the DialogFragment dialog's decor
view. This way it can be accessed.

RelNote: "Dialogs within a DialogFragment can now get access to ViewTree
owners through their DecorView"
Test: testDialogFragmentViewTree
Bug: 180691023

Change-Id: Ib92905306e16dcaee63c985f22b5e36b6718dd39

A fragment/fragment/src/androidTest/java/androidx/fragment/app/DialogFragmentViewTreeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java

https://android-review.googlesource.com/1600577

jb...@google.com <jb...@google.com> #4Apr 11, 2023 07:40PM

This has been fixed internally and will be released as part of the Fragment 1.3.1 version.

You can verify this by following the snapshot instructions with build id 7166224 and switching your fragment dependency to 1.4.0-SNAPSHOT.

ni...@hinge.co <ni...@hinge.co> #5Apr 11, 2023 07:41PM

With this bug essentially meaning that DialogFragments cannot be used with Compose, would it be possible to please backport this fix into the Fragment 1.3.0 version?

ap...@google.com <ap...@google.com> #6Apr 12, 2023 04:06PM

Re #5 - as per comment#4, this will be made available in Fragment 1.3.1.

jb...@google.com <jb...@google.com> #7Apr 12, 2023 05:04PM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.5.7 and 1.6.0-beta01 releases.

pr...@google.com <pr...@google.com> #8Apr 19, 2023 06:12PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.fragment:fragment:1.5.7
androidx.fragment:fragment:1.6.0-beta01