Fixed
Status Update
No update yet.
Comments
jo...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 6788d20ba865fee90b162faa6ae4d5c4c6b66d92
Author: Matvei Malkov <malkov@google.com>
Date: Thu May 28 18:35:55 2020
Replace MutuallyExclusiveSetItem with Modifier.Selectable.
Last foundation interaction has been moved to modifiers here. Also with indication and interactionState support to bring together these pieces.
Since it's not an Item anymore, I chencged the name from MutuallyExclusiveSetItem to Selectable, as it's selectable within this set, to makes sense to me. I also added boolean param to control whether it's in the set or just a single value.
Change-Id: I02b473710e5a654427b51565c0b950392f68fcff
Relnote: MutuallyExclusiveSetItem has been deprecated. Use Modifier.selectable instead.
Bug: 157642842
Test: has been changed to work with new modifier
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
A ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/SelectableSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SelectableTest.kt
D ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/MutuallyExclusiveSetItem.kt
A ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/TopAppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/BottomNavigation.kt
M ui/ui-material/src/main/java/androidx/ui/material/RadioButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/Tab.kt
https://android-review.googlesource.com/1318898
Branch: androidx-master-dev
commit 6788d20ba865fee90b162faa6ae4d5c4c6b66d92
Author: Matvei Malkov <malkov@google.com>
Date: Thu May 28 18:35:55 2020
Replace MutuallyExclusiveSetItem with Modifier.Selectable.
Last foundation interaction has been moved to modifiers here. Also with indication and interactionState support to bring together these pieces.
Since it's not an Item anymore, I chencged the name from MutuallyExclusiveSetItem to Selectable, as it's selectable within this set, to makes sense to me. I also added boolean param to control whether it's in the set or just a single value.
Change-Id: I02b473710e5a654427b51565c0b950392f68fcff
Relnote: MutuallyExclusiveSetItem has been deprecated. Use Modifier.selectable instead.
Bug: 157642842
Test: has been changed to work with new modifier
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
A ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/SelectableSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SelectableTest.kt
D ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/MutuallyExclusiveSetItem.kt
A ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/TopAppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/BottomNavigation.kt
M ui/ui-material/src/main/java/androidx/ui/material/RadioButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/Tab.kt
ha...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 852980c73a7ba8b2fceef531a122e6d24c839202
Author: Matvei Malkov <malkov@google.com>
Date: Thu May 28 17:53:26 2020
Make Toggleable be Modifier.toggleable
This CL makes Toggleable component be just a modifier, while also adding features presented in Modifier.clickable (interactonState, indication)
Relnote: Toggleable component has been deprecated. Use Modifier.toggleable instead
Bug:157642842
Test: converted
Change-Id: I35220fca0d9d11198d1158cb905cfb2586965a34
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ToggleableSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ToggleableTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-material/src/main/java/androidx/ui/material/Checkbox.kt
M ui/ui-material/src/main/java/androidx/ui/material/IconButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
https://android-review.googlesource.com/1318897
Branch: androidx-master-dev
commit 852980c73a7ba8b2fceef531a122e6d24c839202
Author: Matvei Malkov <malkov@google.com>
Date: Thu May 28 17:53:26 2020
Make Toggleable be Modifier.toggleable
This CL makes Toggleable component be just a modifier, while also adding features presented in Modifier.clickable (interactonState, indication)
Relnote: Toggleable component has been deprecated. Use Modifier.toggleable instead
Bug:157642842
Test: converted
Change-Id: I35220fca0d9d11198d1158cb905cfb2586965a34
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ToggleableSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ToggleableTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-material/src/main/java/androidx/ui/material/Checkbox.kt
M ui/ui-material/src/main/java/androidx/ui/material/IconButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
jo...@google.com
both toggeable and mutuallyExclusive set were migrated to modifiers
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 762bbc3cea2a9bcfb6fae34e71c6bb8da917f43c
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon May 15 11:50:25 2023
[M2] Expose AnchoredDraggable components' progress
Fixes: 271169225
Fixes: 276375124
Fixes: 276776071
Fixes: 270066861
Relnote: BottomSheetState, ModalBottomSheetState and BottomDrawerState now expose a progress property indicating the progress between the current (settled) anchor and the closest anchor in the swipe direction.
Test: AnchoredDraggable tests
Change-Id: I1b31727b4f56df890e336bea9f4de526733aaacc
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AnchoredDraggable.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
https://android-review.googlesource.com/2588925
Branch: androidx-main
commit 762bbc3cea2a9bcfb6fae34e71c6bb8da917f43c
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon May 15 11:50:25 2023
[M2] Expose AnchoredDraggable components' progress
Fixes: 271169225
Fixes: 276375124
Fixes: 276776071
Fixes: 270066861
Relnote: BottomSheetState, ModalBottomSheetState and BottomDrawerState now expose a progress property indicating the progress between the current (settled) anchor and the closest anchor in the swipe direction.
Test: AnchoredDraggable tests
Change-Id: I1b31727b4f56df890e336bea9f4de526733aaacc
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AnchoredDraggable.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.6.0-alpha01androidx.compose.material:material-android:1.6.0-alpha01
ju...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.5.0-beta03androidx.compose.material:material-android:1.5.0-beta03
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.compose:compose-material-core:1.2.0-rc01androidx.wear.compose:compose-ui-tooling:1.2.0-rc01
Description
Jetpack Compose version: bom:2023.03.00
Jetpack Compose component used: BottomSheetScaffold
Android Studio Build: #AI-222.4459.24.2221.9682058 (Android Studio Flamingo | 2022.2.1 Beta 5)
Kotlin version: 1.8.10
Steps to Reproduce or Code Sample to Reproduce:
Stack trace (if applicable): Screen recordings have been attached that shows the issue. Pay close attention to the
progressvalue in screenshot which is the reported progress. The progress reported is not smooth for initial swipe of bottomsheet.After updating compose-bom from 2023.01.00 (which uses 1.3.3 of compose-material) to 2023.03.00 (which uses 1.4.0 of compose-material) I started seeing issues with the bottom sheet progress callback.
My usecase: I need to calculate open-fraction of bottomsheet (i.e. when it's totally collapsed to it's peek height then open fraction is 0.0f and when it's fully expanded, open-fraction should be 1.0f).
Now based on this I need to derive few things like corner size, alpha and offsets of a few other elements. In short, if open-fraction is not reliable then UI will look shaky.
With 1.4.0 of compose-material, Bottomsheet started using
SwipeableV2Statewhich required quite some change for my usecase to work. Even then, the reported progress is not what I expected. After I start swipping up, the progress remains 0.0f until a certain point (I believe the point isSwipeableV2State.positionalThresholdbut not sure). After that point, reported progress goes directly from0.0to0.075and skips progress in between.Same thing happens when I start to collapse sheet from expanded state.