Status Update
No update yet.
Comments
jo...@google.com
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
ha...@gmail.com
Starting with 1.5.0-alpha03 (BottomDrawerState now have nullable offset and swipe target value along with current value. These two seems important for smooth animation as well. Any plans to do similar for BottomSheetState?
jo...@google.com
We are still evaluating the final API surface, but are looking to expose the currentValue, targetValue, and progress. The offset is an implementation detail of the component and we are not looking to expose it.
ap...@google.com
Branch: androidx-main
commit 762bbc3cea2a9bcfb6fae34e71c6bb8da917f43c
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon May 15 11:50:25 2023
[M2] Expose AnchoredDraggable components' progress
Fixes: 271169225
Fixes: 276375124
Fixes: 276776071
Fixes: 270066861
Relnote: BottomSheetState, ModalBottomSheetState and BottomDrawerState now expose a progress property indicating the progress between the current (settled) anchor and the closest anchor in the swipe direction.
Test: AnchoredDraggable tests
Change-Id: I1b31727b4f56df890e336bea9f4de526733aaacc
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AnchoredDraggable.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.6.0-alpha01androidx.compose.material:material-android:1.6.0-alpha01
ju...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.5.0-beta03androidx.compose.material:material-android:1.5.0-beta03
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.compose:compose-material-core:1.2.0-rc01androidx.wear.compose:compose-ui-tooling:1.2.0-rc01
Description
Jetpack Compose version: bom:2023.03.00
Jetpack Compose component used: BottomSheetScaffold
Android Studio Build: #AI-222.4459.24.2221.9682058 (Android Studio Flamingo | 2022.2.1 Beta 5)
Kotlin version: 1.8.10
Steps to Reproduce or Code Sample to Reproduce:
Stack trace (if applicable): Screen recordings have been attached that shows the issue. Pay close attention to the
progressvalue in screenshot which is the reported progress. The progress reported is not smooth for initial swipe of bottomsheet.After updating compose-bom from 2023.01.00 (which uses 1.3.3 of compose-material) to 2023.03.00 (which uses 1.4.0 of compose-material) I started seeing issues with the bottom sheet progress callback.
My usecase: I need to calculate open-fraction of bottomsheet (i.e. when it's totally collapsed to it's peek height then open fraction is 0.0f and when it's fully expanded, open-fraction should be 1.0f).
Now based on this I need to derive few things like corner size, alpha and offsets of a few other elements. In short, if open-fraction is not reliable then UI will look shaky.
With 1.4.0 of compose-material, Bottomsheet started using
SwipeableV2Statewhich required quite some change for my usecase to work. Even then, the reported progress is not what I expected. After I start swipping up, the progress remains 0.0f until a certain point (I believe the point isSwipeableV2State.positionalThresholdbut not sure). After that point, reported progress goes directly from0.0to0.075and skips progress in between.Same thing happens when I start to collapse sheet from expanded state.