Reported progress of BottomSheet skips initial progress [276375124]

Fixed

Bug

Status Update

No update yet.

Description

ha...@gmail.com

created issue #1

Mar 31, 2023 04:02PM

Jetpack Compose version: bom:2023.03.00

Jetpack Compose component used: BottomSheetScaffold

Android Studio Build: #AI-222.4459.24.2221.9682058 (Android Studio Flamingo | 2022.2.1 Beta 5)

Kotlin version: 1.8.10

Steps to Reproduce or Code Sample to Reproduce:

Implement BottomSheet from material library (not M3) which contains full-screen content
Start listening to the progress of bottom-sheet
Reprod repo is here: https://github.com/hbb20/BottomSheetIssue

Stack trace (if applicable): Screen recordings have been attached that shows the issue. Pay close attention to the progress value in screenshot which is the reported progress. The progress reported is not smooth for initial swipe of bottomsheet.

After updating compose-bom from 2023.01.00 (which uses 1.3.3 of compose-material) to 2023.03.00 (which uses 1.4.0 of compose-material) I started seeing issues with the bottom sheet progress callback.

My usecase: I need to calculate open-fraction of bottomsheet (i.e. when it's totally collapsed to it's peek height then open fraction is 0.0f and when it's fully expanded, open-fraction should be 1.0f).

Now based on this I need to derive few things like corner size, alpha and offsets of a few other elements. In short, if open-fraction is not reliable then UI will look shaky.

With 1.4.0 of compose-material, Bottomsheet started using SwipeableV2State which required quite some change for my usecase to work. Even then, the reported progress is not what I expected. After I start swipping up, the progress remains 0.0f until a certain point (I believe the point is SwipeableV2State.positionalThreshold but not sure). After that point, reported progress goes directly from 0.0 to 0.075 and skips progress in between.

https://user-images.githubusercontent.com/4918760/229168786-67611a02-2151-4b3a-a8bc-5944dec3f4f6.mov

Same thing happens when I start to collapse sheet from expanded state.

https://user-images.githubusercontent.com/4918760/229168780-b9cd6b93-1890-49cb-bde8-4fcb68c73c02.mov

back_jump.mov

4.6 MB

Download

start_jump.mov

3.1 MB

Download

Comments

jo...@google.com <jo...@google.com> #2Mar 31, 2023 06:02PM

Reassigned to jo...@google.com.

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

ha...@gmail.com <ha...@gmail.com> #3May 1, 2023 07:40PM

Thanks for the report!

jo...@google.com <jo...@google.com> #4May 5, 2023 08:40AM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

ap...@google.com <ap...@google.com> #5May 24, 2023 10:57AM

Marked as fixed.

deleted

pr...@google.com <pr...@google.com> #6Jun 21, 2023 08:57PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

ju...@google.com <ju...@google.com> #7Jun 28, 2023 11:52PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.5.0-beta03
androidx.compose.material:material-android:1.5.0-beta03

na...@google.com <na...@google.com> #8Jul 26, 2023 05:21PM