Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Apr 3, 2023 11:43PM

STEPS TO REPRODUCE:

Check out androidx
Remove 33 from android.suppressUnsupportedCompileSdk=UpsideDownCake,VanillaIceCream,33 in gradle.properties
./gradlew tasks

Expected

no warnings

Actual

warning of

  > Configure project :activity:activity
  WARNING: We recommend using a newer Android Gradle plugin to use compileSdk = 33
  
  This Android Gradle plugin (8.1.0-alpha11) was tested up to compileSdk = 33.
  
  You are strongly encouraged to update your project to use a newer
  Android Gradle plugin that has been tested with compileSdk = 33.
  
  If you are already using the latest version of the Android Gradle plugin,
  you may need to wait until a newer version with support for compileSdk = 33 is available.
  
  To suppress this warning, add/update
      android.suppressUnsupportedCompileSdk=UpsideDownCake,VanillaIceCream,33
  to this project's gradle.properties.

Studio Build: N/A
Version of Gradle Plugin: 8.1.0-alpha11
Version of Gradle: 8.0
Version of Java: 17
OS: linux

Comments

xa...@google.com <xa...@google.com> #2Apr 3, 2023 11:46PM

You can actually reproduce with any small project. Just make the following changes:

compileSdk = 33
compileSdkExtension = 5

run assembleDebug on the project.

Message last modified on Apr 3, 2023 11:46PM

ji...@google.com <ji...@google.com> Apr 4, 2023 05:54AM

Assigned to an...@google.com.

ga...@google.com <ga...@google.com> Apr 4, 2023 08:59AM

Reassigned to mi...@google.com.

mi...@google.com <mi...@google.com> #3Apr 10, 2023 06:03PM

When comparing SDK versions, the extension is taken into account. In the AndroidVersion.java file compareTo method, the extension level is provided for one version and not for the other. This causes the warnIfCompileSdkTooNew in SdkParsingUtils.kt to execute and the warning to trigger.

The question I have is, should the warning still trigger but specify the extension as the reason for why? Or should the comparison ignore the extension so that the warning does not trigger at all?

Message last modified on Apr 10, 2023 06:04PM

au...@google.com <au...@google.com> #4Apr 10, 2023 06:09PM

When I chatted with xav@, we thought that we should ignore the extension bit as all of these are incremental SDKs.

mi...@google.com <mi...@google.com> Apr 10, 2023 07:31PM

Accepted by mi...@google.com.

mi...@google.com <mi...@google.com> Apr 12, 2023 04:42PM

Marked as fixed.

au...@google.com <au...@google.com> #5Apr 21, 2023 12:21AM

Which build was it fixed in? Will the fix be in 8.1.0 stable?

mi...@google.com <mi...@google.com> #6Apr 21, 2023 05:20AM

It was checked in last Tuesday (4/12) so yes I believe it will be.

cm...@google.com <cm...@google.com> #7May 12, 2023 03:26PM

Cherrypick for AGP 8.1 is ag/23211216

IssueTracker

SDK version check does not handle users of SDK extensions

Status Update

Description

STEPS TO REPRODUCE:

Expected

Actual

Comments

xa...@google.com <xa...@google.com> #2Apr 3, 2023 11:46PM

ji...@google.com <ji...@google.com> Apr 4, 2023 05:54AM

ga...@google.com <ga...@google.com> Apr 4, 2023 08:59AM

mi...@google.com <mi...@google.com> #3Apr 10, 2023 06:03PM

au...@google.com <au...@google.com> #4Apr 10, 2023 06:09PM

mi...@google.com <mi...@google.com> Apr 10, 2023 07:31PM

mi...@google.com <mi...@google.com> Apr 12, 2023 04:42PM

au...@google.com <au...@google.com> #5Apr 21, 2023 12:21AM

mi...@google.com <mi...@google.com> #6Apr 21, 2023 05:20AM

cm...@google.com <cm...@google.com> #7May 12, 2023 03:26PM

Issue 276807774

Description

STEPS TO REPRODUCE:

Expected

Actual

Issue summary

Comments

xa...@google.com <xa...@google.com> #2Apr 3, 2023 11:46PM

ji...@google.com <ji...@google.com> Apr 4, 2023 05:54AM

ga...@google.com <ga...@google.com> Apr 4, 2023 08:59AM

mi...@google.com <mi...@google.com> #3Apr 10, 2023 06:03PM

au...@google.com <au...@google.com> #4Apr 10, 2023 06:09PM

mi...@google.com <mi...@google.com> Apr 10, 2023 07:31PM

mi...@google.com <mi...@google.com> Apr 12, 2023 04:42PM

au...@google.com <au...@google.com> #5Apr 21, 2023 12:21AM

mi...@google.com <mi...@google.com> #6Apr 21, 2023 05:20AM

cm...@google.com <cm...@google.com> #7May 12, 2023 03:26PM

Add comment

Issue metadata